Comments by Grant Goodale on scripts
41 comments
|
Comment on: |
Gah. I've let this slip - my apologies. I'll have a release out shortly. |
|
Comment on: |
@Mikie_: Hadn't seen those before. How annoying. I'll have a look. |
|
Comment on: |
Ah, thanks for the info. I'll roll that change into the next version. |
|
Comment on: |
Ah, thanks for the info. I'll roll that change into the next version. |
|
Comment on: |
@Eric: Thanks. :) @Descriptor: Sorry for the slow reply. I wasn't aware of the FF-only textContent function, honestly. I'd like to claim I don't use it because I'm desperately holding out for CreamMonkey/GreaseKit support in an upcoming version (which I am, by the way), but it just isn't true. Is there some advantage to textContent? |
|
Comment on: |
Okay, 8.2 is up and should fix Linkworth and Vibrant Media blocking. Apologies for the delay. For those who care, using iterator-style result sets with document.evaluate() is a bad idea if you're planning on modifying the DOM - the iterator is invalidated once you change the document (hence the problems with only some links being removed). |
|
Comment on: |
@Descriptor: Believe it or not, I have other demands on my time. Yes, DOMNodeInsertedIntoDocument appears to be the wrong choice; it appeared to work at one point in FF2.x on Mac, likely because of something wrong with my test suite rather than any real success. No, I haven't released a new version that fixes the problems previously noted; I'm seeing inconsistent results when blocking Vibrant Media ads and digging through their js to determine why takes time. I'm certainly open to alternative approaches; patches happily accepted. I'll likely reject anything that involves touching every single anchor tag on the page, however, as page rendering performance suffers greatly on slower machines. Thanks for the EchoTopic patch - I'll include it in the next release. |
|
Comment on: |
Grumble. Some interesting results regarding Vibrant Media - it would appear they're inserting their ads into the page in a couple of ways. The only reliable way to catch all of them seems to be in the load handler, which produces an annoying flicker as the links appear in the page and then are removed as I iterate over them. I'm still looking for a better solution - time to read the latest version of their js again. |
|
Comment on: |
@Descriptor - thanks for pointing that out. Your comment led me to a different solution. @dan: Linkworht blocking should work for you in 8.1 - let me know if it doesn't. |
|
Comment on: |
@Stan_Green - this script isn't designed to work on pop-up ads or banner ads, just text link ads. The OpenAds I saw on Girl's Life were banner ads, and I didn't see any text link ads on the pcmag page you linked (with our without this script running). |
|
Comment on: |
Thanks Matt - new version posted. |
|
Comment on: |
@Grinch: Okay, I'll have a look.
|
|
Comment on: |
Bah. My bad coding, not Kontera's cleverness. All should be well now. |
|
Comment on: |
@Grinch: It seems Kontera's changed their html structure a bit. Guess I have something to do this weekend. :) Thanks for the tip! |
|
Comment on: |
Erm, yeah. Teach me to optimize after testing. Fixed. Sorry for the inconvenience. |
|
Comment on: |
@Choix: Grab the newly released v7.2 - it should fix AdBrite blocking. Thanks for the heads up. Amazon's text link ads appear to have disappeared from the 'net. Maybe they've realized people don't like them. |
|
Comment on: |
If you post a url that has ads that aren't blocked, I'll see what I can do. |
|
Comment on: |
@briansnj - Looks like a new type of popup. *sigh* Expect an update soon. Thanks for the tip! |
|
Comment on: |
Yep, horked things up with 7.0. 7.1 is up now, which should fix the issues with IntelliTXT. And Targetpoint. And AdBrite. *sigh* |
|
Comment on: |
@Sorian - Can you link me a page that you're seeing ads on? |
|
Comment on: |
New version's up - it should once again block AdBrite ads, though I couldn't find ads on Demonoid to test against. Let me know how it works. I've also added support for blocking Targetpoint ads , as seen on KezNews. |
|
Comment on: |
Thanks for the tip - I'll release a new version in the next day or so. |
|
Comment on: |
@jwight: That's an unusual error to get from Firefox. Do you have any other firefox extensions installed? How did you try to install the script? |
|
Comment on: |
@pulseforce - That torrent no longer exists, unfortunately. I'll track down another example and fix the problem shortly. |
|
Comment on: |
Well, that was something of a hiatus. The good news is, I've been in contact with the developers of lingospot who've included a very simple way to block all of their ads in the latest version of their code. I've rolled out a new version to take advantage of this. Kudos to them for giving the user a choice to opt out. |
