Comments by David Jacobitz on scripts
8 comments
|
Comment on: |
It looks like resize *does* fire on that tab-switch event, but there was a race condition with some of gmail's code. Made the processing for resize delay, and now it works. Probably. |
|
Comment on: |
Nope. Though I think I can now reproduce the behavior, which is a step ahead of where I was before. My current theory is that this happens when gmail reloads while it is not the active tab. Then when you switch back to that tab, bang - the view pane resizes and drops down. The problem is that I'm not sure I can get events to fire on that. Checking now. |
|
Comment on: |
*sigh* When I logged in this morning, the dropping-down problem happened again. So apparently the google-products ad element was not the culprit. The error console messages suggest it was actually the fact that it was missing some resize events - it looks like a resize event fires while there is no gmonkey object. So I've said screw it and added equivalent functions to deal if there is no gmonkey (and therefore no gmail extension) object. It is working, but I'm reluctant to update the source until I'm sure the dropping-down thing is fixed this time. I'll give it a couple days. |
|
Comment on: |
Apparently, in getting its shit together, gmail reloads the window approximately 74 billion times, but only once with the gmonkey object...in the middle of other loads. Moved the resize listener outside the check for gmonkey, and all is apparently good with the world. |
|
Comment on: |
As for the chat box issue, it seems to load by itself after the main page load, and re-updates its width. Added a setTimeout kludge to make our changes stick after it's loaded. |
|
Comment on: |
Ok, I think I found the "dropping down" problem - the little internal ads line below the main pane that auto-updates with things like "use Google product <bla>, because it's teh awesome" - occasionally something would pop in there that's long enough to try to resize the pane, making it too large. Unfortunately, something changed in gmail and now the resize event on the window no longer fires. So I added a line to just snip out the internal ad div. Does anyone know if there's any way to capture window resize events in gmail now?</bla> |
|
Comment on: |
Kerim: On the main pane dropping down - I've noticed that too, not sure what's up yet, I'll let you know. Chat box should be easy enough, I'll get that updated shortly. Deb: Not sure, I'll take a look. |
|
Comment on: |
Needs an update - changed the search class to "little" and the element tags to all "form" now (not form, span, span), then it worked for me. |
