Comments by Julien Carosi on scripts

28 comments

Hiromacu : Thanks for your comment !

FYI, next version will allow you to customize shortcut. ;-)

Julien.

Strawbeard : the script doesn't run on gmail, so it must not be GPE that prevents '?' from working. I also tried to deactivate GPE on Google Reader website, and the '?' key doesn't even work.

Julien.

Hi Madhavan,

Yes it's a known problem with some sites that escape from the frame, I'm working on that, among other new features.

Stay tuned ;-)

Julien.

v1.07g just released. Fixes automatic scrolling to top of article when preview is opened. Also fixes Shift-V shortcut.

Now doesn't rely on Google's code so scrolling to top of article and preview shortcut will still work even if Google's code changes.

As a remember, here are the ways, you can open preview :
- Click on preview button
- Click on article's title in expanded view
- Type Shift-V

Julien.

Just released v1.07f. Fixes bug introduced with v1.07e. Sorry for the inconvenience.

Comment on:
GPE

Apr 9, 2008

Please don't install this script as it is just a steal from my original script Google Reader Preview Enhanced which orginal url is http://userscripts.org/scripts/show/9455 .

Julien.

Hi, I just released a fix that makes the script work with Google's new code.

I also e-mailed Lifehacker's team in order to ask for an update to the extension.

Btw, I had no time to work on the script and I plan to release the big update in the next weeks. I'd like to know what are your biggest requests or suggestions to improve GPE. Here is a mix between what I read in the comments and some things I thought by myself :

- Revert mode (article shows in preview mode by default)
- Remember which sites should open in preview mode by default
- Multilangual support
- Full screen article preview
- Search support
- Iframe auto-sizing, eliminating the need for scrollbars (configurable)
- Prevent iframe escape for some sites
- Auto update

I really would like to know what are the features that you want first. So please post here in the comments or e-mail me.

Thanks,

Julien.

Script updated. Shortcut now works back. Same for auto scrolling to top of article. It's mainly a bugfix release.

A major upgrade will be released soon, that will include all the features asked in the comments plus some new great ones. Hold on !

Thadk, right now, I don't have a solution to prevent a website from trying to escape from its iframe.

I tried :
- Using watch to monitor window.location value change and thus prevent it from changing. That could be done easily but doesn't work with location.replace, as watch doesn't trigger when this method is called.

- Overriding window.location.prototype.replace but firefox doesn't allow us to do that.

- Attaching a function to the unload event of the webpage that sets window.location back to Google Reader's url but that forces a refresh of the page..

Any other idea ? :-)

Update released.

Adds support for https urls and fixes problem when typing Shift-V in dialog boxes. Please send me your feedback !

Julien.

Justin : happy to hear that it works now. I will include https urls in the next release, so people won't have to add them themselves. Thanks for your report.

Alex and Justin : it should works on your system too. Do you have any error showing in the javascript console ? You can also send me an e-mail to jcarosi (at) gmail.com with details on your system if you want custom support.

Alex and Justin : it should works on your system too. D+--++a&

Script updated, thanks coder2007 and Volkan for the reports. Shortcut now works back. Same for auto scrolling to top of article.

Should upgrade your monkey ! :-)

Comment on:
NQS (Netvibes QuickShare) v1.1

Jun 24, 2007

Twitter users : you can now subscribe to my twitter http://www.twitter.com/JulienCarosi in order to be informed of new releases !
Dont't worry you will not be bored with things like what I am doing at this time etc... ;-)

Twitter users : you can now subscribe to my twitter http://www.twitter.com/JulienCarosi in order to be informed of new releases !
Dont't worry you will not be bored with things like what I am doing at this time etc... ;-)

Lapino, thanks for your report. I just upgraded the script.

I added a try/catch statement in order to make the script still work even if code changes again, though not scrolling to top of article when previewing. So if it brokes again, one can still use the script until an upgrade is released.

theaulddubliner : a quick modification would be to replace (line 110) link.addEventListener('click', previewMouseClick, false); by link.addEventListener('click', function(e) { if (e.ctrlKey) { previewMouseClick(e); } }, false); but ctrl+click (by default) opens a link in a new tab in firefox.. so ctrl-click will load the preview and also open the original website in a new tab. Can work if you know a way to disable this feature in firefox configuration. Note : preventDefault() doesn't help.

theaulddubliner : a quick modification would be to replace (line 110) link.addEventListener('click', previewMouseClick, false); by link.addEventListener('click', function(e) { if (e.ctrlKey) { previewMouseClick(e); } }, false); but ctrl+click (by default) opens link a new tab in firefox.. so ctrl-click will load the preview and open a new tab. Can work if you know

Raffles : good remark ;) I'll change that in the next release, so it will comply with xhtml strict specifications.

As some of you asked for a preview button at the top of the article, and in order to maximize compatibility with styling scripts, I decided to use the article's title link to show its preview.

So in v1.07, if you click on an article's title, it will show its preview. Thus you don't need to scroll it down before previewing it.

The title link's goal was previously to open the article in a new window but, ihmo, this is not needed with preview functionnality.

Let me know what you think of this feature.

Julien.

delfick : pb with "find as you type" actived is now fixed, thanks for reporting the bug.

coder2007 : good idea, shortcut added in v1.06. Now you can press Shift-V to preview article or go back to rss view.

Shift-V seemed natural as V is the initial key for loading the original article in a pop-up.

v1.05a adds better support for Better GReader extension.

With the extension installed, the action bar is pushed to the right for esthetic reasons. Some of you may have already noticed that in List View, when clicking on "Preview" the action bar didn't go down as it should, (and as it does in "Expanded view") when the iframe appears. This leaded to action bar and iframe superposition and the impossibility to go back to classic rss article view.

It's okay now.

    Technical explanation :
Better GReader adds some css (float: right) for entry-actions div. But this pushes the div outside of the document flow. So when the iframe is added, the action bar go automatically down. The script now parses css entries added by Better GReader and changes "float: right" for "text-align: right" that has the same effect, though keeping the div in the document flow.

Julien.

It was working when I uploaded it. Function name changed again. Just updated.

Julien