YousableTubeFix

By Mindeye Last update Feb 19, 2014 — Installed 808,547 times.

Not working on Nightly 20120202 build

in
Subscribe to Not working on Nightly 20120202 build 19 posts, 11 voices



dummy123 User
FirefoxWindows

I know you may not want to solve issues regarding to Nightly build, but here is just for the record.

Since 20120202 build when I go to a Youtube watch page, YousableTubeFix does not load and shows a warning in the Error Console:

Timestamp: 2/2/2012 1:00:33
Warning: 
[YousableTubeFix@httpuserscripts.orgscriptsshow13333] "return" from the main scope is not generally supported. You should fix that in your user script.
Source File: file:///C:/Users/.../Profiles/[censored]/scriptish_scripts/yousabletubefix@httpuserscriptsorgscriptsshow13333/yousabletubefix@httpuserscriptsorgscriptsshow13333.user.js
Line: 1696

The script was working fine in 0131 build, as well as Firefox 10.
Thanks in advanced!

 
spin User
FirefoxX11

EDIT (retracted previous stuff): Nevermind, I can confirm dummy123's issue; I am using Nightly 13 + Scriptish 0.1.7 + Flash 11.2.202.197 on Ubuntu 10.04 x86_64. I tried toggling ABP, NoScript, Ghostery and HTTPS Everywhere to no avail.

 
Hollander Scriptwright
FirefoxWindows

Aye, confirming this as well.

 
Mindeye Script's Author
FirefoxWindows

I have tested the script with the nightly and I see the script buttons (the resize button is disabled) so I think it's some change in the interaction between my code and the player. I don't think is something I can fix and I don't want to spend time trying to workaround something that could be fixed tomorrow. If future builds don't fix the problem then I'll review it again later.

 
D_A User
FirefoxMacintosh

Looks like this is fallout from bug 90268

Adblock Plus author filed a bug about this here: https://bugzilla.mozilla.org/show_bug.cgi?id=72...

 
Xphome User
FirefoxWindows

Indeed, very annoying when I'm used to videos not autoplaying.

 
KrAZ User
FirefoxWindows

I use Fx nightly and scriptish nightly, and it doesn't work either. The config menu is there, but it cannot modify the page.

 
kostelo User
FirefoxWindows

Same here, not working on nightlies. Tried even fresh install with new profile but no-go. Let's hope for a fix.

 
Photon_Man62 User
FirefoxWindows

It hasn't been working on Nightlies for ages now. Shame, this was my favourite userscript, and nightlies are far superior to stable builds.

 
Mindeye Script's Author
FirefoxWindows

It has been less than a month, "ages" is not the appropriate term. But it doesn't seem they will fix the problem, so I have taken a closer look at it: they have broken the player reload (now the plugin isn't reloaded when its src is changed). Chrome has the same bug, so I had to implement a workaround in the Chrome version of the script.

Replace...:

VideoAdapter.prototype.reloadPlayer = function() {
this._isAPIReady = false; //'
this.player.src = this.player.src;
};

...with...:

VideoAdapter.prototype.reloadPlayer = function() {
this._isAPIReady = false; //'
this.player.outerHTML = this.player.outerHTML;
this.player = $(this.playerId);
};

Replace...:

// Adds a listener to call channelPlayerInsertion if the player is inserted in the page
playerDiv.addEventListener("DOMNodeInserted", function(evt) {
var targetId = evt.target.id;
if ((targetId === YT_PLAYER_ID_FLASH) || (targetId === YT_PLAYER_CHANNEL_NEW_ID_FLASH) || (targetId === YT_PLAYER_CHANNEL_NEW_ID_HTML5)) channelPlayerInsertion(targetId);
}, false);

...with...:

// Adds a listener to call channelPlayerInsertion if the player is inserted in the page
playerDiv.addEventListener("DOMNodeInserted", function(evt) {
var meSt = arguments.callee;
var targetId = evt.target.id;
if ((targetId === YT_PLAYER_ID_FLASH) || (targetId === YT_PLAYER_CHANNEL_NEW_ID_FLASH) || (targetId === YT_PLAYER_CHANNEL_NEW_ID_HTML5)) {
if (!meSt.skipReloadNextEvent) {
meSt.skipReloadNextEvent = true; // Skips the next player insertion because the player reload (caused by a new VideoAdapter/VideoAdapterHTML5 creation in channelPlayerInsertion) will trigger the listener
channelPlayerInsertion(targetId);
}
else {
meSt.skipReloadNextEvent = false;
}
}
}, false);

 
Photon_Man62 User
FirefoxWindows

On the internet, a week is an age.

 
Mindeye Script's Author
FirefoxWindows

Only on impatient people's minds. ;-)

More important, does it work for you with this modification or there's some other problem?

 
kancaras Scriptwright
FirefoxWindows

thank mindeye!! changes you mentioned above fixed the problem for me !!

 
spin User
FirefoxWindows

Mindeye, the script *hasn't* worked on Nightly for ages; more precisely it hasn't worked since December 2. Well to be perfectly honest, it did work for one day sometime in January...

FIX IT BROTHA

 
noroom User
FirefoxWindows

Hey Mindeye. First of all, allow me to apologize in the name of every rude user with a sense of entitlement, and to thank you for improving YouTube without expecting anything in return. Try to remember people are bugging you so much because you've done such a good job that YouTube just sucks without your script. :)

That being said, I tried applying the fix you outlined in your previous post to the Firefox script, and it had no obvious effect; the script still doesn't work. I assume the fix will only work on Chrome.

At the moment I'm using Firefox 13 (UX), so I expect things to break. And since they might be fixed in the next release, it would be truly silly for you to invest time in finding and repairing problems that a) you didn't cause, b) might be fixed the next day. But damn if I don't miss YousableTubeFix!

Just remember behind every annoying user with a sense of entitlement you'll find a big fan of your work that just doesn't know how to express themselves. :)

 
Mindeye Script's Author
FirefoxWindows

Thanks for your kind words noroom. :-)

The fix I posted works for Firefox, make sure you are applying it ok and editing the right file (I tested it using the current Firefox and Scriptish nightlies). I'm waiting to update to see if they fix the bug they introduced, because the method to reload the player in the fix code is worse than the one the script currently uses.

 
noroom User
FirefoxWindows

You were right, I must've made a mistake. Maybe because I wasn't using the Scriptish nightly? Anyway, I reinstalled the script from this site, edited as per your instructions, and installed the latest Scriptish nightly, and now your script is working again.

Thank you so hard.

 
dummy123 User
FirefoxWindows

Somehow this issue is gone in Nightly 0326 build, without applying the workaround from Chrome.

 
Mindeye Script's Author
FirefoxWindows

Yes, I have checked the last nightly and the bug is fixed. ;-)