Call to script authors: GM_registerMenuCommand?

in Script development
Subscribe to Call to script authors: GM_registerMenuCommand? 3 posts, 3 voices



Mar 29, 2011 6:48pm
arantius Scriptwright
FirefoxX11

Ref: http://groups.google.com/group/greasemonkey-dev...

Greasemonkey is trying to adapt to the model that Firefox 4 is encouraging/forcing on extensions; trying to get rid of the icon in the status bar. This has prompted some rewrites to attempt to support Firefox 3 as-is for some transition period, while still supporting Firefox 4 in the newer style.

As part of this work, I more-or-less intentionally broke accelerator keys for GM_registerMenuCommand(). I've since gone back and forth a few times as to whether I thought they ever worked correctly, and if I should continue it a priority to make them work before I call this task "finished".

Do you use GM_registerMenuCommand()? Do you use the accelKey and accelModifiers parameters? If so, do you see them _work_? The best I have been able to come up with so far is seeing them mostly work, but rapidly break as I open/close tabs and load pages. I've never used this feature myself and I don't know of any good documentation for it. I'm starting to consider getting rid of accelerator keys altogether.

So, if you ...
A) Use these features
B) Want these features to remain
C) Can help me understand how this is supposed to work, and prove that it ever did in the past (a script that runs in Firefox 3.6 + Greasemonkey 0.8, and a description of how it is supposed to work would be great)
... Please get in touch with me.

I'd prefer, if possible, that you communicate with the entire development community at greasemonkey-dev@googlegroups.com . You can also email me directly at arantius@gmail.com . I'll try to monitor this topic as well. Thanks.
 
Mar 30, 2011 8:22am
Marti Scriptwright
FirefoxX11

arantius wrote:
Do you use GM_registerMenuCommand()
Yes... sizzles spam reporting script uses it to load the list to submit if not marking one. Some others use it for miscellaneous tasks too.

arantius wrote:
Do you use the accelKey and accelModifiers parameters?
No... I believe I read somewhere a long time ago that the menu popup needs to be opened for them to work in GM with FF 3.x and below. Currently the GM HEAD doesn't allow testing because the AOB loses focus and so does 0.8.6/FF3.6.16.

Maybe something along the lines of adding the accelerators only to the primary menu (Tools > Greasemonkey) would work since those are available?

ABP has a successful hotkey to open blockable items from the AOB... so it is possible in at least one instance.

arantius wrote:
B) Want these features to remain
There aren't a huge amount of USO scripts that utilize the accelerator keys but quite a few do use the menu without them... including some dynamic libs... so potentially 100%.

Please consider accessibility users in the decision before removing everything related. (e.g. the visually impaired usually)

Moz has also encountered some issues with other add-ons in way too many possible orders that conflict with one another in FF4.0. So keep that in mind before making a bunch of changes. GM HEAD disabled allows one of my extensions to work without killing Firefox where with GM HEAD enabled it doesn't, etc. GM isn't the only culprit either. I think this is more of a FF issue right now and is going to take some time to resolve upstream and crossstream... till then perhaps more testing in the FF3.x versions and lowering the priority of GM_registerMenuCommand changes would be prudent.
 
Mar 31, 2011 4:40am
Jefferson Scher Scriptwright
FirefoxWindows

arantius wrote:
Do you use GM_registerMenuCommand()? Do you use the accelKey and accelModifiers parameters?
Yes. No (or if I did, I don't think it's critical since most people will be mousing to it).