Script not working anymore

in
Subscribe to Script not working anymore 23 posts, 3 voices



SiX User
FirefoxWindows

Hello Futuros

I use your script alot! So thank you for making it.

However yesterday it stopped working.

I created a category, and noticed it wasn't there, so I took the rebuild option. The category was present then, but he doesn't detect my movies anymore.

When I add a movie to a category, he does it, but when I reload the page, its like I don't have it, and if I add it again, I got it 2 times.

I tried uninstalling the script, uninstalling greasemonkey, deleted the gm maps in FF, nothing helps.

Following errors in Error Window on Debug 2:

http://img340.imageshack.us/img340/9067/4005325...

Hope you can help me, I don't want to reinstall FF.

Greetings

SiX

 
Futuros Script's Author
FirefoxWindows

If i understand you correctly, you cant add movies to a category.

Can you make a copy of the error console with only the error section & info section.
Do this after you've tried to add some categories. But before you reload.

 
SiX User
FirefoxWindows

Info section:

http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Init: http://www.imdb.com/title/tt0878804/
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Page type: title
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: 1 imdb links found

Error section is empty

 
SiX User
FirefoxWindows

When I open the mymovies page:

Errors:

Error: e.originalTarget.location is null
Source File: chrome://customizegoogle/content/browser.xul
Line: 14
Error: document.body is null
Source File: file:///C:/Documents%20and%20Settings/SiX/Application%20Data/Mozilla/Firefox/Profiles/67v25wjq.SiX/gm_scripts/imdb_movie_collection_ma/imdb_movie_collection_ma.user.js
Line: 549

Info:
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Categories updated. 18 categorie(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Movie list updated. 0 movie(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Vote history updated. 2 vote(s) found

 
Futuros Script's Author
FirefoxWindows

It seems it can't load the movies from your mymovies section.

Do you have any titles in mymovies already. If you dont try adding one without the script.
http://www.imdb.com/mymovies/list?a=1 should have all your movies

 
SiX User
FirefoxWindows

6191 Titles on that page

 
SiX User
FirefoxWindows

Do you have msn? Or are you on IRC?

I tested the script on a fresh installed pc with ff en greasemonkey, and it doesnt work either, so the problem must be with my list.

 
SiX User
FirefoxWindows

What I found out: If I give the movie a score, its get added to the movie list.

In the variable with the movies, he lists the movies that have a vote, not the other 6000+

 
SiX User
FirefoxWindows

It is fixed.

What I did:

I added some :(categorynumbers) manually to some movies in the variable and then did a rebuild.

Now he find all the movies.

 
nascent Scriptwright
FirefoxWindows

So to continue the conversation in the requested features thread:

I have the two ftrs strings in about:config.. either of which are empty.

also, all of my "Must See" movies are rated. So I don't think I am having the same problems as SiX.

 
Futuros Script's Author
FirefoxWindows

@six i'm glad its all working again.

FF probably had a problem writing the new stored values.

 
Futuros Script's Author
FirefoxWindows

@nascent

Did you visit http://www.imdb.com/mymovies/list?a=1
how many movies are listed.

Check the info panel on the error console. It should say
...
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Vote history updated. *** vote(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Categories updated. ** categorie(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Movie list updated. **** movie(s) found

FF might have a problem writing the data.
Try deleting both values. Or overwriting them. It seems that is what solved SiX problems.

 
nascent Scriptwright
FirefoxWindows

My movies page has 212 Titles

and as I said in the other thread..:
with debug mode (2) I get:
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Init: http://www.imdb.com/title/tt0137523/
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Page type: title
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: 1 imdb links found

It should be noted that it puts the rating of movies I have rated on links pointing to that movie.. so it's able to do that much. It's just the mymovies functionality that doesn't work - even after clearing the values.

 
Futuros Script's Author
FirefoxWindows

You don't show the debug while visiting http://www.imdb.com/mymovies/list?a=1
That is the mymovies section on imdb.

Have you also tried deleting the stored values for the script through about:config

 
nascent Scriptwright
FirefoxWindows

I deleted the values in about:Config with no change

The debug is:
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Movie list updated. 0 movie(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Categories updated. 3 categorie(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Vote history updated. 1162 vote(s) found
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Page type: mymovies
http://userscripts.org/IMDb Movie Collection Manager - by Futuros: Init: http://www.imdb.com/mymovies/list?a=1
Warning: Error in parsing value for 'cursor'. Declaration dropped.
Source File: http://www.imdb.com/mymovies/list?a=1
Line: 1

 
Futuros Script's Author
FirefoxWindows

This is odd.
The categories are found so the page is correctly loaded through Ajax.

When you visit: http://www.imdb.com/mymovies/list?a=1 there is a big list of movies on that page right?

Try changing around line 442: i have added two debug lines starting l('debug

Dont copy completely i had to alter some lines because it didnt display correctly.

/*--- set movies ---*/
var movs = data.match(/<*******************);
l('debug: '+movs); // <------>
var movcount=0;
if(movs){
for (var i=0; i < movs.length; i++) {
m = movs[i];
l('debug2: '+m); // <------>
if (!m) continue;
m2 = m.match(/list\?l=(\d+).*\n.*popup\/mmnote\?id=(\d+):(\d+)/);
if (!m2||m2[1]==categories.getId('Recycle Bin')||m2[1]==categories.getId('Pending')) continue;
movies.add({'tid': m2[3], 'categoryid':m2[1], 'controlid':m2[2]});
movcount++;
}
movies.save();
}
l('Movie list updated. '+movcount+' movie(s) found', 1);
/*--- update page ---*/

You do have movies in other categories then pending and recycle bin? These two are ignored.

 
nascent Scriptwright
FirefoxWindows

I do not have anything in pending or recycle bin only a "Must See" category.

I replaced the code with the code you suggest, but see no difference, what should I now be looking for?

 
Futuros Script's Author
FirefoxWindows

In the console window there will be two more debug lines both starting with 'debug:'

I need to know whats in them. Because the script says it finds 0 movies.
So probably 1 or both of these debug values are also empty.

Also try to add extra categories and add some movies to that.
It's hard for me to figure out whats wrong. So you've got to experiment some. And hope it helpes.

 
nascent Scriptwright
FirefoxWindows

Ok, I've pasted the debug results here http://pastebin.ca/1734970

and I added an extra category "test" and added a movie to that with no change.

 
Futuros Script's Author
FirefoxWindows

okay i've figured it out.

On http://www.imdb.com/mymovies/list?a=1 go to the bottom and click [change display options].

On the next page you should see category: My Movies(all)
Check in the right column [notes]
You dont need show note in list view.

 
nascent Scriptwright
FirefoxWindows

Yay! I ticked notes and it's working. Thanks for the help, now I get to enjoy the use of your great script. IMDB really is 10x better now.

I'm curious now, what does note have to do with it? all the notes are empty.

 
Futuros Script's Author
FirefoxWindows

To add/remove a movie to a category you need the movie_id and category_id.
And you also need some kind of security code which is unique for each movie. This code is also used in the link to edit the notes.
So thats the easiest way to obtain it.

 
nascent Scriptwright
FirefoxWindows

Ah ok :)

Well it doesn't take much space on the page so I'm cool leaving the notes there.

Perhaps you can do some sort of alert when the notes column doesn't exist to tell the user that it is needed for the future.

As for me, consider my issue closed.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel