Google Showtimes

By sizzlemctwizzle Last update Feb 22, 2009 — Installed 448 times.

I think I fixed the script

in
Subscribe to I think I fixed the script 2 posts, 2 voices



chscorpio User
FirefoxWindows

Nice script. This was just what I was looking for. I thought I was at a lost when I read that you had "completely abondoned" it. Was the "terrible error" only caused by google changing the showtimes layout and possible mismatches in the imdb ids?

If so, I fixed the script. With my changes, it is working great for me. What is the best way to send you the changes so you can post a new version?

I basically made the following changes:

* Disabled the plan ahead feature as those links have been moved to the left side bar and I was more interested in the rotten tomatoes ratings.
* Built an imdb map of title to imdb_id instead of an array of imdb_ids because the imdb array index didn't always match the movies array index.
* Inserted a new SPAN to contain the rotten tomatoes rating instead of using an existing element and set the title of the SPAN to the normalized movie title (which I need to build the imdb map) and set the class of the span to icon with 1em height (and removing the icon class from the innerHTML img elements).
* Refactored the titles parsing code and the rating builder code into a single function named getMoviesAndInsertRatingSpan(xpath, noAnchorElement).
* Refactored the imdb builder code into a single function named getTitleImdbMap(xpath).
* Used getMoviesAndInsertRatingSpan and getTitleImdbMap with different xpath expressions to correctly insert ratings when browsing showtimes by "Theaters" or by "Movies" including when viewing a specific theater or movie.

 
sizzlemctwizzle Script's Author
FirefoxMacintosh

I'm very surprised anyone could fix the shitty code used in this script. It wasn't just the layout change. This script was written so poorly that when I went to accommodate for the change I couldn't make heads or tails out of my own code. So the unmaintainable code is what really caused be to abandon it.

I'm secretly planning to bring this script back to life. I've already fixed some simple parts like the plan ahead feature you disabled, but the major task still ahead involves a rethink of the whole fetching ratings system(specifically the Caching system). Living without this script has been a pain for me. I never what movies I should go and see, but hopefully I'll get it back up in running soon. I appreciate your offer to help, but I'd rather do this rewrite alone since it's my baby.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel