great but does not work on Oracle site

in
4 posts, 3 voices

Oct 19, 2009 1:05am JimboJones User	The script works great, I tested it on quite a lot of sites, I have issues with Oracle.com site, the script does not convert any documents from this site http://www.oracle.com/pls/db112/homepage

Oct 19, 2009 9:07am 2x Scriptwright	You can use encoreURIComponent (at least it seems to work for the oracle.com). Just don't forget to convert _all_ .pdf links to Google Docs links. Something like this: (function(){ if (location.href.indexOf(" var l = document.getElementsByTagName("a"); var i = l.length; while (i--) { if (l[i].href.match(/\.(pdf\|ppt\|tif)$/)) { l[i].href = 'http://docs.google.com/viewer?url=' + encodeURIComponent(l[i].href); } } } })();

Oct 19, 2009 4:55pm Koonies Script's Author	Current version doesn't convert a URL intentionally if the URL include '?'. If you want to do soon, please change the following part. * current code if (l[i].href.match(/^[^?]+.(pdf\|ppt\|tif)$/)) { * changed code if (l[i].href.match(/.(pdf\|ppt\|tif)$/)) { But it is wrong in the case of the following. [Before] http://docs.google.com/viewer?url=http://igor.chudov.com/diveintogreasemonkey.pdf [After] http://docs.google.com/viewer?http://docs.google.com/viewer?url=http://igor.chudov.com/diveintogreasemonkey.pdf Probably I will upload improved version a few days later.

Oct 20, 2009 10:52pm Koonies Script's Author	I've uploaded the new version.

Userscripts.org