Some improvements to the script

Oct 2, 2009 9:19am

I've made some improvements to your script:

* More translated links.
* Fixed the "Problem with Gallery Tags" bug mentioned in the previous discussion thread.
* Translate button text.

Here's a diff:

--- script-old.js 2009-10-02 02:12:03.000000000 -0700
+++ pixiv_on_english.user.js 2009-10-02 02:18:08.000000000 -0700
@@ -28,9 +28,16 @@
"#page_top",
"mypage.php",
"illust_upload.php",
- "bookmark.php",
+ "bookmark.php?type=illust_all",
+ "bookmark.php?type=user&rest=show",
+ "bookmark.php?type=user&rest=hide",
"bookmark.php?type=user",
"bookmark.php?type=reg_user",
+ "bookmark.php?rest=show",
+ "bookmark.php?rest=hide",
+ "bookmark.php?order=asc",
+ "bookmark.php?order=desc",
+ "bookmark.php",
"mypixiv_all.php",
"msgbox.php",
"edit.php",
@@ -54,21 +61,38 @@
"ranking.php?mode=month",
"member_tag_all.php",
"premium.php",
+ "event.php?d=",
+ "event.php",
+ "profile_chg.php",
+ "info.php",
+ "terms.php",
+ "guideline.php",
+ "privacy.php",
+ "contact.php",
+ "support.php",
//other users
"msg_send.php",
"bookmark_add.php",
"mypixiv_add.php",
- "member.php",
- "member_board.php"
+ "member_board.php",
+ "response.php",
+ "illust_infomsg.php"
//"bookmark_illust_user.php"
);
var lTexts = new Array(
"Top",
"User Page",
"Upload Picture",
- "Bookmarks",
+ "All Bookmarks",
+ "Public Bookmarked Users",
+ "Hidden Bookmarked Users",
"Bookmarked Users",
"Followers",
+ "Public Booksmarks",
+ "Hidden Bookmarks",
+ "Oldest First",
+ "Newest First",
+ "Bookmarks",
"Friends",
"Messages",
"Edit Profile",
@@ -92,50 +116,100 @@
"Monthly Top",
"All Tags",
"Pixiv Premium",
+ "Current Events",
+ "Events",
+ "Change Profile",
+ "Info",
+ "Terms",
+ "Guidelines",
+ "Privacy",
+ "Contact",
+ "Support",
//other users
"Send Message",
"Add to Bookmarks",
"Add Friend",
- "User Profile",
- "Member Board"
+ "Member Board",
+ "Responses",
+ "Report"
//"Bookmark author"
);
+ var submitOrig = new Array(
+ "　検　索　",
+ "追加する",
+ "　追加する　",
+ "非公開にする",
+ "ブックマーク解除",
+ "　外　す　",
+ "公開にする",
+ "　ブックマークに追加する　",
+ "　ブックマークを編集する　"
+ );
+ var submitEnglish = new Array(
+ "Search",
+ "Add Tag",
+ "Bookmark User",
+ "Hide",
+ "Delete",
+ "Delete",
+ "Unhide",
+ "Add Bookmark",
+ "Edit Bookmark"
+ );

function makeChange(link_element) {
for (var i=0; i<lhrefs>
var IndexOf1 = link_element.href.indexOf(lHrefs[i]);
//var IndexOf2 = link_element.href.indexOf(lHrefs[i]+"?id=");
- if (IndexOf1 != -1 && link_element.innerHTML.indexOf(""+lTexts[i]+"";
return;
}
- else if (link_element.href.indexOf("illust_infomsg.php") != -1) {
- link_element.innerHTML = "Report";
- }
+ /*
else if (link_element.href.indexOf("member_illust.php") != -1 && (link_element.href.indexOf("?") == -1 || link_element.href.indexOf("?id=") != -1)) {
link_element.innerHTML = "Gallery";
}
- /*
- else if ((link_element.href.indexOf("member_illust.php?id=") != -1 && link_element.href.indexOf("&") == -1) ||
+ */
+ else if ((link_element.href.indexOf("member_illust.php?id=") != -1 && link_element.href.indexOf("&") == -1 && document.location.href.indexOf("bookmark.php") == -1) ||
(link_element.href.indexOf("member_illust.php") != -1 && link_element.href.indexOf("?") == -1)) {
link_element.innerHTML = "Gallery";
}
- */
else if (link_element.href.indexOf("tags.php") != -1 && link_element.href.indexOf("?") == -1) {
link_element.innerHTML = "Tags";
}
- else if (link_element.href.indexOf("bookmark.php") != -1) {
-
- }
- else if (link_element.href.indexOf("bookmark.php") != -1 && ((link_element.href.indexOf("?") == -1 || link_element.href.indexOf("?id=") != -1) && link_element.href.indexOf("&p=") == -1)) {
- link_element.innerHTML = "Bookmarks";
- }
else if (link_element.href.indexOf("tools.php") != -1 && link_element.href.indexOf("?") == -1) {
link_element.innerHTML = "Tools";
}
else if (link_element.getAttribute("onclick") == "one_comment_view()") {
link_element.innerHTML = "View comments";
}
+ else if (link_element.getAttribute("onclick") == "markAllUser('f'); return false;") {
+ link_element.innerHTML = "Check all";
+ }
+ else if (link_element.getAttribute("onclick") == "unmarkAllUser('f'); return false;") {
+ link_element.innerHTML = "Uncheck all";
+ }
+ // member.php is used in "by UserName"
+ // links, so don't replace where there's
+ // likely to be a "by". Also don't replace
+ // images used for bookmakred users,
+ // friends and followers.
+ else if (link_element.href.indexOf("member.php") != -1 && link_element.innerHTML.indexOf("User Profile";
+ }
+ else if (link_element.href.indexOf("bookmark_illust_user.php") != -1 && link_element.innerHTML.indexOf("users") == -1)
+ {
+ link_element.innerHTML = "Users Who've Bookmarked";
+ }

}
@@ -153,5 +227,29 @@
}
}

+ function changeFormElement(form_element)
+ {
+ if (form_element.type == "submit") {
+ for (var i=0; i < submitOrig.length; i++)
+ {
+ if (form_element.value == submitOrig[i])
+ {
+ form_element.value = submitEnglish[i];
+ return;
+ }
+ }
+ }
+ }
+
+ function changeForms() {
+ for (var i=0; i<document>
+ var form = document.forms[i];
+
+ for (var j=0; j<form>
+ changeFormElement(form.elements[j]);
+ }
+ }
+ }

changeLinks();
+ changeForms();

Oct 2, 2009 9:20am

khym_chanur User

Oops, forgot about the pre tag. I'll try again:

--- script-old.js       2009-10-02 02:12:03.000000000 -0700
+++ pixiv_on_english.user.js    2009-10-02 02:18:08.000000000 -0700
@@ -28,9 +28,16 @@                                                 
                             "#page_top",                          
                             "mypage.php",                         
                             "illust_upload.php",                  
-                            "bookmark.php",                       
+                            "bookmark.php?type=illust_all",       
+                            "bookmark.php?type=user&rest=show",   
+                            "bookmark.php?type=user&rest=hide",   
                             "bookmark.php?type=user",             
                             "bookmark.php?type=reg_user",         
+                            "bookmark.php?rest=show",             
+                            "bookmark.php?rest=hide",             
+                            "bookmark.php?order=asc",             
+                            "bookmark.php?order=desc",            
+                            "bookmark.php",                       
                             "mypixiv_all.php",                    
                             "msgbox.php",                         
                             "edit.php",                           
@@ -54,21 +61,38 @@                                                
                             "ranking.php?mode=month",             
                             "member_tag_all.php",                 
                             "premium.php",                        
+                            "event.php?d=",                       
+                            "event.php",                          
+                            "profile_chg.php",                    
+                            "info.php",                           
+                            "terms.php",                          
+                            "guideline.php",                      
+                            "privacy.php",                        
+                            "contact.php",                        
+                            "support.php",                        
                     //other users                                 
                             "msg_send.php",                       
                             "bookmark_add.php",                   
                             "mypixiv_add.php",                    
-                            "member.php",                         
-                            "member_board.php"                    
+                            "member_board.php",                   
+                            "response.php",                       
+                            "illust_infomsg.php"                  
                             //"bookmark_illust_user.php"          
                     );                                            
                     var lTexts = new Array(                       
                             "Top",                                
                             "User Page",                          
                             "Upload Picture",                     
-                            "Bookmarks",                          
+                            "All Bookmarks",                      
+                            "Public Bookmarked Users",            
+                            "Hidden Bookmarked Users",            
                             "Bookmarked Users",                   
                             "Followers",                          
+                            "Public Booksmarks",                  
+                            "Hidden Bookmarks",                   
+                            "Oldest First",                       
+                            "Newest First",                       
+                            "Bookmarks",                          
                             "Friends",                            
                             "Messages",                           
                             "Edit Profile",                       
@@ -92,50 +116,100 @@                                              
                             "Monthly Top",                        
                             "All Tags",                           
                             "Pixiv Premium",                      
+                            "Current Events",                     
+                            "Events",                             
+                            "Change Profile",                     
+                            "Info",                               
+                            "Terms",                              
+                            "Guidelines",                         
+                            "Privacy",                            
+                            "Contact",                            
+                            "Support",                            
                     //other users                                 
                             "Send Message",                       
                             "Add to Bookmarks",                   
                             "Add Friend",                         
-                            "User Profile",                       
-                            "Member Board"                        
+                            "Member Board",                       
+                            "Responses",                          
+                            "Report"                              
                             //"Bookmark author"                   
                     );                                            
+                    var submitOrig = new Array(                   
+                            "　検　索　",                         
+                            "追加する",                           
+                            "　追加する　",                       
+                            "非公開にする",                       
+                            "ブックマーク解除",                   
+                            "　外　す　",                         
+                            "公開にする",                         
+                            "　ブックマークに追加する　",         
+                            "　ブックマークを編集する　"          
+                    );                                            
+                    var submitEnglish = new Array(                
+                            "Search",                             
+                            "Add Tag",                            
+                            "Bookmark User",                      
+                            "Hide",                               
+                            "Delete",                             
+                            "Delete",                             
+                            "Unhide",                             
+                            "Add Bookmark",                       
+                            "Edit Bookmark"                       
+                    );                                            
                                                                   
                     function makeChange(link_element) {           
                             for (var i=0; i<lhrefs>";
+                                    }


                             }
@@ -153,5 +227,29 @@
                             }
                     }

+                    function changeFormElement(form_element)
+                    {
+                        if (form_element.type == "submit") {
+                            for (var i=0; i < submitOrig.length; i++)
+                            {
+                                if (form_element.value == submitOrig[i])
+                                {
+                                    form_element.value = submitEnglish[i];
+                                    return;
+                                }
+                            }
+                        }
+                    }
+
+                    function changeForms() {
+                            for (var i=0; i<document><form>

Oct 2, 2009 11:28am

sairin Script's Author

Hi there!
Thank you for your improvements and for fixing the "Tags" bug.
To say the truth, it is the considered decision to translate only main items on Pixiv in order to don't slow down the site (even my script makes Pixiv load slower). This script is a part of pictorial guide, and all buttons and items are translated in the guide.
Anyway, I don't mind if you make your own script combining my and your translations, it may be useful thing, and I'd like to link your work on the guide page.

Oct 25, 2009 11:39pm

khym_chanur User

"I'd like to link your work on the guide page."

Sure, go ahead.

Userscripts.org

pixiv No Ads Browsing

Some improvements to the script

Voices

Oct 2, 2009 9:19am khym_chanur User	I've made some improvements to your script: * More translated links. * Fixed the "Problem with Gallery Tags" bug mentioned in the previous discussion thread. * Translate button text. Here's a diff: --- script-old.js 2009-10-02 02:12:03.000000000 -0700 +++ pixiv_on_english.user.js 2009-10-02 02:18:08.000000000 -0700 @@ -28,9 +28,16 @@ "#page_top", "mypage.php", "illust_upload.php", - "bookmark.php", + "bookmark.php?type=illust_all", + "bookmark.php?type=user&rest=show", + "bookmark.php?type=user&rest=hide", "bookmark.php?type=user", "bookmark.php?type=reg_user", + "bookmark.php?rest=show", + "bookmark.php?rest=hide", + "bookmark.php?order=asc", + "bookmark.php?order=desc", + "bookmark.php", "mypixiv_all.php", "msgbox.php", "edit.php", @@ -54,21 +61,38 @@ "ranking.php?mode=month", "member_tag_all.php", "premium.php", + "event.php?d=", + "event.php", + "profile_chg.php", + "info.php", + "terms.php", + "guideline.php", + "privacy.php", + "contact.php", + "support.php", //other users "msg_send.php", "bookmark_add.php", "mypixiv_add.php", - "member.php", - "member_board.php" + "member_board.php", + "response.php", + "illust_infomsg.php" //"bookmark_illust_user.php" ); var lTexts = new Array( "Top", "User Page", "Upload Picture", - "Bookmarks", + "All Bookmarks", + "Public Bookmarked Users", + "Hidden Bookmarked Users", "Bookmarked Users", "Followers", + "Public Booksmarks", + "Hidden Bookmarks", + "Oldest First", + "Newest First", + "Bookmarks", "Friends", "Messages", "Edit Profile", @@ -92,50 +116,100 @@ "Monthly Top", "All Tags", "Pixiv Premium", + "Current Events", + "Events", + "Change Profile", + "Info", + "Terms", + "Guidelines", + "Privacy", + "Contact", + "Support", //other users "Send Message", "Add to Bookmarks", "Add Friend", - "User Profile", - "Member Board" + "Member Board", + "Responses", + "Report" //"Bookmark author" ); + var submitOrig = new Array( + "　検　索　", + "追加する", + "　追加する　", + "非公開にする", + "ブックマーク解除", + "　外　す　", + "公開にする", + "　ブックマークに追加する　", + "　ブックマークを編集する　" + ); + var submitEnglish = new Array( + "Search", + "Add Tag", + "Bookmark User", + "Hide", + "Delete", + "Delete", + "Unhide", + "Add Bookmark", + "Edit Bookmark" + ); function makeChange(link_element) { for (var i=0; i<lhrefs> var IndexOf1 = link_element.href.indexOf(lHrefs[i]); //var IndexOf2 = link_element.href.indexOf(lHrefs[i]+"?id="); - if (IndexOf1 != -1 && link_element.innerHTML.indexOf(""+lTexts[i]+""; return; } - else if (link_element.href.indexOf("illust_infomsg.php") != -1) { - link_element.innerHTML = "Report"; - } + /* else if (link_element.href.indexOf("member_illust.php") != -1 && (link_element.href.indexOf("?") == -1 \|\| link_element.href.indexOf("?id=") != -1)) { link_element.innerHTML = "Gallery"; } - /* - else if ((link_element.href.indexOf("member_illust.php?id=") != -1 && link_element.href.indexOf("&") == -1) \|\| + / + else if ((link_element.href.indexOf("member_illust.php?id=") != -1 && link_element.href.indexOf("&") == -1 && document.location.href.indexOf("bookmark.php") == -1) \|\| (link_element.href.indexOf("member_illust.php") != -1 && link_element.href.indexOf("?") == -1)) { link_element.innerHTML = "Gallery"; } - / else if (link_element.href.indexOf("tags.php") != -1 && link_element.href.indexOf("?") == -1) { link_element.innerHTML = "Tags"; } - else if (link_element.href.indexOf("bookmark.php") != -1) { - - } - else if (link_element.href.indexOf("bookmark.php") != -1 && ((link_element.href.indexOf("?") == -1 \|\| link_element.href.indexOf("?id=") != -1) && link_element.href.indexOf("&p=") == -1)) { - link_element.innerHTML = "Bookmarks"; - } else if (link_element.href.indexOf("tools.php") != -1 && link_element.href.indexOf("?") == -1) { link_element.innerHTML = "Tools"; } else if (link_element.getAttribute("onclick") == "one_comment_view()") { link_element.innerHTML = "View comments"; } + else if (link_element.getAttribute("onclick") == "markAllUser('f'); return false;") { + link_element.innerHTML = "Check all"; + } + else if (link_element.getAttribute("onclick") == "unmarkAllUser('f'); return false;") { + link_element.innerHTML = "Uncheck all"; + } + // member.php is used in "by UserName" + // links, so don't replace where there's + // likely to be a "by". Also don't replace + // images used for bookmakred users, + // friends and followers. + else if (link_element.href.indexOf("member.php") != -1 && link_element.innerHTML.indexOf("User Profile"; + } + else if (link_element.href.indexOf("bookmark_illust_user.php") != -1 && link_element.innerHTML.indexOf("users") == -1) + { + link_element.innerHTML = "Users Who've Bookmarked"; + } } @@ -153,5 +227,29 @@ } } + function changeFormElement(form_element) + { + if (form_element.type == "submit") { + for (var i=0; i < submitOrig.length; i++) + { + if (form_element.value == submitOrig[i]) + { + form_element.value = submitEnglish[i]; + return; + } + } + } + } + + function changeForms() { + for (var i=0; i<document> + var form = document.forms[i]; + + for (var j=0; j<form> + changeFormElement(form.elements[j]); + } + } + } changeLinks(); + changeForms();

Oct 2, 2009 9:20am khym_chanur User	Oops, forgot about the pre tag. I'll try again: --- script-old.js 2009-10-02 02:12:03.000000000 -0700 +++ pixiv_on_english.user.js 2009-10-02 02:18:08.000000000 -0700 @@ -28,9 +28,16 @@ "#page_top", "mypage.php", "illust_upload.php", - "bookmark.php", + "bookmark.php?type=illust_all", + "bookmark.php?type=user&rest=show", + "bookmark.php?type=user&rest=hide", "bookmark.php?type=user", "bookmark.php?type=reg_user", + "bookmark.php?rest=show", + "bookmark.php?rest=hide", + "bookmark.php?order=asc", + "bookmark.php?order=desc", + "bookmark.php", "mypixiv_all.php", "msgbox.php", "edit.php", @@ -54,21 +61,38 @@ "ranking.php?mode=month", "member_tag_all.php", "premium.php", + "event.php?d=", + "event.php", + "profile_chg.php", + "info.php", + "terms.php", + "guideline.php", + "privacy.php", + "contact.php", + "support.php", //other users "msg_send.php", "bookmark_add.php", "mypixiv_add.php", - "member.php", - "member_board.php" + "member_board.php", + "response.php", + "illust_infomsg.php" //"bookmark_illust_user.php" ); var lTexts = new Array( "Top", "User Page", "Upload Picture", - "Bookmarks", + "All Bookmarks", + "Public Bookmarked Users", + "Hidden Bookmarked Users", "Bookmarked Users", "Followers", + "Public Booksmarks", + "Hidden Bookmarks", + "Oldest First", + "Newest First", + "Bookmarks", "Friends", "Messages", "Edit Profile", @@ -92,50 +116,100 @@ "Monthly Top", "All Tags", "Pixiv Premium", + "Current Events", + "Events", + "Change Profile", + "Info", + "Terms", + "Guidelines", + "Privacy", + "Contact", + "Support", //other users "Send Message", "Add to Bookmarks", "Add Friend", - "User Profile", - "Member Board" + "Member Board", + "Responses", + "Report" //"Bookmark author" ); + var submitOrig = new Array( + "　検　索　", + "追加する", + "　追加する　", + "非公開にする", + "ブックマーク解除", + "　外　す　", + "公開にする", + "　ブックマークに追加する　", + "　ブックマークを編集する　" + ); + var submitEnglish = new Array( + "Search", + "Add Tag", + "Bookmark User", + "Hide", + "Delete", + "Delete", + "Unhide", + "Add Bookmark", + "Edit Bookmark" + ); function makeChange(link_element) { for (var i=0; i<lhrefs>"; + } } @@ -153,5 +227,29 @@ } } + function changeFormElement(form_element) + { + if (form_element.type == "submit") { + for (var i=0; i < submitOrig.length; i++) + { + if (form_element.value == submitOrig[i]) + { + form_element.value = submitEnglish[i]; + return; + } + } + } + } + + function changeForms() { + for (var i=0; i<document><form>

Oct 2, 2009 11:28am sairin Script's Author	Hi there! Thank you for your improvements and for fixing the "Tags" bug. To say the truth, it is the considered decision to translate only main items on Pixiv in order to don't slow down the site (even my script makes Pixiv load slower). This script is a part of pictorial guide, and all buttons and items are translated in the guide. Anyway, I don't mind if you make your own script combining my and your translations, it may be useful thing, and I'd like to link your work on the guide page.

Oct 25, 2009 11:39pm khym_chanur User	"I'd like to link your work on the guide page." Sure, go ahead.