Minor Fixes
in
2 posts,
2 voices
HoBo-Bob
Scriptwright
  |
I noticed that the Property ROI calculator wasn't working for me. After a lot of playing around I was able to get it working:
in function GM_MW_AddRate():
if (baseContainer && baseContainer.childNodes[1] && baseContainer.childNodes[1].childNodes[3] && baseContainer.childNodes[1].childNodes[3].innerHTML.indexOf('Properties') != -1)should be if (baseContainer && baseContainer.childNodes[1] && baseContainer.childNodes[1].childNodes[5] && baseContainer.childNodes[1].childNodes[5].innerHTML.indexOf('Properties') != -1)I also replaced: income=incomeTD.childNodes[3].childNodes[1].innerHTML.split("$")[1].split(",");
income2=income[0];
if(income[1]!=null)
income2=income[0]*1000;
else
income2=income[0]*1;with income=incomeTD.childNodes[3].childNodes[1].innerHTML.split("$")[1].replace(/,/g, "");and cost=costTD.childNodes[3].innerHTML.split("$")[1];
if(cost)
{
cost=cost.split(",");
if(cost[2]!=null)
price=cost[0]+cost[1]+cost[2];
else if(cost[1]!=null)
price=cost[0]+cost[1];
else
price=cost[0]*1;
rate=price/income2;
costTD.innerHTML += " <br /> Rate: <strong class=\"money\">" + rate.toFixed(1) +"</strong><strong>";
}with cost=costTD.childNodes[3].innerHTML.split("$")[1].replace(/,/g, "");
if(cost)
{
rate=cost/income;
costTD.innerHTML += " <br /> Rate: <strong class=\"money\">" + rate.toFixed(1) +"</strong><strong>";
}I don't think the last two changes were necessary, but they made more sense to me than the previous code. |
ThatOneGuy
Script's Author
|
Just a quick update: The original code was from somebody else so I didn't spend much time on the parts that worked. I have tried to implement these changes but have run into other problems and don't have the time right now to get it working... I'll get it as part of the next update, but I havne't forgotten about this bug. |
