Problems where Target URL's contain "&"

TinyURL Decoder

By setomits — Last update May 12, 2011 — Installed 74,234 times.

in
6 posts, 4 voices

Jul 18, 2009 6:17pm Tony Duckles User	I'm seeing that any TinyURL's where the _target_ URL has an "&" internally get decoded incorrectly. Since you're using XMLHttpRequest, any "&"'s in the target URL are encoded as "&" in the XML data since XML encodes "&" chars. As a quick fix, I added the following at the end of extract_from_response(), to translate "&amp" back to "&": ... theUrl = theUrl.replace(/&/g, '&'); // *ted 7/17/09 & -> & return theUrl; } Example: http://bit.ly/AMP3

Jul 18, 2009 6:22pm Tony Duckles User	Rats, didn't HTML-encode all of the above correctly. The comment in the code-block above is correct, the the text in the reg-ex didn't get encoded correctly. Just to clarify: "&"+"amp;" -> "&"

Jul 22, 2009 5:10am setomits Script's Author	Hi Tony Duckles, Thank you for your report. I modified and uploaded with your help. See you.

Mar 19, 2010 3:32am MAEDA Atusi User	Hi, Thanks for the great script setomits. BTW, it still has problems with URLs with more than one "&" characters. Example: http://j.mp/deL8Vi Cheers,

Mar 19, 2010 3:39am MAEDA Atusi User	P.S. I think the following should possibly fix the problem: `> cache[_node.href] = finalUrl.replace(/\\\|\\/, '').replace('&', '&'); < cache[_node.href] = finalUrl.replace(/\\\|\\/, '').replace(/&/g, '&');`

May 26, 2011 7:14pm Jatin Dh User	The quotes were missing. The following does the job for the link posted by MAEDA Atusi finalUrl.replace(/\\\|\\/, '').replace('&/g', '&');