FlickrZoom

By eoftedal Last update Feb 27, 2010 — Installed 40,372 times. Daily Installs: 68, 52, 55, 33, 52, 63, 48, 66, 76, 55, 107, 203, 159, 99, 77, 79, 71, 57, 74, 48, 68, 50, 51, 43, 96, 54, 47, 48, 55, 53, 37

Too easy to falsetrigger this script - suggested fix

Subscribe to Too easy to falsetrigger this script - suggested fix 7 posts, 2 voices

brandobean User
FirefoxWindows

I've noticed that it's super easy to trigger the zoom feature of this script by mistake. Specifically if you use CTRL+arrow while typing in a text box on facebook it suddenly grabs a picture and zooms it right over where you were typing. This is, of course, hyper annoying.

CTRL+ arrow keys are how you move the cursor 1 word at a time and I use this constantly while entering comments, updating my status etc. I do it reflexively and am surprised everytime when suddenly an image zooms over my task and I have to click it to make it go away.

SUGGESTED FIX: Don't allow CTRL+Arrow keys to start the script zooming images. Instead allow the use to trigger the script manually by clicking the zoom icon and THEN allow arrow keys to go from pic to pic. Thanks!

Brandon

 
eoftedal Script's Author
FirefoxWindows

Is this a problem even with the newest version? It's not supposed to trigger on the arrow keys unless an image has already been zoomed, but I no this was a problem until one of the latest releases.

 
brandobean User
FirefoxWindows

Just installed the latest version (which I could have sworn I had) but it seems to fix the issue! Nice work!

 
brandobean User
FirefoxWindows

Wait, I figured out the repro steps with the most recent version! It's still broken. All you have to do is trigger the script on the page, ever, even once, and from that point on, the arrow keys will always start zooming images. Ideally, clicking CLOSE on any zoomed image should reset the script to it's default non-triggered state.

REPRO:
1. Go to a FB page with a text field you can type in (this is most pages....example, under a status update, or in your news feed, under any item where you can type a comment)
2. Mouse over a picture to see the magnifying glass with + in it and click to expand it (i.e. use the script)
3. Click CLOSE on the photo to end the script.
4. Start typing in any text field, and press an arrow key

RESULT: The script is still running... and pics start zooming in/out over what you are typing.
EXPECTED: Closing a zoomed photo stops running the script so that arrow keys don't re-trigger the script.

So your fix is close... but not quite there! :) Good luck. I love your work.

 
eoftedal Script's Author
FirefoxWindows

Thanks for the thorough bug description. Please try the version I uploaded now.

 
brandobean User
FirefoxWindows

Initial tests looking good. yay!

 
eoftedal Script's Author
FirefoxWindows

Cool. Thanks.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel