A few things
in
10 posts,
5 voices
aeosynth
User
|
I don't understand why you scroll the window down when we open the options dialog. Toggling, saving the options show no immediate effect. There's no 'Discard Changes' button. Using labels instead of spans for checkbox containers would probably be better. The script automatically scrolls the window down, hiding the options button. Maybe grouping it with the 'Download this video as' section would be a better idea? Just my thoughts. |
JoeSimmons
Scriptwright
|
That's why it'd be better if he used sizzle and I's GM_config. It has a discard changes feature (called reset to default but same thing). Ours gets centered directly in the middle of the page, even when you resize it centers itself. |
sizzlemctwizzle
Scriptwright
|
Yeah we even support tooltips now. @require is rather annoying though (since you have to uninstall and reinstall for changes to take into effect). |
Avindra V.G.
Script's Author
|
I scroll it down because rendering HTML elements over flash ones breaks actionscript to javascript communication. No discard changes because I'm trying to keep it minimal. Labels, yeah, I'll add those later. (For clicking on label as well for the checkbox, right?) Grouping w/ downloads section? Maybe. I think it's better where it is though. If it's that much of a problem, I could add "discard changes", but imo, it's not needed. |
|
Avindra V.G.
Script's Author
|
I'll consider using GM_config. Did you guys add some sweet "-moz-border-radius"-ness? :D |
|
sizzlemctwizzle
Scriptwright
|
Avindra Gool... wrote:no lol but you can style the window to your liking yourself. Here's some documentation (though there's not enough about actually using GM_config and too much about using the guide author's script): http://userscripts.org/guides/11 |
|
aeosynth
User
|
My beef with the current position of 'show ultimate options' is that it's basically auto-hidden w/ the default 'jump to player' option, and shoving it next to youtube's own links makes it even less easy to notice. Grouping it with downloads makes it visible by default, and distinct from its surroundings (stars on the left, text on the right, big blue link in the middle). |
|
JoeSimmons
Scriptwright
|
Avindra Gool... wrote:Nah, wanted to keep it simple. You can pass an argument to init() to add css to the head of the iframe, but you will have to just add that -moz-border-radius to the part where we actually create the iframe instead of inside it aka this line here:
window.document.body.appendChild((this.frame=this.create('iframe',{id:this.idR(6),src:'about:blank',style:'position:fixed; top:0; left:0; opacity:0; display:none; z-index:999; width:75%; height:75%; max-height:95%; max-width:95%; border:1px solid #000000; overflow:auto;'})));
I made it so you can pass arguments in any order you like, so you probably could just keep your current object "opts" and pass that with a name&css to init().
|
ceejinc
Scriptwright
|
not sure if you guys are talking about stuff thats going on with the script and it not working right or whatever but good job dude..working better in all but i still am having trouble getting some videos to work right..still shows 0:00/0:00 when i open multiple parts of a show or something or just sometimes click and watch a random funny video...usually it works great and auto buffers in all but is still kinda doing the no timer thing on videos for some odd reason and it doesnt even happen on all of them either...and ive tried clearing my cache and all that stuff and it still happens.. i mean it shows it usually when i hit play in all..but while waiting on the buffer it shows the no time thing ...for example try going here
|
|
JoeSimmons
Scriptwright
|
ceejinc wrote:Could you link us to a few of those videos so we can test and fix? Avg should use my script, it's never done that yet. |
