Userscripts.org Preview Posts

By JoeSimmons — Last update Dec 21, 2012 — Installed 571 times.

SUGGESTIONS:(PP):Userscripts.org Preview Posts

in
Subscribe to SUGGESTIONS:(PP):Userscripts.org Preview Posts 49 posts, 3 voices



Apr 29, 2009 9:33am
Marti Scriptwright

  • REMINDER Excessive use of inapplicable tags on uso for this script
  • REMINDER Full page preview may center each line with RTL support
  • RESOLVED Editing a post, clicking Preview, then, using close preview anchor, rehides editor... shouldn't be doing this.
    (Identified as incompatibility when Userscripts Comment Fix is enabled.
    Will shoot a note over there momentarily to see who's doing what)
  • COMPLETE Matching the preview button with the baseline of Save Changes would be a nice addition.
  • COMPLETE Please rename your button to Page preview or the like... I'm getting confused on which button belongs to whom.
  • COMPLETE Alert dialog boxes should indicate at least @name source metadata for notification.
  • COMPLETE Code should not continue execution when logged out. Disable JavaScript to view execution.
  • COMPLETE After deletion of a topic, code still tries to add preview button to 404 page.
  • COMPLETE Login check using xpath expression is too finite for /login
 
Apr 29, 2009 10:25am
JoeSimmons Script's Author

True. Thy will be done ;) I just wanted my script to work so I could post it. My internet is being retarded and randomly stopping the loading of pages and sometimes not loading at all. I will apply more visually appealing code after I sleep which I am going to do now.

EDIT: On topic pages, the Preview button is right next to Save changes and Post reply. On new topic pages, the Preview button is right next to Post topic.
 
Apr 30, 2009 1:49am
Marti Scriptwright

JoeSimmons wrote:
On topic pages, the Preview button is right next to Save changes and Post reply. On new topic pages, the Preview button is right next to Post topic.
Kewlieez! Thanks. New requests too.
 
Apr 30, 2009 3:00am
JoeSimmons Script's Author

Marti wrote:
Editing a post, clicking Preview, then, using close preview anchor, rehides editor... shouldn't be doing this.

It's not doing that to me. Try updating.
Marti wrote:
Please rename your button to Page preview or the like... I'm getting confused on which button belongs to whom.

Sorry but no, it would just take up more space for everyone that doesn't have both preview scripts enabled. Just rename it locally on your end at line 47 and line 95.
 
Apr 30, 2009 3:02am
Marti Scriptwright

JoeSimmons wrote:
It's not doing that to me. Try updating.
I'm running 1.07... if you forgot to bump your version up then you might want to fix that.
 
Apr 30, 2009 3:04am
Marti Scriptwright

JoeSimmons wrote:
Sorry but no, it would just take up more space for everyone that doesn't have both preview scripts enabled. Just rename it locally on your end at line 47 and line 95.
I've already renamed it... however you didn't mind taking up space when it was on the left. There is plenty of space available for editing with it on the right and with the longer text.
 
Apr 30, 2009 3:04am
JoeSimmons Script's Author

Marti wrote:
Code should not continue execution when logged out. Disable JavaScript to view execution.

Ah good catch. I'll fix that now.
Marti wrote:
I've already renamed it... however you didn't mind taking up space when it was on the left. There is plenty of space available for editing with it on the right and with the longer text.

It doesn't need to say Page preview. People should know what it means when it says Preview.

PS: Get on IRC. #uso on freenode.
 
Apr 30, 2009 3:09am
Marti Scriptwright

JoeSimmons wrote:
It doesn't need to say Page preview. People should know what it means when it says Preview.
I don't think you are understanding between Sizzle's script and yours, depending on whose is installed first... they move... When one says "Preview" and the other says "Preview reply"... and when they get reordered by updating, it's quite confusing. You should do this... it's also more accurate at what it does... I've put the corresponding request in on Sizzle's.

JoeSimmons wrote:
It's not doing that to me. Try updating.
You did forget to update the version in last edit and also I updated and it's still doing it.
 
Apr 30, 2009 3:52am
JoeSimmons Script's Author

Marti wrote:
Please rename your button to Page preview or the like... I'm getting confused on which button belongs to whom.

I decided to add a title to it so when you hover over it, it will say "Full Page Preview."
 
Apr 30, 2009 4:05am
Marti Scriptwright

JoeSimmons wrote:
Marti wrote:
... or the like...

I decided to add a title to it so when you hover over it, it will say "Full Page Preview."
That'll work. Thanks.
Still forgot to update your version... I rely on that to determine if you've made changes. I have other projects and I can't always be comparing uso:version to what I last installed especially when lots of recent changes happen.
 
Apr 30, 2009 4:09am
JoeSimmons Script's Author

Marti wrote:
Still forgot to update your version... I rely on that to determine if you've made changes. I have other projects and I can't always be comparing uso:version to what I last installed especially when lots of recent changes happen.

I changed it to 1.0.8
When I change it next, it will be 1.0.9.
 
Apr 30, 2009 4:30am
Marti Scriptwright

JoeSimmons wrote:
When I change it next, it will be 1.0.9.
I appreciate that... also confirmed what's causing the editor to hide... see above.
 
Apr 30, 2009 6:17am
JoeSimmons Script's Author

Marti wrote:
also confirmed what's causing the editor to hide... see above.

Hmm.. strange. We'll see what he has to say.

Marti wrote:
Still forgot to update your version... I rely on that to determine if you've made changes. I have other projects and I can't always be comparing uso:version to what I last installed especially when lots of recent changes happen.

I put an auto-update feature on it and when I change the version and update it, you'll be notified in 1 day (that is if you view a topic on userscripts, that's the only time the updater gets to check if it's the latest version).
 
May 1, 2009 9:10pm
Marti Scriptwright

JoeSimmons wrote:
I put an auto-update feature on it and when I change the version and update it, you'll be notified in 1 day (that is if you view a topic on userscripts, that's the only time the updater gets to check if it's the latest version).
Good to know... new request.

P.S. Nice updates :)
 
May 1, 2009 9:12pm
JoeSimmons Script's Author

Marti wrote:
Alert dialog boxes should indicate at least source @name metadata for notification.

What do you mean?
Marti wrote:
P.S. Nice updates :)

Thanks. I worked 8 straight hours on it.
 
May 1, 2009 9:16pm
Marti Scriptwright

JoeSimmons wrote:
What do you mean?
I linked into the API during your last reply in the request... I get an error, which has already been discussed elsewhere... of "Error. Could not add preview button to page."... would be nice to know who it belongs to without searching your source code.
 
May 1, 2009 9:22pm
JoeSimmons Script's Author

Marti wrote:
JoeSimmonswrote:
What do you mean?
I linked into the API during your last reply in the request... I get an error, which has already been discussed elsewhere... of "Error. Could not add preview button to page."... would be nice to know who it belongs to without searching your source code.
I see what you mean. Working on it. EDIT: Added. Try it. And as for that alert, I made them more specific, Tell me which area it fails on.
 
May 1, 2009 9:52pm
Marti Scriptwright

JoeSimmons wrote:
Tell me which area it fails on.
Next time it occurs, I will do that.
Nice! Thanks for doing that.
Edit post -> Cancel -> Edit post
Might also want to tell the user to optionally reclick edit while the editor is open. I know you both will eventually figure this out, but in the short term it's nice to know.
 
May 1, 2009 10:08pm
JoeSimmons Script's Author

Marti wrote:
Edit post -> Cancel -> Edit post
Might also want to tell the user to optionally reclick edit while the editor is open. I know you both will eventually figure this out, but in the short term it's nice to know.

I don't know why he would need to re-click it. What's wrong with it? Works fine here.
 
May 1, 2009 10:23pm
sizzlemctwizzle Scriptwright

JoeSimmons wrote:
Marti wrote:
Edit post -> Cancel -> Edit post
Might also want to tell the user to optionally reclick edit while the editor is open. I know you both will eventually figure this out, but in the short term it's nice to know.

I don't know why he would need to re-click it. What's wrong with it? Works fine here.

He's referring to something you have to do when my Comments Fixer script is enabled. I need to dive into that code and resolve this issue.
 
May 1, 2009 10:30pm
Marti Scriptwright

I'm SUPER GLAD that you both put tooltips on which Preview button is which... they move around on me even when I'm not updating either one of your scripts. LOL Thanks.
 
May 1, 2009 11:02pm
JoeSimmons Script's Author

Marti wrote:
I'm SUPER GLAD that you both put tooltips on which Preview button is which... they move around on me even when I'm not updating either one of your scripts. LOL Thanks.

No problem.

How do you like my interface? Anything wrong with it?
And did you know you could close the preview by double clicking anywhere on the dark part?
 
May 1, 2009 11:16pm
Marti Scriptwright

JoeSimmons wrote:
How do you like my interface? Anything wrong with it?
And did you know you could close the preview by double clicking anywhere on the dark part?
Full page should probably include vertical height, but that's up to your discretion and I'm not really that picky on it. I didn't add that to new requests, because it still looks great.

As for the double clicking... Found that by accident... nice job... although do like the possibility of not closing it via a dbl click in the text area too... but I'll use sizzlemctwizzle's for that.

I'm still probing things out...

Nit picking here "Full Page Preview" would be more symmetrical with uso if it said "Full page preview" ;)
New request btw.
 
May 1, 2009 11:42pm
sizzlemctwizzle Scriptwright

Your full page preview now looks like what I was originally going to do before I came up with the inline idea. Nice job. Looks really good.
 
May 2, 2009 2:02am
JoeSimmons Script's Author

Marti wrote:
Excessive use of inapplicable tags on uso for this script

Why do you think they don't apply?
sizzlemctwizzle wrote:
Your full page preview now looks like what I was originally going to do before I came up with the inline idea. Nice job. Looks really good.

Thanks. Anything to add?