FFixer

By Vaughan Chandler Last update Mar 9, 2011 — Installed 14,796,190 times.

Wrong sign

in
Subscribe to Wrong sign 10 posts, 5 voices



Bober User

I`m born 9th of october wich makes me libra, but here it makes me scorpio???

 
Örpli Hinter... User

This seems to be a new bug. About 2 weeks ago, i was lion, which was correct and soem days ago i noticed that it says virgin.
i think it hasn't to do with a change to the script (no updates in the last 2 weeks) but from facebook.
Maybe they changed the array or whatever from "month[0]=january" to "month[1]=january".

I'll try to fix it. brb =)

 
Örpli Hinter... User

Yeah, i think i was right.

This is the original code. (Line 635+/-5)
Date.prototype.getSign=function(){var signs=new Array("Capricorn","Aquarius","Pisces","Aries","Taurus","Gemini","Cancer","Leo","Virgo","Libra","Scorpio","Sagittarius"); var endDates=new Array(19,18,20,19,20,21,22,22,22,22,21,21); return signs[this.getDate()>endDates[this.getMonth()]?(this.getMonth()+1)%12:this.getMonth()];}


Insert this instead and it should work:
Date.prototype.getSign=function(){var signs=new Array("Capricorn","Aquarius","Pisces","Aries","Taurus","Gemini","Cancer","Leo","Virgo","Libra","Scorpio","Sagittarius"); var endDates=new Array(19,18,20,19,20,21,22,22,22,22,21,21); return signs[this.getDate()>endDates[this.getMonth()]?(this.getMonth())%12:this.getMonth()];}

 
Vaughan Chan... Script's Author

Weird... its working for me. What language do you use Facebook in?

 
Örpli Hinter... User

< german

 
Connum Scriptwright
FirefoxWindows

that does work for me, too (I just sent you a mail containing the german translation and reporting that bug...) and I'm using Facebook in German as well!

 
Vaughan Chan... Script's Author
FirefoxX11

Hmmm... are your birthdays around the date where the sign change? (the 18th, 19th, 20th, 21st or 22nd of the month)

By the way, I got your translation Connum, thanks a lot.

 
Örpli Hinter... User
FirefoxX11

Yeah, i heard that in US the sign-change somehow differs.
Maybe making the change-day- Array twodimensional the first one being the language, the 2nd one the days.

xyz[de][1,2,3,3,4,5,5,6,6,7,8,9];
xyz[en][1,45,7567,69,676,3,234,9];
Or something like that. No idea, never worked with it.

 
agataloca User
FirefoxWindows

I recently started using the FB Fixer and also noticed this; my own sign shows up fine (July 21, Cancer) but f ex 2 friends who are Aquarius' show as Pisces. Not sure if that's the only wrong one but feeling this needs a more in depth review. Thanks in advance! I am in Sweden but use FB in Am English btw.

 
Vaughan Chan... Script's Author
MozillaX11

Well this is apparently a lot more complicated than I originally thought. It seems that there are at least 2 main ways to define the 12 signs (tropical and sidereal) and for each way the actual dates vary every year. Right now the script uses signs based on tropical astrology, and I haven't double-checked, but it is probably using the dates from either 2008 or 2009 (whatever Wikipedia had at the time).

It may take me a while to come up with a decent solution for this.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel