Twitch_City
User
|
This is a GREAT script! I do have a problem though:
About half of the photos (mostly profile pics) work with the "hover over enlarge" feature - but I find the other half of photos flicker repeatedly. This is especially prominent if hovering over thumbnails in albums.
I'm using the latest version of the script, on Firefox 3.0.7 on OS X. Does anyone else have similar problems?
|
|
|
Vaughan Chan...
Script's Author
|
Hi, this is most likely happening because your mouse cursor is over both the thumbnail and the popup image. Since the photos are bigger than the profile pictures it is more likely to happen with photos.
The solution I implemented was to position the popup automatically instead of just keeping it on the left or the right. This works fine for me, so you should make sure the script is set to do that. However, for people with lower resolutions it might still be a problem. You could use the configuration popup to disable closing popup pictures automatically, or you could disable showing bigger versions of photos completely.
I'll see if I can come up with a better solution.
|
|
|
Twitch_City
User
|
You hit the nail on the head. I just tested it and it is caused by the cursor being in the space that the pop-up occupies. I've changed the position from left to automatic and turned off automatic close and it seems to be working fine.
Cheers!
|
|
|
Vaughan Chan...
Script's Author
|
Glad to hear that its working for you. By the way, if you're resolution is high enough you should be able to have the automatic close turned on and still not get the flicker - the automatic positioning should be good enough. Turning off automatic closing should only be necessary on lower resolutions.
|
|
|
Samuel Tai
User
|
I like this enlarge function very much. I have some suggestion for the function.
When mouse cursor is over both the thumbnail and the pop-up image, the enlarge picture will flash(repeatably appear and disappear) if my mouse move slightly. I suggest,
1. There could have an option to delay the automatic close. Or,
2. Disable the automatic close when mouse cursor is over popup image.
Hope this help improving the script.
|
|
|
David C
User
|
Samuel, i suppose he would of already fix the problem with option #2 if it wasn't too difficult.
I came in this discussion because i was having the same flickering with the bigger pop up pic. I'm on a laptop with 1024 x 768 max resolution, also, FireFox is narrower than usual because of the windows sidebar. I too get the flickering problem when the cursor is hovering over both the thumbnail and the pop up. It's a pain at times, but can't complain. I'll be trying your suggestions also.
Anywayz, Vaughan, thanks for the hard work and updates on this amazing script, I really can't use FB without it.
Respect.
~Des
|
|
|
Samuel Tai
User
|
I have a solution. I think my code could still be improved for general implementation. Hope this help somebody really want the function of option 2.
@@ -1204,0 +1205,2 @@
+// Fix Image problem
+var overPicPopup = false;
@@ -1213,0 +1216,5 @@
+ // Fix Image problem
+ div.addEventListener('mouseover', function(e) {
+ overPicPopup = true ;
+ setTimeout( function(){ overPicPopup = false ;}, 100 );
+ }, false);
@@ -1889 +1896,6 @@
- if (!e.shiftKey && !e.ctrlKey && !e.altKey) { document.getElementById('FBPPdiv').style.display = 'none'; }
+ if (!e.shiftKey && !e.ctrlKey && !e.altKey) {
+ // Fix Image problem
+ if(!overPicPopup){
+ document.getElementById('FBPPdiv').style.display = 'none';
+ }
+ }
|
|
|
Vaughan Chan...
Script's Author
|
Hi Samuel, thanks for the contribution. I'll test it out and either include it in the next release, or base something on it.
|
|
|
Samuel Tai
User
|
After the above enhancement, the popup image dose not disappear when mouseover it. I have to move my mouse away very often after the third thumbnail in order to read the fourth on the same row. I found that is quite difficult to read the album smoothly. Thus, I added a code to close the popup by the ESC keypress. Now, I do not need to move my mouse away to close the popup image again. See if anybody like this extra function.
@@ -1204,0 +1205,2 @@
+// Fix Image problem
+var overPicPopup = false;
@@ -1213,0 +1216,5 @@
+ // Fix Image problem
+ div.addEventListener('mouseover', function(e) {
+ overPicPopup = true ;
+ setTimeout( function(){ overPicPopup = false ;}, 100 );
+ }, false);
@@ -1889 +1896,6 @@
- if (!e.shiftKey && !e.ctrlKey && !e.altKey) { document.getElementById('FBPPdiv').style.display = 'none'; }
+ if (!e.shiftKey && !e.ctrlKey && !e.altKey) {
+ // Fix Image problem
+ if(!overPicPopup){
+ document.getElementById('FBPPdiv').style.display = 'none';
+ }
+ }
@@ -1891,0 +1904,8 @@
+
+ window.addEventListener('keypress', function(e) {
+ // Fix Image problem
+ if (e.keyCode == 27) {
+ document.getElementById('FBPPdiv').style.display = 'none';
+ }
+ }, false);
+
|
|
|
Vaughan Chan...
Script's Author
|
Hi Samuel, I have released a test version which includes some of your code. Currently I have it disabled by default, so you'll need to enable it in Facebook Fixers settings. I didn't add your code for closing the popup when Escape is pressed since that functionality is already in the script (once you have keyboard shortcuts enabled).
|
|
|
Burgers nChips
Scriptwright
|
Vaughan
I've just installed your Test Version and tried out this (it was bothering me when on my lower res screen) and now the images wont stay open unless you are over both at the same time. The popups don't work if they don't satisfy this state. It needs to be more like "and/or" rather than "and" or "or".
Thanks, BnC
|
|
|
Burgers nChips
Scriptwright
|
Could have a simple user configurable time delayed auto close...
|
|
|
Samuel Tai
User
|
I have a much more stable version, the patch is based on 2.0.0rc
@@ -1204,0 +1205,2 @@
+// Fix Image problem
+var overPicPopup = false;
@@ -1213,0 +1216,5 @@
+ // Fix Image problem
+ div.addEventListener('mouseover', function(e) {
+ overPicPopup = true ;
+ setTimeout( function(){ overPicPopup = false ;}, 100 );
+ }, false);
@@ -1825,0 +1833,2 @@
+// Fix Image problem
+var skip_mouseover = false;
@@ -1833,0 +1843,6 @@
+ // Fix Image problem
+ if (skip_mouseover){
+ skip_mouseover = false;
+ return;
+ }
+
@@ -1879,0 +1895,5 @@
+ window.addEventListener('mousemove', function(e) {
+ if (!e.shiftKey && !e.ctrlKey && !e.altKey) {
+ popupPicTimeout = setTimeout(function(){showPopupPic(e);}, prefs['DelayPopupPicsTimeout']);
+ }
+ }, false);
@@ -1883,0 +1904,3 @@
+ window.addEventListener('mousemove', function(e) {
+ if (!e.shiftKey && !e.ctrlKey && !e.altKey) { showPopupPic(e); }
+ }, false);
@@ -1889 +1912,6 @@
- if (!e.shiftKey && !e.ctrlKey && !e.altKey) { document.getElementById('FBPPdiv').style.display = 'none'; }
+ if (!e.shiftKey && !e.ctrlKey && !e.altKey) {
+ // Fix Image problem
+ if(!overPicPopup){
+ document.getElementById('FBPPdiv').style.display = 'none';
+ }
+ }
@@ -1891,0 +1920,9 @@
+
+ // Fix Image problem
+ window.addEventListener('keypress', function(e) {
+ if (e.keyCode == 27) {
+ skip_mouseover = true;
+ document.getElementById('FBPPdiv').style.display = 'none';
+ }
+ }, false);
+
|