Archived Comments (locked)
in
10 posts,
3 voices
Jesse Andrews
Admin
|
The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008) |
Mattias Blom
Script's Author
|
Updated, now "p" goes to Previous photo and "n" to Next photo. I wonder how I could have missed that one? I guess I have been looking through albums backwards for some time now. |
engtech
Scriptwright
|
Yay! :) |
|
Mattias Blom
Script's Author
|
I caved..., Now t toggles the tagging ui on and off. I didn't want to start messing with 'enter' since you use enter if you type in a person not on facebook. And yes, the code got ugly and will break on minor changes in the facebook setup. The eventlistener thing didn't work since I didn't want to hook into mouse clicks but rather "click" programmatically. So I got the onclick-code from getAttribute and eval'ed it with unsafewindow. But hey, it works right now! |
|
engtech
Scriptwright
|
I was thinking that hitting T would be the same as clicking the Tag this photo button. Couldn't you set up an event for 'T' click that finds the 'tag this' link and sends it an onclick event? |
|
Mattias Blom
Script's Author
|
...and mouse action is required for tagging so maybe adding t for tagging wouldn't help that much, other than the consistency. |
|
Mattias Blom
Script's Author
|
I don't think I can fix that as easily. The tag ui is displayed using javascript (show_tagging_ui) and the anchor is id-less and it's place in the dom varies depending on whether it's your photo or not. That means headaches and clutter and I'm not going down that road. =) Feel free though... |
|
engtech
Scriptwright
|
't' to start tagging and 'enter' to finish tagging would be good as well. :) |
|
Mattias Blom
Script's Author
|
Nice idea. The "Comment Jump" is added. I was thinking about adding shortcuts for "next" in search results and other places. But those elements don't have id:s so getting that to work would clutter my minimalistic approach! =) |
|
engtech
Scriptwright
|
nice one... I was thinking about writing something like this. It would be nice if 'c' jumped to the comment field. |
