Userscripts.org

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)

Hey murdos - the part-of-set links don't appear to be working for me; they are generating links like http://musicbrainz.org/artist/caecdea3-21d1-46b... ID is a release's ID) on http://musicbrainz.org/artist/321531fc-db73-4ff... . How are they intended to work? If the release has a previous and a next disc, it'll show two icons to show both links are there? And each icon goes to either the previous or the next release?

Hi murdos,

Now seeing you snapshot I see that I have the same screen already. I thought you didn't have the white cellpadding between empty cells but you also do.

Look at mine, it's the same, isn't it ?

I just used the function (getSizeOfHashTable) of my last comment to make it work. It was because the length attribute is not always existing on hashtables in javascript (I just learnt it at that same time) …

I'm e-mailing you my current version of your script in case I forgot to say something here. (^_^)

Thank you murdos ! ♥
Tristan

Thank you Murdos, no more conflict between them.
Maybe you may apply this function names anti-conflict to your other scripts ?
Or is it too strange ?
I'll try to get a better rendering when I have some time … Could you show me a screen capture of yours please Murdos ?

I have two issues, h2.colspan and a table padding or something.
For the colspan it's because hashtable doesn't have length attribute and alert(relationsIconsURLs.length) gives undefined.
So I used this function (modified because I had errors with the prototype thing. It worked but generated errors elsewhere ?):

function getSizeOfHashTable(ht) {
	var l = ht.length ? --ht.length : 0;
	for (var k in ht) {
		l++;
	}
	return l;
}

1st problem solved (but maybe just works on Opera?)

For the second one I need a snapshot or something since I have cell padding and it seems you don't. Please :)

PS. you forgot to turn off debug :)

It works in Opera now: I renamed two function names to xmlhttpChange7947 and NSResolver7947, I think it's normal that it bugged because they have the same name in your other script (MusicBrainz Subscriptions script:8266).
But what's strange is that I also had to rename xmlhttp to xmlhttp7947! This is not logical (because it's a var declared variable) but now it works … ?!
I wondered if I had to rename xmldoc and other vars but well it already works without doing so …

I changed the debug function to:

function myGM_log(message) {
	if(DEBUG) {
		var logged = false;
		try {
			GM_log(message);
			logged = true;
		} catch(e) {}
		try {
			opera.postError(message);
			logged = true;
		} catch(e) {}
		if (!logged) {
			alert(message);
		}
	}
}

That's it for the functional part. Before I look further into the presentation bits, could you confirm that, in compact mode, you don't have display problems such as broken colspan on <h2> Albums, Singles, Live, etc. or empty cells after Amazon link.

Here's what I have with "AJICO" for instance :
← without script
← with script

Hi Murdos !
Is this script still supposed to work ?
It doesn't work in my Opera, but maybe it is because of a new MB website release.

Or maybe I don't look at the right place on the page as I'm not sure where it is supposed to insert those links. :)

Ah, the problem was Discog's favicon moved.

Discogs links do not seem to be showing up anymore... am I the only one having this trouble?

Oops - make that murdos :P

Hey cooperaa - REALLY useful script. I notice, though, on larger discographies, it seems to only list for the first few dozen releases. (See Nirvana for an example.)

Idea: add greyed-out icons for missing release URLs and implement a mod of the MusicBrainz.org Search script to search the appropriate source to find the releases URL!

Excellent! I've been wanting this for a long time! Thanks a lot murdos! :)