Archived Comments (locked)

in
Subscribe to Archived Comments 12 posts, 4 voices



Jesse Andrews Admin

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)

 
jerone Scriptwright

This site uses the famous FamFamFam icons, maybe you can find one to use as a permalink.

 
jerone Scriptwright

Why did you removed the jump, I liked that. Maybe make it optional then.

 
Avindra V.G. Script's Author

edit: the page no longer jumps :) (i used a return false after the prompt)

 
Avindra V.G. Script's Author

thanks again, i added that suggestion.

i'll work on something smoother than the "prompt" function this weekend if i have time.

 
jerone Scriptwright

I love it. And I've got 2 solutions for your last problem;

  1. You can surround the whole prompt with this:
    window.setTimeout(function(){prompt(...)},0)
    The prompt will now be given after the jump.
  2. Or you can place a input box in the same place as the permalink text now is, with the link as value.

I prefer the second, because if you just want to use the link (not getting the link), you're not prompted and forced to click the 'OK' or 'Cancel' button.

 
Avindra V.G. Script's Author

agreed. i took it out at first because after the prompt came up, the akward jumpiness after you closed the prompt got to my head XD

 
znerp Scriptwright

Nice changes, although I'd prefer if the link still pointed to the post rather than to #nowhere as I'm a pretty big fan of "Copy Link Location" for permalinks.

 
Avindra V.G. Script's Author

@znerp :

About the forums... I didn't notice the timestamp as a permalink. I'll possibly delete this feature in a more future version (yes I updated it, but was too lazy to take it out XD)

And about xxxxx-row vs comment-xxxxx... I initially wanted to and went with comment-xxxxx, but xxxxx-row shows a few more pixels than the other one, so for purely aesthetic purposes, I did it this way.

About jerone's features: I implemented them (thanks jerone!). Tell me if you like it :)

Also, I'm considering keeping this on the forums, because the script now give you a copy+pasteable link.

P.S. I saw what you did there ;)

 
znerp Scriptwright

I've just noticed this runs in the forums. Is that entirely necessary since permalinks are already supplied there (the timestamp on posts acts as a permalink)?

 
znerp Scriptwright

Nice script, I've been meaning to write one that does this myself for a while but haven't really had the time. One point I'd like to make though is that I would suggest making the permalinks for comments the same form as in comment feeds. That is, of the form ...scripts/show/34592#comment-60312 rather than ...scripts/show/34592#60312-row.

Also, I agree with the style change jerone made below (see what I did there? ;) ).

 
jerone Scriptwright

I like to see the 'premalink' on the same place as the 'edit' & 'delete' options, beside the points.
Another cool feature would be when clicking the premalink it also opens up a prompt box or input box which gives you the related url.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel