Archived Comments (locked)
in
46 posts,
19 voices
Jesse Andrews
Admin
|
The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008) |
znerp
Script's Author
|
@Mitchell McKenna: I've had a look at your video, and to be honest I'm surprised by this behaviour and somewhat confused. The actual mechanism for this script is incredibly simple, and it's one I've used in a number of similar image enlarging scripts. I honestly can't work out what could be causing this problem, and I've tested the script on many different machines but I cannot seem to replicate the problem at all. |
Mitchell McK...
User
|
Hi, i believe your script is causing a memory leak in firefox. I have attached a screencast to show it happening...
I am using Firefox 3.0, Greasemonkey 0.8.20080609.0 on Windows Vista 32bit.
|
Gary Jacobson
Scriptwright
|
Hi. Just switched to the new look Facebook. I notice they use some weird hack with iframes which causes an error in your script, since the iframes do not contain a content div. Easily fixed by inserting "if (document.getElementById("content"))" above the line "document.getElementById("content").addEventListener('DOMNodeInserted', inYoFace, true);" |
Jenn9219
User
|
Yes helpful. but the pictures are still very small. anyway of getting the full image? |
SimonT
User
|
Thanks, very helpful :) |
Praveen Mark...
User
|
awesome. thanks a bunch |
|
znerp
Script's Author
|
@Praveen Markandu: Thanks for letting me know; this was a simple bug due to some change made by facebook. I've fixed it now. |
|
Praveen Mark...
User
|
is it just me or does the search bar now stay on top of the enlarged pictures? it makes a while box |
1408
User
|
Great Work znerp!! xD |
sergiothatguy
User
|
Yes it does. Thanks! That bobielawlintine username was on BugMeNot =) |
|
znerp
Script's Author
|
@bobielawlintine: Thanks for your input regarding the captions. In responce to your question, the larger images have the same url as thumbnail images save for one character. The thumbnail images have filenames of the form |
bobielawlintine
Scriptwright
|
I don't see why the captions are such a big deal. I see the captions on the tooltip when I hover over pictures anyway, so adding that feature would be superfluous. Anyway, is there a way to save the enlarged picture or to obtain the URL for that enlarged image? I took a look at your script, but couldn't determine what finds out the exact URL of the original image as opposed to the thumbnail URL. |
|
znerp
Script's Author
|
@aok: I've just installed that script, and I can see how it's done there which I think works better with that script as the caption's displayed at the bottom of the page for all images, but with my images anchored to the top left it would vary depending on how tall the images are. I'm happy with my script working as it does with the title on images, can anyone else leave any opinions on this in the comments here please? |
aok
User
|
znerp: In regards to the picture captions, you can take a look at the "Facebook thumbnail enlarger" script to see how it does it. It would be great if you could also implement the captions. Anyhow, thanks for the script! |
|
znerp
Script's Author
|
@Praveen Markandu: I can't really picture how that would work too well, and I don't know if you've noticed but if you mouseover the image for a few seconds the title should appear by the cursor for both thumbnails and enlarged images. |
|
Praveen Mark...
User
|
it would be cool if this script grabbed and placed the caption at the bottom of the pic for pictures that have a caption |
|
znerp
Script's Author
|
arriman409: As it happens, as of my most recent update means it will now work with that script. There is one small facet though; when all images in a gallery have (eventually) loaded, simply click somewhere on the page that isn't a link and it should then work. I implemented this as a hack to get around the way that friend lists are now loaded, and it occurred to me that it works for that script too. |
arriman409
User
|
this script doesn't work when viewing pictures albums seen through your "Facebook View Photo in Album" script. is there anyway to fix that? |
B0b
User
|
Works great for me on page 1 of x friends. Selecting page 2 (or 3 or 4 etc) or next somehow disables the script. Refreshing the web page allows script execution and mouseover action works well, but back at page 1. Seems like *profile.php?id= gets lost. Any body else see this behavior? |
|
znerp
Script's Author
|
@Raffles: Good thinking, I've been meaning to play with xpaths more, so I've fixed that to load only the predetermined urls as you suggest. @Santiago Riveros: I don't know the noscript addon, but after a quick google search and reading the FAQ it seems that this script should probably work if you simply whitelist the facebook domain. Hope that this helps. |
sanriver12
User
|
noscript addon is messing with inYOf4ceBook, any advice on how to set it up so they can work together? probably is that xss or jar stuff implemented latetly in noscript that i honestly dont understand... thanks |
Raffles
Scriptwright
|
er, I meant "Then the loading image won't appear" ... |
|
Raffles
Scriptwright
|
I have a suggestion. Disable the onmouseover event from occurring on images where they are linked to pages that start with "apps.facebook", that are identical to the current URL + # (used by some apps to do some Javascript) or any others you may have noticed where it is impossible to obtain the original image or where there isn't one. It might be easier to restrict it to a pattern of known URLs where it works, actually, e.g. /album.php?aid=, profile.php?id= (profile image thumbs) and photo.php?pid= Then the loading won't appear to be loading something it can't access forever. |
|
Raffles
Scriptwright
|
Great stuff, and yes, the loading image is a nice one. |
