Archived Comments (locked)

in
Subscribe to Archived Comments 7 posts, 4 voices



Jesse Andrews Admin

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)

 
Glenn Carr Script's Author

RE: I feel like a dolt. It turns out I didn't have the latest version

That's cool. I have a dolt-like feeling quite often myself.

RE: could you comment the regular expressions?

Yeah, I should for my own sake as well as for others. I'm usually trying to do these late at night, and don't want to take the time I should to comment them.

RE: what's with the "beta" support? Is Yahoo doing a beta test of a new interface?

Well, apparently they sometimes put new features out there while testing. They had put the hitter starter indicators there (which is live now). But, I don't think there's that much out there.

 
Tim Wilson Scriptwright

I feel like a dolt. It turns out I didn't have the latest version. The latest version seems to fix the issues. Ignore my previous posts.

 
Tim Wilson Scriptwright

Great, I forgot we could put HTML in the post, so it interpreted what I posted. If you want the code, I'll see if I can put it some place for you. Sorry about the mess.

 
Tim Wilson Scriptwright

There's a problem when proposing a trade or adding a player. The generated link is one for the team page, not for the player(s) listed. I added the following code inside the else of the 'playerswatch' match:
if( location.href.match(/addplayer.*/) || location.href.match(/proposetrade.*/) ) {
var tmpHref = location.href;
if( tmpHref.match(/&stat2/i) ) {
newli.innerHTML='Last 2 Weeks';
} else {
newli.innerHTML='Last 2 Weeks';
}
} else {

With the rest of the matches inside the else. I'm not sure if this fixes it completely, since it looks like you're checking for things I'm not aware of (A versus L in the next match, for example).

One other thing, could you comment the regular expressions? I figured out what "playerswatch" is, but the others I'm stumped on. I know RE some, but you're using expressions I don't know. It might help others find things you didn't. Something like "Check to see if we are watching a player", for example.

Oh, and what's with the "beta" support? Is Yahoo doing a beta test of a new interface? Just curious.

 
Glenn Carr Script's Author

Yeah, Yahoo knows about this, and I'm hoping that it might prompt them to make them the ranks available.

 
Dan Russell Scriptwright

Nice script, it's too bad the Ranks don't fill in though. Not your fault.

Cross
Presentational HTML allowed.
Use <code> for inline code and <pre> for code blocks. Use &lt; and &gt; for literal < and >.
We help break paragraphs and link your links.
or cancel