Archived Comments (locked)
|
|
The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008) |
|
|
it seems your script doesn't work on wordpress blogs - well - at least on this one Getting an RSS Feed Out of a Google Custom Search Engine (CSE) « OUseful.Info, the blog…
|
|
|
Google uses a special url patteren name_of_media_outlet.google.com/article/blahblah for articles it hosts from media outlets. ap / upi / afp
example Wanted: a leader for battered Republicans
Most of the articles have an image on the left side - and left-clicking it causes bugs. |
|
|
version "a few minutes ago" Could you give the script a version number?
Your script creates problems at safaribooksonline.com example
At the site left-click on the buttons and you'll see.
=== Edit In fact - your script doesn't work on any link with a clickable image. |
|
|
Both those pages work now.
|
|
|
With version I that I installed a few minutes ago - version, um, whatever-number-it-is and with these settings
var open_in_new_tab = true; var use_middle_click = true; middle click works predictably: if middle-click then new tab : Dogs Archives
The Horizon Line: Richmond Dog Parade
#53 Dogs « Stuff White People Like
=== I'll be testing it all over the place with middle click and I'll give you a bug update tomorrow. |
|
|
Okay. <div id="do_strikethrough"><img height="24" width="25" onclick="simpletag('s')"
title="Strikethrough" alt="Strikethrough"
src="style_images/1/folder_rte_images/strike.gif" class="rteimage"/></div>
image link
==== Edit Also - I just realized that I was using a slightly older version of your script - on my last comments |
|
|
Can you use firebug and give me the exact src of that image then? |
|
|
more bugs from results at the google image search for
============= The Horizon Line: Richmond Dog Parade
disabled
enabled
============= : Dogs Archives
disabled
enabled
============= #53 Dogs « Stuff White People Like
disabled
enabled
|
|
|
>> please tell me the forum you're using
KG Forums (Powered by Invision Power Board)
but "(Powered by Invision Power Board)" is in the title inurl:forum intitle:"Powered by Invision Power Board"
======================================================== I think that the left button simply can't work globally and you'll have to fix bug after bug after bug after bug. It's impossible to guess how a site uses the left button. Also - it's impossible for you to guess how a person has set up their Firefox to control tabs. I use Tab Mix Plus and other things to control tabs. You might not have have the nytimes.com bug - and somebody else? Who knows. I bet the bugs will range from minor bugs, to bugs that cause Firefox to freeze up and maybe they'll even been bugs that cause Firefox to crash. ======================================================== example dog - Google Image Search
I randomly clicked on the dog results and within about three minutes I found a bug at nytimes.com Japan, Home of the Cute and Inbred Dog
If you script is disabled...
If you script is enabled...
======================================================== A few days ago I said the script could use its "own" click style: Ctrl-Left-Click and Ctrl-Middle-Click. Ctrl-Left-Click = Context Menu - View Image - Left Click
I don't know if it's doable - but having your script give itself its down click style would - I think - avoid endless amounts of bugs. |
|
|
That's because it changes the onClick. I'll fix that with addEventListener. Edit: Ok I made them open in a new tab (if the option is enabled [true]) and work on forums like you wanted.
Edit again: I added the middle click availability and made it default. There is an option to change to left click to view also. |
|
|
I found a bug. In a forum your script stops formatting commands example: from working. But... I don't want to... Excluded Pages */forum/* ...since I'd like to use your script to open images that are in forum. It would be ideal to leave...
So, how about if your script used two main ideas?
You could make your script a short cut for something that always works. Well, almost always works.
You could avoid left-click and right-click and give your script its "own" click style. Your script could use Ctrl-Left-Click and Ctrl-Middle-Click. Ctrl-Left-Click = Context Menu - View Image - Left Click
Left and right click are "overloaded" - they do too many things
You don't want your script to
|
|
|
Could "middle click opens in a new tab" be added? I'll see to it. |
|
|
Hmm... Interesting - I'll be trying this out... --- edit Could "middle click opens in a new tab" be added? |



