Jesse Andrews
Admin
|
The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)
|
|
|
dkhal
Script's Author
|
yes i noticed and used them with my next update just didnt upload them
i'm using quick functions now its better for me
|
|
|
JoeSimmons
Scriptwright
|
I have nice XPath, ID, and Find functions in my YouTube Customization script if you want to use them with credit. I highly recommend xp()... it's easy and effective (but read the syntax carefully)
|
|
|
dkhal
Script's Author
|
nice work there
|
|
|
JoeSimmons
Scriptwright
|
Check my new script. http://userscripts.org/scripts/show/33254
|
|
|
dkhal
Script's Author
|
ok as you wish
|
|
|
JoeSimmons
Scriptwright
|
(Read my comment on the other script)
Probably should add "& Font Changer" in the name of the script.
I don't really like the way you used innerHTML so much in the font changer, but I don't have much time to fix it, so just keep it that way for now. I'll come up with a better way sometime.
|
|
|
dkhal
Script's Author
|
thanks thats exactly what i wanted
finished it check it and if you like it make the changes you want so we can put a single script online and make it copyrighted by us
|
|
|
JoeSimmons
Scriptwright
|
innerHTML is still a bad idea but if you tried to accomplish document.getElementById('smth').innerHTML="whatever"; with document.evaluate, you would do this...
document.evaluate("//*[@id='smth']", document, null, 9, null).firstNodeValue.innerHTML = "whatever";
I used the number 9 and firstNodeValue because there will be only 1 id with 'smth', but usually for several node results, I use the number 6 without the .firstNodeValue (as you can see in many of my scripts) Check out document.evaluate manual
I can put in a font changer as an example on how to do it the clean and fast way, but you can try first, see what you come up with 
|
|
|
dkhal
Script's Author
|
i like it
really soft and small script
so do you want me to add the font changer now and try not using innerHTML but can you give me an example to use evaluate in this situation so i learn how to use it:
document.getElementById('smth').innerHTML="whatever";
|
|
|
JoeSimmons
Scriptwright
|
I just added a simple auto-download feature on my script. Check it out
|
|
|
dkhal
Script's Author
|
yes i thought you wrote
// Copyright dkhal thats what i wrote
but when i saw that it was @copyright i changed it
thanks
|
|
|
JoeSimmons
Scriptwright
|
You didn't until I just told you though lol you had a comment line that wasn't // @
|
|
|
dkhal
Script's Author
|
thats what i do with all my scripts
|
|
|
JoeSimmons
Scriptwright
|
Btw, you can just put // @copyright dkhal in the Greasemonkey headers so it will show on your script's page.
|
|
|
dkhal
Script's Author
|
ok i will thanks i will add your name under developer too
|
|
|
JoeSimmons
Scriptwright
|
I just did the ad remover in mine. You can take mine if you want and put auto-download and font-selector in it but don't use innerHTML anymore... use clean methods. Again, if you need help, pm me on msn (sof-undead@hotmail.com)
|
|
|
dkhal
Script's Author
|
u want me to use your script? really
i saw it and u're right it's better
but as i understood u want me to add auto download to it and i didnt see the font selector in it. want that too?
i'll be happy to do that for you if you want it
|
|
|
JoeSimmons
Scriptwright
|
Thanks for the ratings back. I'd really appreciate it though if they weren't centered; it messes some tabs up. Maybe make an option or a userscript command. If you need help, contact me on msn (look at my site for info)
I made a script to remove the ads.. and no offense but its code is a lot cleaner and a whole lot shorter than yours, I think you should use mine instead as a base for this one and add in auto-download but don't use innerHTML anymore... it's very sloppy and slow. (http://userscripts.org/scripts/show/32825)
|
|
|
dkhal
Script's Author
|
i restored the ratings but this made the font change incompatible
i will find a new way to make both work together (could take a day or two)
until then u can enjoy the new update if you want to
and u can plz delete the resolved errors in the comments
thanks
|
|
|
JoeSimmons
Scriptwright
|
The same one, yes, the "No one like you" tab. It's the electric guitar (not guitar pro or powertab). I gave you the link so you should know.
I'm using Firefox 3 with no other add-ons for the site. Here are some before and after pics...
Before... After
|
|
|
JoeSimmons
Scriptwright
|
Nicely done. I like the font size changer. but the rating isn't there still.
|
|
|
dkhal
Script's Author
|
This should cleanup the ads on ultimate guitar archive and automatically start your download when u click on a song name
|