I understand Viva y Xavier. I believe this routine told before to select monsters less than twice in points (I am learning java with this script sorry)

/* Get the list of all enemies */
var powers = getElementsByClassName("small_avatar_experience", "div", divs[2]);
var names = getElementsByClassName('small_avatar_user_name', 'div', divs[2]);
var urls = getElementsByClassName('small_avatar_attack_link', 'div', divs[2]);

Will look more into it to see if it helps to put it back and will report on it.

berto, i'm swamped right now, so haven't had much time to look at it, but as i see it, it has to do with the changes in Facebook. If you are interested i think it's the parsing of the tables on the fight page that's causing these problems. See if you can work something out in that :)

Example of script results as is now:

18 Attacks: 2 wins 16 losses.

Must say until now was a great script, but since it does not select anymore monsters less than twice your monster´s points, but any monster in the list, it destroys the attack purpose of the script, by attacking too powerfull monsters. Any clues?

October 04 Your Zombie attacked Marie's Vampire 3 times.
But Marie defended with a shield and earned some points!
» You won 0 of the attacks and earned 0 points.
» Marie won 3 of the attacks and earned 3 points.
attack Lennie! October 04 Your Zombie attacked Lennie's Slayer 3 times.
Lennie would have won defending points, but she didn't have any armour!
» You won 1 of the attacks and earned 8 points.
» Lennie won 2 of the attacks and earned 0 points.
attack Lennie! October 04 Your Zombie attacked Lennie's Werewolf 3 times.
Lennie would have won defending points, but she didn't have any armour!
» You won 0 of the attacks and earned 0 points.
» Lennie won 3 of the attacks and earned 0 points.
attack Lennie! October 04 Your Zombie attacked Lennie's Slayer 3 times.
Lennie would have won defending points, but she didn't have any armour!
» You won 0 of the attacks and earned 0 points.
» Lennie won 3 of the attacks and earned 0 points.
attack Lennie! October 04 Your Zombie attacked Lennie's Slayer 3 times.
Lennie would have won defending points, but she didn't have any armour!
» You won 1 of the attacks and earned 8 points.
» Lennie won 2 of the attacks and earned 0 points.
attack Lennie! October 04 Your Zombie attacked Lennie's Werewolf 3 times.
Lennie would have won defending points, but she didn't have any armour!
» You won 0 of the attacks and earned 0 points.
» Lennie won 3 of the attacks and earned 0 points.

Great job Kaz, it works really well. I am looking at the script code to try to figure out how to select to attack monsters with just 1.5 more points than our monster. Can you help on this? thanks, Berto.

fix to latest bug....

replace line:
var APPS_URL = "http://apps.new.facebook.com/";

with line:
var APPS_URL = "http://apps.facebook.com/";

I have been monitoring the results of the attacks of the script and the results of the attacks have gone done drastically. Many more attacks are lost than won because the script does not select anymore monsters who are just 1.5 or 2 times stronger than our attacking monster. Now it attacks any monster on the list, even with 60.000 or more points, and the fights are constantly lost. The rule programmed on the script about attacking monsters just 1.5 or 2 times stronger was a success and a real winner for this script. Now it just contributes to make the defending strong monsters we attack, even stronger. The script can be one of the best with just a few details like the selection of the monsters to be attacked. If it can be arranged it will be greatly appreciate. Thank you also for keeping the script alive with all the effort it involves.

I've been using script for sometime now and it was fine till today. Today I cant seem to switch off the Auto feed and Auto Attack button..... and i dont know what to do.... can anyone help me in that ???

ViXaY Xavier, you were right; Your fix really fixed the problem. For some reason I just didn't see it before I posted my comment.

Thanks for your help.

But I noticed that the Auto Buy function apparently isn't working so well, either, even after your fix: At least I've run out of shield despite having plenty of money to buy for.
Or perhaps it's just me?

Perfect Vixay Xavier. I will be monitoring the reloadevery script. I always have the computer on and the facebook vampire´s application page oppend so will monitore it.

What I noticed with the new lines of code for the monster enhancer is that it does not select anymore enemies 1.5 or 2 times more powerfull than yours (this maximized the chances in the attacks), but rather selects any monster to attact. In the end, the scrip selecs to attack very high rank monsters in the list, and high rank monsters are much harder to defeat. Will investigate to see how far I an go. Thank you again, Berto.

You are welcome. I am aware of that bug and have contacted Piotr about it.

Berto, I assume you are talking about the Reload Every Extension.
I'll explain the way I've set it up.
1) Install Addon ReloadEvery
2) Right Click on the facebook page goto reload every and click custom
3) Now enter whatever time you like (i have it set to 60 minutes)
4) Now leave your browser open forever :P (I have a separate FF3 profile for it)

The only problem I had was that once it asked me if i wanted to send the postback data again, i said yes. After that I haven't had any prompts, so i don't know if that's because I haven't run into more errors, or it's because that it's working. I also haven't tried after restarting the browser, I think maybe it reset when you restart it? I don't know. Experiment for yourself and enjoy the Thrill of discovery! Then share with us :)

A sidenote: The reason I use the extension is because the script doesn't load when the page is incomplete and thus I think there's no way to handle it within the script itself. Unless you hit the try again page, then you can get it to work, i had it working in my old script, you can check it out there and hack away!

Yes, thanks ViXay Xavier, it works great. What it does not work properly is the "Reload Every" routine. Once it is activated, it starts by asking every how long we want to reload, and keeps doing every so often. While keeping in doing it, it bloks the Facebook monster enhancer script until reset again. Any insight?

changes work, thanks.

changes have one teeeeenie bug though "Attacking You's werewolf... (S)" kinda funny, but still works and attacks proper person, not yourself. :)

very well explained VixayXAvier. It is done and I install also the reload script. Will be looking for the changes in the following hours to give the feedback that might be usefull for all. thanks.

I'm assuming this is happening with the new facebook layout only.

No need to upload. To modify:
1) Right-click GM (GreaseMonkey) Icon in Firefox
2) Click Manage User Scripts
3) Select Facebook Monster Enhancer script
4) Click Edit
5) Make the changes, Save
6) Reload page you are working on, it should work

IF it doesn't work
1) Tools>Error Console
2) cilck on errors tab
3) see what is the error produced by GM Script
4) Copy and paste it here (it should be clanm is undefined)

We'll see what we can do from there.

Yes, changed the script code and I am afraid it keeps on doing it. It stops when selecting the oponent to attack. I select it and then goes on. Do we have to upload the script once modified? How to upload it from own computer to greasymonkey? Thank you.

I will try it rideway. How can we edit the script?

Daigoro, Berto, Did you try the solution I've posted below? It'll take care of the problem for now, until Piotr comes back from wherever he's gone. Just find the following lines and change them accordingly.
Before Fix
/* Get the list of all enemies */
var powers = getElementsByClassName("small_avatar_experience", "div", divs[2]);
var names = getElementsByClassName('small_avatar_user_name', 'div', divs[2]);
var urls = getElementsByClassName('small_avatar_attack_link', 'div', divs[2]);
After Fix
/* Get the list of all enemies */
var powers = getElementsByClassName("small_avatar_experience", "div", divs[divs.length]);
var names = getElementsByClassName('small_avatar_user_name', 'div', divs[divs.length]);
var urls = getElementsByClassName('small_avatar_attack_link', 'div', divs[divs.length]);

Great script. It happened the same to me than to harlequin-1998. I believe with the new facebook it needs some rewrite.
Will that be possible?

First of all, this is a great script, which I'm very happy to use.

But it seems to me the fight function has been broken a week or so - but I haven't had time to report it earlier.
Whenever I allow the script to fight, I'm stuck at the http://apps.new.facebook.com/werewolves/fightin... page, where the script isn't running, and thus I manually have to select the person I want to fight - the script then kicks in again, and returns me to the page mentioned.
The same problem exists for Zombies, Vampire and Slayer.

I'm looking forward to see it fixed.

Best regards

For the timeout/error page problem that I have frequently i've found a different solution, Download & Install the add-on "Reload Every" And use that and set it up to reload every hour or so, such that any error page is resolved within an hour :)... hope this helps

I've fixed it temporarily (there's still a bug though)... Like i'd suspected it had to do with the SelectDefender routine.

by changing some lines in the selectDefender routine as follows

function selectDefender () {
var divs = document.getElementsByTagName("td");
//GM_log(divs.length);//DEBUG
if (divs.length < 3) return;
/* Get the list of all enemies */
var powers = getElementsByClassName("small_avatar_experience", "div", divs[divs.length]);
var names = getElementsByClassName('small_avatar_user_name', 'div', divs[divs.length]);
var urls = getElementsByClassName('small_avatar_attack_link', 'div', divs[divs.length]);

basically before we were sending divs[2] now i am sending the last div (i.e. td) by divs[divs.length]

this seems to work well, except the name is always You instead of the actual name..

Until Piotr get's it fixed, this is a good enough option.

I'm encountering a problem (and my Javascript-Fu is not up to par to figure it out). When the script goes to attack someone, the attack page loads up, but the script menu goes away and no attack is actually performed. I didn't change anything (I swear!) and the "included pages" setting appears to be valid. Any ideas?

I'm still using it! And I have a wish-list item as well - I'd like to be able to enable the script to auto-invite. Is that possible?

Need to make it so that when the page hits a facebook error where you have to hit the "Try Again" button it will automatically hit it and let you continue. It seems to only run through about 10 successful things before it hits an error.