<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
I've edited your code to make it a lot more compliant with Greasemonkey conventions.</blockquote>There aren't any Greasemonkey conventions. Don't just make stuff up. I've been doing this much longer than you and will call you on your bullshit.<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
Only a full page refresh (F5) would release the lines.</blockquote>You don't really understand Greasemonkey or Facebook. Greasemonkey only runs my code on a full page refresh, therefore there is only one style element added. I've even checked this myself just to make sure. Load a page in Facebook and click on a link. Then use select all and right-click View Selection Source and you will see only one style element in the head. You should have checked this yourself before accusing my script of having problems. I've been writing scripts for Facebook for over two years and already have my shit figured out.<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<pre>window.addEventListener("load", removeFacebookAds, false);</pre></blockquote>This line makes me chuckle. Did you read my description page?<blockquote>This script <strong>doesn't use listeners</strong> or any of that memory-intensive crap. It just inserts a little CSS into the page.</blockquote> You don't need to wait for the page to load. Greasemonkey already executes on DOMContentLoaded, which occurs before the page loads. You also omitted the anonymous function which throws cross-browser compatibility out the window.
<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<span>The code now only runs on the top most window and only if the style has not been appended to the page.</span></blockquote>Although it's not absolutely necessary, it's probably best that it only runs on the top iframe, so I added a check for that.<pre>if (!head || <b>self.location != top.location</b>) {return}
</pre>
<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717?page=1#posts-176655">wrote</a>:
If you run with this update, it would be nice if you could do the same.</blockquote>lol like I would ever use that ugly bloated code (why not store all the style in a variable? that's what variables are for). its nearly as bad as those crappy xpath ad removers.
<p><blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<br />I've edited your code to make it a lot more compliant with Greasemonkey conventions.</blockquote>There aren't any Greasemonkey conventions. Don't just make stuff up. I've been doing this much longer than you and will call you on your bullshit.<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<br />Only a full page refresh (F5) would release the lines.</blockquote>You don't really understand Greasemonkey or Facebook. Greasemonkey only runs my code on a full page refresh, therefore there is only one style element added. I've even checked this myself just to make sure. Load a page in Facebook and click on a link. Then use select all and right-click View Selection Source and you will see only one style element in the head. You should have checked this yourself before accusing my script of having problems. I've been writing scripts for Facebook for over two years and already have my shit figured out.<blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<br /><pre>window.addEventListener("load", removeFacebookAds, false);</pre></blockquote>This line makes me chuckle. Did you read my description page?<blockquote>This script <strong>doesn't use listeners</strong> or any of that memory-intensive crap. It just inserts a little CSS into the page.</blockquote> You don't need to wait for the page to load. Greasemonkey already executes on DOMContentLoaded, which occurs before the page loads. You also omitted the anonymous function which throws cross-browser compatibility out the window.
<br /><blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717#posts-176655">wrote</a>:
<br /><span>The code now only runs on the top most window and only if the style has not been appended to the page.</span></blockquote>Although it's not absolutely necessary, it's probably best that it only runs on the top iframe, so I added a check for that.<pre>if (!head || <b>self.location != top.location</b>) {return}
</pre><blockquote><strong><a href="/users/111474">ApacheLQ</a></strong> <a href="/topics/36717?page=1#posts-176655">wrote</a>:
<br />If you run with this update, it would be nice if you could do the same.</blockquote>lol like I would ever use that ugly bloated code (why not store all the style in a variable? that's what variables are for). its nearly as bad as those crappy xpath ad removers.</p>
2009-10-08T21:10:36Z
46560
Script
177344
36717
2009-10-09T01:57:56Z
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
27715