Discussions on scripts by Piotr P. Karwasz | Userscripts.org

Script mods from TheDruidsKeeper, replied by J. M. Coward

J. M. Coward — Sat, 22 Aug 2009 17:14:40 +0000

There used to be a switch/case section that would let the script get the hero stats (money, health, energy, &c.); I commented out most of it and replaced it with the following:

/* Other data */
  /* Cash */
  var cash_span = document.getElementById('app8743457343_cur_cash');
  var re = /\$([0-9]+)/;
  var result = cash_span.innerHTML.replace(",","","gi").match(re);
  this.cash = parseInt(result[1]);
  /* Health */
  var health_span = document.getElementById('app8743457343_cur_health');
  this.health = parseInt(health_span.innerHTML);
  var max_health_str = health_span.parentNode.innerHTML;
  max_health_str = stringCleaner(max_health_str);
  re = /\/([0-9]+)/;
  result = max_health_str.match(re);
  this.max_health = parseInt(result[1]);
  /* Energy */
  var energy_span = document.getElementById('app8743457343_cur_energy');
  this.energy = parseInt(energy_span.innerHTML);
  var max_energy_str = energy_span.parentNode.innerHTML;
  max_energy_str = stringCleaner(max_energy_str);
  result = max_energy_str.match(re);
  this.max_energy = parseInt(result[1]);
  /* Stamina */
  var stamina_span = document.getElementById('app8743457343_cur_recovery');
  this.stamina = parseInt(stamina_span.innerHTML);
  var max_stamina_str = stamina_span.parentNode.innerHTML;
  max_stamina_str = stringCleaner(max_stamina_str);
  result = max_stamina_str.match(re);
  this.max_stamina = parseInt(result[1]);
  /* Experience */
  var exp_div = document.getElementById('app8743457343_cur_experience');
  var exp_str = exp_div.innerHTML;
  exp_str = stringCleaner(exp_str);
  re = /Exp: ([0-9]+)\/?([0-9]+)?/;
  result = exp_str.match(re);
  this.exp = parseInt(result[1]);
  /* Level */
  re = /Level: ([0-9]+)/;
  result = exp_str.match(re);
  if (this.level != parseInt(result[1])) this.new_level = 1;
  this.level = parseInt(result[1]);

It's not at all optimized; it's a quick hack I threw together to make sure I could still do NYC jobs.
It references a stringCleaner function that cleans up the HTML for regex parsing:

function stringCleaner(str) {
  str = str.replace(/<[^>]*>/g, '');
  str = str.replace(/[, \t]/g,'');
  str = str.replace(/\r|\n|\r\n/g, '');
  str = str.replace("&nbsp;", " ", "gi");
  return str;
}

Script mods from TheDruidsKeeper, replied by nicegirl99

nicegirl99 — Sat, 22 Aug 2009 02:32:16 +0000

Mine does the hitlisting pretty well and only recently stopped doing the autopurchases because it can't see the cash anymore. It doesn't seem to see the energy either so it has stopped doing jobs.

Script mods from TheDruidsKeeper, replied by J. M. Coward

J. M. Coward — Mon, 17 Aug 2009 13:42:16 +0000

Mine is *barely* working. It can do NYC jobs, and that's about it. I'm hoping to take some time to update to that January greasemonkey release, as Firefox 3.5 is out now, and I'd like to use it.

Script mods from TheDruidsKeeper, replied by thienz

thienz — Sun, 09 Aug 2009 21:16:57 +0000

Does anyone still using this script or made changes so it would work halfway?

Script mods from TheDruidsKeeper, replied by Kevinharbin

Kevinharbin — Fri, 26 Jun 2009 15:25:41 +0000

[quote]Is anybody having a problem loading the Druid's script after activating the FB username feature?[/quote]

YES! That's exactly when it stopped loading. I haven't found a solution to it either.

Script mods from TheDruidsKeeper, replied by Piotr P. Karwasz

Piotr P. Karwasz — Tue, 23 Jun 2009 19:31:46 +0000

<quote>As another note of good news, the original author of the script has sent me message as a request for me to simply send him the updates to the script and he will update the core. So I will start doing that once I stop being lazy and get around to fixing the city auto buy and the quick heal.</quote>

Haven't received anything from TheDruidsKeeper yet, but maybe I can find some time to update the script.

Script mods from TheDruidsKeeper, replied by program3rror

program3rror — Wed, 17 Jun 2009 20:17:00 +0000

Is anybody having a problem loading the Druid's script after activating the FB username feature?

While I'm here, wicked script, thanks for all the hard work Druid....

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Sat, 30 May 2009 18:18:30 +0000

@J.M.
To get the timer to work I basically cheated: in the timer function that the entire script uses (look for Timer.start = function... when the timer is up it checks if the action is an object, if so it 'clicks' it: next_page.click();. That is where the problem was occurring with the Ajax implementations (since the page would no longer refresh), so I added this line: setTimeout(Timer.start, 5000, window.location.href, message, timer); to manually refresh the page after 5 seconds in case it hasn't already happened.

@SoulKeeper
The search script I wrote on page 3 (http://userscripts.org/topics/18417?page=3#post...) looks like it still works just fine for me, but just in case I will increase the time between searches from 0 - 60 seconds to 30 - 90 seconds to see if that has better success. Let me know if this works or if a bigger range is needed.

I haven't gotten around to fixing the quick heal yet, but you're right it is broken. I'm sure it is just some xpaths that are messed up from the changes, it's just a difficult mod to fix since it is all done via ajax.

As another note of good news, the original author of the script has sent me message as a request for me to simply send him the updates to the script and he will update the core. So I will start doing that once I stop being lazy and get around to fixing the city auto buy and the quick heal.

Script mods from TheDruidsKeeper, replied by SoulKeeper

SoulKeeper — Thu, 28 May 2009 01:30:50 +0000

Just a heads up to those who use the search script!!!

Is not working anymore, they know when you do it. You will loose any searches left for the rest of the day.

Script mods from TheDruidsKeeper, replied by J. M. Coward

J. M. Coward — Tue, 26 May 2009 21:01:44 +0000

@TheDruidsKeeper, what did you change to get the timer to work?

Script mods from TheDruidsKeeper, replied by SoulKeeper

SoulKeeper — Sun, 17 May 2009 03:33:14 +0000

Is it just me or the Quickheal is not working anymore?

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Fri, 08 May 2009 12:45:01 +0000

I disabled the extra row of links since I realized that the original links are back to normal.

Script mods from TheDruidsKeeper, replied by Twangy

Twangy — Thu, 07 May 2009 08:09:03 +0000

Cheers Druid, you`re a star! I`ll play around with the settings on the auto buy, it is probably just something I`m doing wrong!

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Thu, 07 May 2009 07:20:52 +0000

OK, i modified the timer on the script so that it will refresh the page and keep going after property purchases / job actions.

@Twangy I'm not sure what is causing the "Hokey Cokey", but I would recommend either turning of auto deposit, or turn off "using money from bank".

Also, since I've been experiencing a huge lack of time, I haven't had the chance to update the auto city buy mod yet for the new property categories. Anyone can feel free to get it working with them and post the changes so I can put them into the script though. :)

Script mods from TheDruidsKeeper, replied by Twangy

Twangy — Wed, 06 May 2009 11:32:26 +0000

I`m really struggling since the latest changes to Mob Wars. The script only seems to work with a bit of prompting (changing pages) and the property buyer has been switched off as it keeps withdrawing money from the bank then putting it back in, then out, then in, its like the Mob Wars Hokey Cokey!

Is anyone else experiencing the same problems? Another one is that Mean bank Loss, Upkeep and Total are all red and minus!

I did try reinstalling the older Firefox but thats not cured anything!

HELP !!!!!!!!

Script mods from TheDruidsKeeper, replied by thienz

thienz — Wed, 06 May 2009 05:55:35 +0000

How about to refresh the page after doing a job? In the actual site layout, after doing job the page stays with the result and the Script Status stays at "Doing <job>... in 0s"</job>

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Tue, 05 May 2009 18:10:24 +0000

Oh the duplicate menu is a "feature" I add added into the script to help with backwards compatibility. By using the bottom menu to go to the different pages it allows the script to update the different quantities. Plus it helps with other scripts like an auto fighter, my mobster invite script, or my no longer working hitlist bot :-/

Script mods from TheDruidsKeeper, replied by SoulKeeper

SoulKeeper — Tue, 05 May 2009 04:09:05 +0000

That Did it! Thanks Druids!!

I still have the duplicated menu, but I can live with that

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Tue, 05 May 2009 00:36:38 +0000

install an older version of greasemonkey. The newer version does not work. I think the latest working version with this script is 0.8.20080609.0

Script mods from TheDruidsKeeper, replied by SoulKeeper

SoulKeeper — Mon, 04 May 2009 18:48:35 +0000

Maybe it's my installation of FireFox (I updated it) but the script is not working anymore. I already tried uninstsalling firefox + greasemonkey + the script but the script is showing this:

-Script status- Cash $24,089,992,172 Bank account $0 City value $0 Stock value $0 Total $24,089,992,172 City income $0 Mean job payout $0 Mean bank loss $0 Upkeep $0 Total $0 Attack Strength NaN Defense Strength NaN

Status: Resting... Enable Quickheal

when I hit the "Script Preferences" Button All I get is:

Script Preferences Update preferences

and my mob wars menu is duplicated:

Home Jobs City Stockpile Fight Hitlist Godfather (64) My Mob (1091)
Home jobs city stockpile fight hitlist godfather mob

Mobwars Page Layout Changed, replied by newb5000

newb5000 — Sun, 03 May 2009 22:18:12 +0000

New jobs weren't showing up for me in the preferences screen (I just unlocked a new job by reaching a new level).

I had to replace the following:

      /* Drops */
      tmp = div.innerHTML.match(/(\d+\%)/);

with this:

      /* Drops */
      tmp = div.innerHTML.match(/(\(\d+\%\))/);

Script mods from TheDruidsKeeper, replied by TheDruidsKeeper

TheDruidsKeeper — Sat, 25 Apr 2009 17:16:43 +0000

The urls for the item images changed, so the regex had to change too:

tmp.match(/(jobs|stockpile|city)[\/\?a-z_=&0-9]+#(item_\d+)/);

Script has been fixed once again.

I have also taken the liberty to add alternate links that can be used to navigate to the different pages just as before, since their changes to the links have caused failure with other scripts.

Script mods from TheDruidsKeeper, replied by thienz

thienz — Sat, 25 Apr 2009 13:33:43 +0000

layout changes again this morning.. please update the script again! :)

thx in advance! :)

Mobwars Page Layout Changed, replied by J. M. Coward

J. M. Coward — Wed, 22 Apr 2009 19:17:55 +0000

japes, you're not going to like the answer to that. I've been clinging to the original script, old schooler that I am. I've glanced at the new stuff in both those scripts, but since I prefer to handle fighting myself, and I agreed with Piotr's original insistence in not having an auto-hitlister, I've been updating his script since October. I've added some tweaks of my own (I occasionally sell undeveloped land, so I want the max number of properties I can sell in the sell box to be 10 instead of 1, &c.).

Thus, I'm unfamiliar with specifics of how those scripts work. I *am* considering a switch to take advantage of the up-to-date Greasemonkey features. I ported my modified version of Piotr's script to a largely incompatible FB app, so I'll have to make sure that I can port either the ++ or the * script before making the switch final.

Mobwars Page Layout Changed, replied by fart man

fart man — Mon, 20 Apr 2009 02:40:18 +0000

J.M. COWARD i undertsnad your directions, im applying the fix now. ill let ya know how it works for me. is this fix for fbmw* or fbmw++?