Discussions on scripts by sethaurus | Userscripts.org

Reader update breaks scipt, replied by stardust69

stardust69 — Sat, 24 Oct 2009 16:59:58 +0000

as top

Reader update breaks scipt, replied by Jashar

Jashar — Fri, 23 Oct 2009 18:16:32 +0000

Confirming the same problem running Safari and Firefox within OS X - no favicons.

Reader update breaks scipt, replied by ocean8535

ocean8535 — Fri, 23 Oct 2009 17:59:16 +0000

The latest google reader update on 10/22 seems to have broken the script. no favicons.

no longer working?, replied by Bakahashi

Bakahashi — Tue, 23 Jun 2009 22:00:39 +0000

It seems not to be working again.

no longer working?, replied by JS365

JS365 — Fri, 05 Jun 2009 22:19:46 +0000

Thanks ludoo. Good job!
It works great with my FF 3.0.10.

no longer working?, replied by dengpeng

dengpeng — Mon, 09 Mar 2009 14:05:31 +0000

Yes, I tried FF 3.1beta2, it worked fine, but 3.0.7 didn't work... There are many users using 3.0.x, so henrah, please move on :)

no longer working?, replied by Lore

Lore — Sun, 08 Mar 2009 21:51:12 +0000

Hi,

I confirm that it doesn't work in Firefox 3.0.7 too, it's because of the document.querySelectorAll method, that AFAIK is not supported in FF 3.0.x but only in FF 3.1.
Is there any supported method (something like a getElementById) that does the same as querySelectorAll?
Thanks,
Lore

no longer working?, replied by willandbeyond

willandbeyond — Mon, 02 Mar 2009 21:17:47 +0000

Hmm, not working on my end still. Running Firefox 3.0.6.

Update domain name regex, replied by sethaurus

sethaurus — Fri, 20 Feb 2009 21:15:52 +0000

This should no longer be an issue now that I have rewritten the script. Sorry it took so long to fix though, vshih!

no longer working?, replied by sethaurus

sethaurus — Fri, 20 Feb 2009 21:14:46 +0000

I've fixed it now! Let the celebrations commence. I changed the script before reading this topic, but thanks anyway for your suggestions, ludoo.

no longer working?, replied by heartilly

heartilly — Tue, 03 Feb 2009 02:48:45 +0000

hey author..
fix it..

i love your script so much

no longer working?, replied by dengpeng

dengpeng — Sat, 31 Jan 2009 01:46:34 +0000

Thanks ludoo, it works fine!

no longer working?, replied by ludoo

ludoo — Fri, 30 Jan 2009 14:08:04 +0000

Hi everybody,

Have fast fix it :
Works under FF3.
This code could improve (img element creation/deletion)...

Can be downloaded/installed from my site or from my space

LudoO

// ==UserScript== // @name Google Reader: Show Feed Favicons // @author henrah / LudoO(xeoos.fr) // @namespace http://henrah.googlepages.com // @include htt*://www.google.*/reader/view* // ==/UserScript==



var Favicons = {

	UNFIXED_ICON_XPATH: '//span[contains(@class,"icon sub-icon")][not(@label)]',

	EXPORT_URL: '/reader/subscriptions/export',

	FAVICON_URL: ['http://', '/favicon.ico'],

	

	PARSE_DOMAIN: /:\/\/([\w\.]+)/,

	

	domains: {},

	cacheIcons: {},

	

	loadDomains: function () {

		var xhr = new XMLHttpRequest();

		xhr.open('get', this.EXPORT_URL, true);

		xhr.onload = function(){

			Favicons.setDomains(xhr.responseXML);

		};

		xhr.send('');

	},

	

	parseDomain: function(url) {

		var match = this.PARSE_DOMAIN.exec(url);

		return match && match[1];

	},

	

	setDomains: function (opmlDoc) {

		var outline, i = 0,

			outlines = opmlDoc.getElementsByTagName('outline');

			

		while (outline = outlines[i++]) {

			if (! outline.hasAttribute('htmlUrl')) continue;

			var title = outline.getAttribute('title');

					

			if (title.length > 24)

				title = title.substr(0, 21) + '...';

				

			this.domains[title] =

				this.parseDomain(outline.getAttribute('htmlUrl'))

				|| this.parseDomain(outline.getAttribute('xmlUrl'));

		}

		setInterval(function () {

			Favicons.fixAllIcons();

		}, 2000);

	},

	

	fixAllIcons: function () {

		var icon, i = 0, label;

		var uncorrectedIcons = document.evaluate(this.UNFIXED_ICON_XPATH, document, null, 6, null);

		while (icon = uncorrectedIcons.snapshotItem(i++)) {

			  label = icon.nextSibling.firstChild.textContent;

	        var urlIcon = this.FAVICON_URL.join(this.domains[label]);

	        var img = document.createElement('img');

	        icon.appendChild(img);

	        icon.setAttribute('label', label);

			img.setAttribute('style', 'display:none');

	        img.src = urlIcon;

	        

	        img.addEventListener("error", function(e){

			  e.target.parentNode.removeChild(e.target);

	        }, false);

	        

	        img.addEventListener("load", function(e){

			  var FAVICON_STYLE= ['background: url(', ');'];

	          e.target.parentNode.setAttribute('style', FAVICON_STYLE.join(e.target.src));

	          e.target.parentNode.removeChild(e.target);

	        }, false);

        

		}

	}

};

Favicons.loadDomains();

no longer working?, replied by dengpeng

dengpeng — Fri, 30 Jan 2009 12:58:47 +0000

I have the problem 2...

no longer working?, replied by Julieee

Julieee — Fri, 30 Jan 2009 08:58:43 +0000

Oh thank God I'm not the only one! I've been trying to fix it for hours now!

Please update the code soon, I miss my little Favicons.

no longer working?, replied by ludoo

ludoo — Fri, 30 Jan 2009 08:32:09 +0000

No, you're right !!
Image are no more <img src/> but background-image instead.
Code must be reviewed.
Adding a img src and inside <span class="icon sub-icon"> seems to be ok.

I'm waiting the update. There will be an update, isn't it ??

Good job, i really like this script !

no longer working?, replied by alala

alala — Fri, 30 Jan 2009 06:23:43 +0000

i really like this script. has it stopped working or is it just me?

Update domain name regex, replied by vshih

vshih — Tue, 02 Dec 2008 19:20:50 +0000

I suggest updating the PARSE_DOMAIN regex to:

/:\/\/([a-z\d-.]+)/

as I have some feeds which have numbers in their domain name, which borks. In fact on my system, it borks my entire Google Reader session by browsing to the Google search results of the bad URL.

Archived Comments, replied by capi /. etheriel

capi /. etheriel — Tue, 30 Sep 2008 13:32:34 +0000

how many times does it request the favicons form servers? it seems to be refreshing all the time...

Archived Comments, replied by harryxu

harryxu — Tue, 30 Sep 2008 11:40:24 +0000

So great! I love it so much!!

Archived Comments, replied by Cryptonium

Cryptonium — Tue, 08 Jul 2008 13:42:25 +0000

Great script, thanks!

It added the only thing I missed when I left Bloglines.

Archived Comments, replied by Chorizotarian

Chorizotarian — Wed, 02 Jul 2008 07:25:35 +0000

This is sweet!

Archived Comments, replied by Peternl

Peternl — Fri, 13 Jun 2008 16:11:10 +0000

Great script thank you.

But I have the same problem with it as dupola.

Archived Comments, replied by dupola

dupola — Thu, 05 Jun 2008 20:50:07 +0000

Well, one question,I see someone don't use the normal URL for favicon file,somebody's like this:
<link href="http://domain.com/images/favicon.ico" />

I see this script could not get the right file,now there still show the default icon by Google Reader.

Then, I see someone's icon file is not favicon.ico,they use favicon.gif etc.

Can you fix the 2 problem?

Thanks.

Archived Comments, replied by dupola

dupola — Thu, 05 Jun 2008 20:03:09 +0000

Great! I really like it.

Thanks very much!