Discussion on userscripts.org Favourites | Userscripts.org

Archived Comments, replied by Raffles

Raffles — Thu, 23 Oct 2008 21:41:14 +0000

Yeah, I know... next week I've got a few days off. If the weather is crap, I'll have a stab at it. :)

Archived Comments, replied by jerone

jerone — Fri, 17 Oct 2008 13:36:49 +0000

Due to site changes this script is broken. Any change in updating it soon Raffles?

Archived Comments, replied by jerone

jerone — Wed, 01 Oct 2008 15:10:11 +0000

I need to add z-index:9999; to #favourites as style to get I above the metadata.

Archived Comments, replied by Avindra V.G.

Avindra V.G. — Tue, 30 Sep 2008 22:26:38 +0000

compressed the css

Archived Comments, replied by Raffles

Raffles — Tue, 30 Sep 2008 22:20:29 +0000

I'm aware that the comments counter is broken after the update to the comments system. I'll fix it when I have time.

Archived Comments, replied by jerone

jerone — Mon, 08 Sep 2008 08:16:47 +0000

I guess, thnx anyways. Still loving your script.

Archived Comments, replied by Raffles

Raffles — Sun, 07 Sep 2008 22:38:21 +0000

OK, done.

That must have been a caching issue of some sort. Odd.

Archived Comments, replied by jerone

jerone — Sun, 07 Sep 2008 18:44:39 +0000

It cases trouble when a script injects an iframe into the window and there are a few useful userscripts here who do (including one of mine).
Beside, it's an easy fix :p

For the second problem, I restarted my browser just before and the problem disappeared.

Archived Comments, replied by Raffles

Raffles — Sun, 07 Sep 2008 12:56:17 +0000

I don't understand - why would that be necessary? I can't find any instance when the header is not present.

As for the second problem, I can't reproduce that. I have a number of script that have not been updated since they were first uploaded and u: always shows the first uploaded time. The script already uses the "First uploaded" time - lines 111 and 322.

Archived Comments, replied by jerone

jerone — Sun, 07 Sep 2008 11:18:28 +0000

Thats great news, thnx.

I've a little suggestion:
change lines 163 and 164 to something like this:

  var navitems = document.getElementById('header');
  if (!navitems) return;
  navitems = navitems.getElementsByTagName('li');
  if (!navitems) return;

This prevents errors with other scripts.

Another problem I came across, was times/dates with scripts like this one; they don't have a "Last updated" time/date. The result is that it always show like this: "u: 12 h ago" and almost every time shows on top when sorted. The solution is to use the first uploaded time (until the "Last updated" is added). I hope you understand my problem and you can fix it.

Archived Comments, replied by Raffles

Raffles — Sat, 06 Sep 2008 20:49:05 +0000

Thanks jerone, I found the error: I was using "First Updated" instead of "First updated". Tiny mistake!

Script has been updated.

Archived Comments, replied by jerone

jerone — Sat, 26 Jul 2008 12:55:38 +0000

Hello Raffles,

Every time I click "Refresh" I'm getting the following error in Firebug:

page.match(/(Last updated|First Uploaded)<\/h6>\s+ <p>([\w\s,]+)\.<\/p>/) has no properties
updateItem("12497", Object)greasemonkey.js (line 668)
(no name)()greasemonkey.js (line 370)

It goes the same for these script numbers: 12497, 3548, 9726, 3412, 30490, 675, 1641.
Can't find any matches between these scripts, but maybe you know what happens.
I've got 41 scripts favourited atm.

Also I've got some small space between the 'Favourites' word and the popuped div. I've fixed it by chancing top: 1.7em to top: 18px.

I don't know if anyone else get these errors too?!

ps. I can't recreate the previous problem and forget about that translation suggestion, you made a good point.

Archived Comments, replied by Charnita Fance

Charnita Fance — Sat, 19 Jul 2008 21:59:21 +0000

Real nice. I wish the 50 faves I had added before this script could somehow be transferred. But I know that's asking too much. Great job tho this is a must have!

Archived Comments, replied by Raffles

Raffles — Sat, 07 Jun 2008 23:43:40 +0000

I've added a small feature: if a script has new comments (i.e. a different number from last time), one of these (») is displayed before the number of comments.

Archived Comments, replied by Raffles

Raffles — Tue, 03 Jun 2008 20:27:04 +0000

Do you mean that it goes into some other order, different to the order you had them in before pressing "Refresh"? That doesn't happen to me, the order stays as it it, and it should, because the list items are not moved or removed at all, only the elements inside each are changed.

As for multiple languages, I find it curious that you would want that, as the rest of the site is in English. Wouldn't it clash horribly? Something I'd rather tackle first is the synchronisation with the site's system.

Archived Comments, replied by jerone

jerone — Tue, 03 Jun 2008 09:32:14 +0000

Still loving your script.

Only comment I have that when I press "refresh" the list below doesn't reorder when I have them sorted on "last update". To fix this the list should be reordered when refreshing is finished.

Do you've got plans in making this script multi-language?
If yes, maybe my script (US_language) would be interesting for you then and I would like to contribute a Dutch translation.

gr J

Archived Comments, replied by Noxumbra

Noxumbra — Mon, 02 Jun 2008 18:52:35 +0000

Thanks for the fix! I love the famfamfam icons :)

Archived Comments, replied by Raffles

Raffles — Fri, 30 May 2008 12:10:09 +0000

Thanks for pointing that out, Gollum. I've updated it to accommodate scripts that haven't been updated and only have a "First uploaded" date.

lastupdated = xpath('//div[@id="right"]/h6[contains(text(), "Last updated") or
  contains(text(), "First uploaded")]/following-sibling::p/text()', true)

Archived Comments, replied by gollum

gollum — Fri, 30 May 2008 10:44:07 +0000

I also use Update scripts, shifting "Favourites" leftward. Which meant editing the css for the #favourites container to left:-17em;
Not asking you to do anything to your script, but it may help others who find the left edge of "Favourites" guillotined .

Archived Comments, replied by Jeton

Jeton — Fri, 30 May 2008 06:24:37 +0000

Raffles, great to hear that. Thanks for your time.

Archived Comments, replied by gollum

gollum — Fri, 30 May 2008 04:43:21 +0000

Script page (h6) header can now be Last updated + First uploaded or just First uploaded. If the latter then script falls over with xpath error.
EDIT: ...script now updated.

Archived Comments, replied by Raffles

Raffles — Thu, 29 May 2008 21:46:40 +0000

jeton: Like I said, my system is completely separate. That is why there are different numbers for each system.

Now that I think about it, I think synchronisation would be a good idea. I'll work on it when I have time.

Archived Comments, replied by Jeton

Jeton — Thu, 29 May 2008 17:44:04 +0000

Here's a screenshot explaining the issue:
http://dl.getdropbox.com/u/4639/usrscrfav.gif

On nr.1 userscripts.org shows that i have 11 favorite scripts. On nr.2 your script displays only 7.
Is your scripts "syncing" with the userscripts.org favorites or it works on it's own?
If so, could you make it sync? :)

Archived Comments, replied by Raffles

Raffles — Wed, 28 May 2008 10:45:43 +0000

Cheers jerone, should be working again.

Archived Comments, replied by jerone

jerone — Tue, 27 May 2008 14:31:22 +0000

Ok, I tested a bit and found out that it only is when linkType is set to 2 (which i prefer).

p.s. Don't forget to update your update list above.