Discussion on inYOf4ceBook | Userscripts.org

Undefined, replied by leoncub

leoncub — Wed, 28 Oct 2009 15:33:01 +0000

Cheers mate!

Undefined, replied by znerp

znerp — Sun, 25 Oct 2009 11:47:18 +0000

I've had a quick look this morning and I believe I've sorted out your 'undefined' problem. The whole code really needs a rewrite though to be honest.

With respect to your other problem though, I can't seem to replicate this behaviour at all. I very rarely use Facebook, and when I do I spend minimal time one it but I will try to spend some time on it at some point to see if I can make it act up. Also FYI, jiggling about and clicking really won't make the script do anything.

Undefined, replied by znerp

znerp — Fri, 23 Oct 2009 13:13:23 +0000

Thanks for the info. I'm busy for the next few days but I will have a look after this weekend.

Undefined, replied by leoncub

leoncub — Fri, 23 Oct 2009 12:32:00 +0000

There is an issue when hovering over a photo posted on either the homepage or a profile page. If the 'crosshair' cursor falls within the bounds of the image and you want to click it, the link will change from what it should be to either http://www.facebook.com/undefined or http://www.facebook.com/search/undefined. This means it is impossible to actually click through to the actual photo or album page because the link is rewritten.

This only happens for pictures that cover the mouse cursor where you want to click. It also does not happen on album pages or when hovering over profile pictures.

Here are two screenshots to illustrate:

http://i37.tinypic.com/1sdvsy.jpg

http://i34.tinypic.com/30a6wpe.jpg

In the first example, the image is only partially obscured so it is possible to move the cursor away enough to get the proper link. However, in the second example, the image that you wish to view is completely obscured by the full-size preview and it is impossible to move the cursor anywhere to get the correct link.

Also, your most recent version of the script appears to be a bit buggy. Sometimes it refuses to give a preview when hovering over photos or profile pics until you "jiggle around" a bit or click somewhere else on the page. Sometimes it doesn't play ball at all no matter what you do. I'm afraid I'm unable to give any further information because there doesn't appear to be any pattern as to when it happens, it is quite random. It affects all types of Facebook pages and all types of image capable of being enlarged by your script.

Memory Leak?, replied by znerp

znerp — Wed, 21 Oct 2009 20:31:13 +0000

Ok, I've had a look and I believe the change I've just made should make it much, much better to use in this way.

Memory Leak?, replied by Andrew Wright

Andrew Wright — Sun, 11 Oct 2009 15:49:14 +0000

I can confirm yanksoccer117's suggestion works. The BOTTOM section of code needs commenting out like so:

// Wait for Facebook's content element to exist
if (self.location == top.location) 
  // var checker=setInterval(function(){
    // if(document.getElementById('content')) {
      // clearInterval(checker);
      process(); // Start the listener
    // }
  // }, 200);

I simple terms, comment out every line except the if statement and process() from the bottom code block!

Memory Leak?, replied by Andrew Wright

Andrew Wright — Fri, 09 Oct 2009 16:07:27 +0000

Same problem here!

And it being called on an interval (as setInterval would suggest) also concurs with my observations that there are lots of CPU usage spikes in my Process Explorer graphs!

I love this script, so I hope it is fixed soon...

Memory Leak?, replied by bugmenot2009

bugmenot2009 — Wed, 07 Oct 2009 19:40:21 +0000

Thanks yank, appreciate it.

Memory Leak?, replied by yanksoccer117

yanksoccer117 — Tue, 06 Oct 2009 03:46:56 +0000

I am seeing this same issue. Memory usage seems to grow steadily as long as the tab is open, even without any activity. I am trying to see which part of the code is causing this and will post back if I find anything.

Edit: Commenting out the setInterval function at the bottom of the code and instead only calling process(); once seems to stop the memory leak for me. I am guessing this kills some amount of functionality, but in general for most uses the script seemed to still be working fine. Until there is an update, I'd suggest doing this.

Memory Leak?, replied by bugmenot2009

bugmenot2009 — Tue, 29 Sep 2009 03:44:04 +0000

Hi, I've been using this script for a long time but recently I have been experiencing a memory leak when I leave a tab with facebook open. If I deactivate the script and change nothing else I experience no leak.

I'm using:
-Firefox 3.5.3
-Greasemonkey 0.8.20090920.2
-AdBlock Plus 1.1.1

I have no other greasemonkey scripts for facebook.

(This is a public userscripts account from bugmenot, so don't PM me if you have any questions about my setup, just post them here and I'll check back)

Image titles, replied by SwornPacifist

SwornPacifist — Wed, 16 Sep 2009 18:59:17 +0000

I love this script, but wanted the title text to show when the images zoom in:

I found a fix by adding some code in the "Normal images" and "Rounded corner images" sections, around the edit I left the beginning and ending lines the same from the script to make it easy to find where they go.

I uploaded the code pieces to:

http://pastebay.com/54828

Click "download" near the top to get the plain text version without line numbers

how can i remove the 'view all photos' function? , replied by znerp

znerp — Thu, 03 Sep 2009 08:10:18 +0000

This script doesn't have that functionality.

how can i remove the 'view all photos' function? , replied by test55555

test55555 — Wed, 02 Sep 2009 22:50:26 +0000

its really annoying and messes with the pictures (keeps on accumulating and then moves the page down).

thanks

broken on just profile pics?, replied by znerp

znerp — Sat, 01 Aug 2009 10:50:46 +0000

Thanks for this blackwind, I've made the change to the script now.

broken on just profile pics?, replied by steeev

steeev — Thu, 30 Jul 2009 11:59:51 +0000

thanks blackwind, that worked for me too

broken on just profile pics?, replied by blackwind

blackwind — Fri, 24 Jul 2009 09:41:39 +0000

In Canada, I'm getting images from "profile.ak.fbcdn.net"; therefore, changing this...

var allImages = document.evaluate("//img[starts-with(@src, 'http://profile.ak.facebook.com/')]|"+

...to this...

var allImages = document.evaluate("//img[starts-with(@src, 'http://profile.ak.')]|"+

...resolves the issue. Cheers!

broken on just profile pics?, replied by znerp

znerp — Wed, 22 Jul 2009 08:29:29 +0000

I've not tested this script specifically, but I spent a few hours on Facebook yesterday playing with one of my scripts (using Facebook is a rarity for me) and I didn't notice any problems at all.

broken on just profile pics?, replied by Simon14

Simon14 — Wed, 22 Jul 2009 00:06:06 +0000

It's working fine for me. I had to refresh the page, not just go to a different page (because of Facebook's use of Ajax)

broken on just profile pics?, replied by blackwind

blackwind — Sun, 12 Jul 2009 10:12:35 +0000

Broken again. Looking forward to the next version. :)

broken on just profile pics?, replied by jms

jms — Tue, 07 Jul 2009 05:00:31 +0000

continuing user. continuing fan. fixed for me!

broken on just profile pics?, replied by znerp

znerp — Sat, 04 Jul 2009 06:48:56 +0000

Anyone wanna take a stab at fixing it?

Well I've had a go. It should work again now.

broken on just profile pics?, replied by brandobean

brandobean — Sat, 04 Jul 2009 01:00:34 +0000

Me too. Used to work when you moused over someone's profile picture in a comment thread right? Bummer, I miss that. Anyone wanna take a stab at fixing it?

broken on just profile pics?, replied by STaRDoGG CHaMPioN

STaRDoGG CHaMPioN — Fri, 03 Jul 2009 22:39:46 +0000

I'm seeing the same thing

broken on just profile pics?, replied by jms

jms — Fri, 03 Jul 2009 04:15:12 +0000

long time user. long time fan. awesome script.

this seems to have happened in just the past couple days.

document.getElementById("content") is null error, replied by sizzlemctwizzle

sizzlemctwizzle — Tue, 05 May 2009 00:02:07 +0000

Could you please change:

document.getElementById("content").addEventListener('DOMNodeInserted', inYoFace, true);
window.addEventListener('load', inYoFace, true);

to this:

// Re-run the code when the page changes
function process() {
  document.getElementById('content').removeEventListener('DOMNodeInserted', process, false);
  inYoFace();
  document.getElementById('content').addEventListener("DOMNodeInserted", process, false);
}

// Wait for Facebook's content element to exist
if (self.location == top.location) var checker=setInterval(function(){
    if(document.getElementById('content')) {
      clearInterval(checker);
      process(); // Start the listener
    }
  }, 200);

It would eliminate the document.getElementById("content") is null error

Edit: Thanks znerp