Discussion on MusicBrainz Artist releases-urls | Userscripts.org

Archived Comments, replied by murdos @ Fri, 07 Nov 2008 18:30:09 -0600

murdos — Fri, 07 Nov 2008 18:30:09 -0600

Yeah, links are broken... because I wrote this script for release-url relationships, not for release-release relationships.

In fact, current part-of-set links support is just a quick hack, by adding the AR type and an icon in the list at the top of the script.
So it shows if there is *at least* one part-of-set relationship. Nothing more.
And that was enough for me, so I have not done anything more...

If you want to improve it (and explore this old and crappy js code...), go for it ;-)
Otherwise I'll probably just disable the link on the icon for release-release relationships.

Archived Comments, replied by voiceinsideyou @ Thu, 06 Nov 2008 23:30:02 -0600

voiceinsideyou — Thu, 06 Nov 2008 23:30:02 -0600

Hey murdos - the part-of-set links don't appear to be working for me; they are generating links like http://musicbrainz.org/artist/caecdea3-21d1-46b... ID is a release's ID) on http://musicbrainz.org/artist/321531fc-db73-4ff... . How are they intended to work? If the release has a previous and a next disc, it'll show two icons to show both links are there? And each icon goes to either the previous or the next release?

Archived Comments, replied by jesus2099 @ Thu, 26 Jun 2008 02:54:37 -0500

jesus2099 — Thu, 26 Jun 2008 02:54:37 -0500

Hi murdos,

Now seeing you snapshot I see that I have the same screen already. I thought you didn't have the white cellpadding between empty cells but you also do.

Look at mine, it's the same, isn't it ?

I just used the function (getSizeOfHashTable) of my last comment to make it work. It was because the length attribute is not always existing on hashtables in javascript (I just learnt it at that same time) …

I'm e-mailing you my current version of your script in case I forgot to say something here. (^_^)

Thank you murdos ! ♥
Tristan

Archived Comments, replied by murdos @ Fri, 13 Jun 2008 16:45:41 -0500

murdos — Fri, 13 Jun 2008 16:45:41 -0500

He is a screen capture:

I've also applied the function names anti-conflict to all my scripts, with a fix for the update checker too (that won't work in Opera anyway).

Archived Comments, replied by jesus2099 @ Fri, 13 Jun 2008 10:59:57 -0500

jesus2099 — Fri, 13 Jun 2008 10:59:57 -0500

Thank you Murdos, no more conflict between them.
Maybe you may apply this function names anti-conflict to your other scripts ?
Or is it too strange ?
I'll try to get a better rendering when I have some time … Could you show me a screen capture of yours please Murdos ?

I have two issues, h2.colspan and a table padding or something.
For the colspan it's because hashtable doesn't have length attribute and alert(relationsIconsURLs.length) gives undefined.
So I used this function (modified because I had errors with the prototype thing. It worked but generated errors elsewhere ?):

function getSizeOfHashTable(ht) {
	var l = ht.length ? --ht.length : 0;
	for (var k in ht) {
		l++;
	}
	return l;
}

Now it's OK, I mean getSizeOfHashTable(relationsIconsURLs) returns 5.

1st problem solved (but maybe just works on Opera?)

For the second one I need a snapshot or something since I have cell padding and it seems you don't. Please :)

PS. you forgot to turn off debug :)

Archived Comments, replied by murdos @ Thu, 12 Jun 2008 08:04:11 -0500

murdos — Thu, 12 Jun 2008 08:04:11 -0500

Could you try the updated version? It should fix function names issues and includes your modified log function.

About, the presentation, it works perfectly for me under Firefox with the compact mode.
Sorry, that means you should look further if you want it to work for you ;)

Archived Comments, replied by jesus2099 @ Wed, 11 Jun 2008 12:04:41 -0500

jesus2099 — Wed, 11 Jun 2008 12:04:41 -0500

It works in Opera now: I renamed two function names to xmlhttpChange7947 and NSResolver7947, I think it's normal that it bugged because they have the same name in your other script (MusicBrainz Subscriptions script:8266).
But what's strange is that I also had to rename xmlhttp to xmlhttp7947! This is not logical (because it's a var declared variable) but now it works … ?!
I wondered if I had to rename xmldoc and other vars but well it already works without doing so …

I changed the debug function to:

function myGM_log(message) {
	if(DEBUG) {
		var logged = false;
		try {
			GM_log(message);
			logged = true;
		} catch(e) {}
		try {
			opera.postError(message);
			logged = true;
		} catch(e) {}
		if (!logged) {
			alert(message);
		}
	}
}

That's it for the functional part. Before I look further into the presentation bits, could you confirm that, in compact mode, you don't have display problems such as broken colspan on <h2> Albums, Singles, Live, etc. or empty cells after Amazon link.

Here's what I have with "AJICO" for instance :
← without script
← with script

Archived Comments, replied by murdos @ Tue, 10 Jun 2008 02:54:14 -0500

murdos — Tue, 10 Jun 2008 02:54:14 -0500

Hi jesus2099!
Yes it still works. Tested with Firefox 2 or 3. And with the new (but a bit old now) MB website release.
It's probably due to Opera (have you upgraded your version?).
Anyway, if you have some fixes for Opera, as usual, I'll be happy to integrate them ;)

Archived Comments, replied by jesus2099 @ Fri, 06 Jun 2008 09:44:34 -0500

jesus2099 — Fri, 06 Jun 2008 09:44:34 -0500

Hi Murdos !
Is this script still supposed to work ?
It doesn't work in my Opera, but maybe it is because of a new MB website release.

Or maybe I don't look at the right place on the page as I'm not sure where it is supposed to insert those links. :)

Archived Comments, replied by Aaron Cooper @ Sat, 15 Dec 2007 18:18:40 -0600

Aaron Cooper — Sat, 15 Dec 2007 18:18:40 -0600

Ah, the problem was Discog's favicon moved.

Archived Comments, replied by Aaron Cooper @ Sat, 15 Dec 2007 18:09:55 -0600

Aaron Cooper — Sat, 15 Dec 2007 18:09:55 -0600

Discogs links do not seem to be showing up anymore... am I the only one having this trouble?

Archived Comments, replied by murdos @ Tue, 29 May 2007 18:31:52 -0500

murdos — Tue, 29 May 2007 18:31:52 -0500

Brian: the script currently only works for *official* and *single-artists* releases (see Known limitations in the description above).

Archived Comments, replied by Brian Schweitzer @ Mon, 28 May 2007 04:35:48 -0500

Brian Schweitzer — Mon, 28 May 2007 04:35:48 -0500

Oops - make that murdos :P

Archived Comments, replied by Brian Schweitzer @ Mon, 28 May 2007 04:31:24 -0500

Brian Schweitzer — Mon, 28 May 2007 04:31:24 -0500

Hey cooperaa - REALLY useful script. I notice, though, on larger discographies, it seems to only list for the first few dozen releases. (See Nirvana for an example.)

Archived Comments, replied by Aaron Cooper @ Sat, 07 Apr 2007 20:59:13 -0500

Aaron Cooper — Sat, 07 Apr 2007 20:59:13 -0500

Idea: add greyed-out icons for missing release URLs and implement a mod of the MusicBrainz.org Search script to search the appropriate source to find the releases URL!

Archived Comments, replied by Aaron Cooper @ Sat, 07 Apr 2007 20:32:25 -0500

Aaron Cooper — Sat, 07 Apr 2007 20:32:25 -0500

Excellent! I've been wanting this for a long time! Thanks a lot murdos! :)

Archived Comments, replied by Jesse Andrews @ Tue, 16 Nov 2004 19:05:37 -0600

Jesse Andrews — Tue, 16 Nov 2004 19:05:37 -0600

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)