Discussion on Text to Link | Userscripts.org

CSS bug, replied by Vaer

Vaer — Tue, 05 May 2009 21:41:21 +0000

Inherit from their parent:

(added spans), (added links) {
	color:inherit;
	background:transparent;
}

Although, it's just come to my mind that the real problem isn't the CSS. It's that "+100" shouldn't be made into a link?

CSS bug, replied by Kim A. Brandt

Kim A. Brandt — Mon, 20 Apr 2009 16:34:19 +0000

... inherit the colour from where?

I don't think this script should add any CSS to the links it's generating. What I like about the way it's done is that links inherit the styles from the CSS on the page they're on and for the position they're in. This makes them unobtrusive and fit right into the page together with existing links (most of the time that is).

Maybe instead you could add some styles to your userChrome.css for the page you're talking about.

IP parsing bug, replied by Vaer

Vaer — Tue, 24 Mar 2009 07:30:00 +0000

Thanks :)

CSS bug, replied by Vaer

Vaer — Mon, 23 Mar 2009 07:17:51 +0000

I've run into a case which are like this on Stack Overflow.

original html:

<div title="this question has an open bounty worth 100 reputation" class="bounty-indicator">
	+100
</div>

after text to link:

<div title="this question has an open bounty worth 100 reputation" class="bounty-indicator">
	<span>
		<a href="tel:+100">
			+100
		</a>
	</span>
</div>

The problem occurs because the css applies a blue background to .bounty-indicator and a blue color to all links:

.bounty-indicator {
	background-color:#0077DD;
	color:white;
}
a {
	color:#0077CC;
}

The only solution I can think of is if you assign a class to the links and spans and add CSS that makes them inherit their color and have a transparent background.

redirect bug, replied by Kim A. Brandt

Kim A. Brandt — Thu, 12 Feb 2009 17:30:08 +0000

Oh right, I didn't really fix anything yet. I just saw the `false positive' in your example and added some rules to the regexp. Just visit any other text document with links in it. It still does what you described.

redirect bug, replied by anonymous_user

anonymous_user — Wed, 11 Feb 2009 22:28:17 +0000

Thanks for the fix :)

IP parsing bug, replied by Kim A. Brandt

Kim A. Brandt — Tue, 10 Feb 2009 20:48:11 +0000

I uploaded the current version of this script, which seams to ignore that pattern. Though it is a valid IPv6 address:) By the way I keep my (close to) up-to-date scripts at the `Script homepage': http://www.mozdev.org/source/browse/prefswitch/....

redirect bug, replied by Kim A. Brandt

Kim A. Brandt — Tue, 10 Feb 2009 20:27:45 +0000

I am not sure if this only happens with Firefox 3 (wyciwyg-scheme [http://en.wikipedia.org/wiki/WYCIWYG]) or also with older versions of Firefox!? I will see what can be done. In the meantime you could use the `Recent pages' drop-down and skip the text-document which would otherwise be re-linkified, what you described as `looping', or you could remove/comment out the part in the source of the script which creates links in text documents.

redirect bug, replied by anonymous_user

anonymous_user — Sun, 08 Feb 2009 21:47:02 +0000

Sometimes a link will send you to another page (or a text file) and when you try to go back it will go to the url and you get in a loop.

One example is the changelog link found on this page: http://www.twotoasts.de/index.php?/pages/midori...

Screenshot: http://img18.picoodle.com/img/img18/3/1/20/f_20...

I found the problem was caused by this script.

IP parsing bug, replied by Vaer

Vaer — Sun, 08 Feb 2009 09:03:12 +0000

IPs in the form "[123.123.123.123]" get parsed to "http://[123.123.123.123]". The square brackets should be removed.

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Thu, 06 Nov 2008 17:03:23 +0000

Do you want to open links in a new tab? Shouldn't that be the job of your browser?

Archived Comments, replied by NotStyle

NotStyle — Wed, 05 Nov 2008 04:08:14 +0000

can be posible "link in new tab" function?

Archived Comments, replied by Midnightrusher

Midnightrusher — Sat, 13 Sep 2008 15:03:57 +0000

No, I mean something other ^^ , but it's not neccessary
forget my idea ;-)

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Sat, 13 Sep 2008 13:39:15 +0000

I guess you are talking about greasemonkey and `Adding items to the menubar'[1].
I do not specifically write scripts for greasemonkey but you're welcome to make
the necessary changes and upload a new script.

You would have to fiddle around with the regular expressions that I used in the
script. When making a callback from a menuitem you could change some boolean
value to signalize a change in the settings.

[1] Adding items to the menubar - http://diveintogreasemonkey.org/advanced/gm_reg...

Archived Comments, replied by Midnightrusher

Midnightrusher — Sat, 13 Sep 2008 10:10:10 +0000

hiho, nice script ;-)

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Thu, 28 Aug 2008 16:22:07 +0000

What we could do is transform a XML into XHTML by using XSLT. I will look into it.
For now I fixed the script so no exception is thrown when encountering unsupported documents.

Archived Comments, replied by Argrithmag Neocram

Argrithmag Neocram — Tue, 26 Aug 2008 13:23:44 +0000

I installed this, however when i navigated to an xml file, not of the text links in the xml file were displayed as links. Any suggestions?

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Wed, 12 Dec 2007 13:57:59 +0000

That's cool.

An explanation for that could be the script makes changes to the HTML-source directly instead of using DOM (objects). It's faster but there're more things to take care of.

Cheers

Archived Comments, replied by bobielawlintine

bobielawlintine — Wed, 12 Dec 2007 07:04:14 +0000

Well with the updated script I no longer experience the problem. Thanks.

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Tue, 11 Dec 2007 21:17:47 +0000

Hmm... it's working for me. Are you sure it's this script and not something else? If you can/like try to run this script alone and turn of the others. Maybe changing the order of executing scripts might help!?

Is that the only site or does that happen all the time?

I guess I would need the HTML-source from that site since it could be that you are served with a slightly different HTML-code then me. You can send it to `kimabrandt at gmx dot de'.

I'm sorry I can't be of a better help at the moment.

Cheers

Archived Comments, replied by bobielawlintine

bobielawlintine — Mon, 10 Dec 2007 18:35:11 +0000

With the script enabled:

http://i14.tinypic.com/71xvfhy.png

and script disabled:

http://i7.tinypic.com/6jmxwys.png

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Sun, 09 Dec 2007 23:02:42 +0000

Do you have a link and/or screenshot?

Archived Comments, replied by bobielawlintine

bobielawlintine — Sat, 08 Dec 2007 07:21:42 +0000

It seems that when I have this script enabled, Google Images will not show.

Archived Comments, replied by Kim A. Brandt

Kim A. Brandt — Thu, 06 Dec 2007 10:57:24 +0000

matrixik I added a variable `AUTO_STOP' which when set to `false' will ask to continue the script (no change). You have to set it to `true' by yourself if you don't want the question to pop up.

To do this:
1) right-click on the Greasemonkey icon in the status-bar
2) click on the `Manage User Scripts' menu-item
3) select `Text to Link' from the list-box
4) click on the `Edit' button
4a) evtl. choose the editor to use
5) search for `const AUTO_STOP' in the script
6) change `const AUTO_STOP = false;' to say `const AUTO_STOP = true;'

Archived Comments, replied by matrixik

matrixik — Wed, 05 Dec 2007 20:47:50 +0000

Can You add option to auto stop change text to link if your script work too long? I don't want to see that message every time.