Discussion on Add Gravatar Everywhere | Userscripts.org

Archived Comments, replied by docwhat

docwhat — Fri, 25 Jul 2008 13:27:08 +0000

Everytime I click "install this script" it blows away all the exceptions I add to the script. Is there a way to update a script without blowing away the exceptions? Other than cut-and-paste, I mean.

Archived Comments, replied by docwhat

docwhat — Fri, 25 Jul 2008 13:24:44 +0000

Good catch nazgullien and jdub! I have fixed the source. :-)

Archived Comments, replied by jdub

jdub — Thu, 24 Jul 2008 08:11:53 +0000

@nazgullien: Change line 293 to read:

var email = el.href.replace(/^mailto:/, '').replace(/\?.*$/, ''),

@docwhat: Please consider the above for inclusion in future versions of this script. :-)

Archived Comments, replied by nazgullien

nazgullien — Fri, 27 Jun 2008 23:52:40 +0000

Hi !

Nice idea !
There is a problem when mailto: links contain

?subject=[...]

parameters, the md5sum computing includes

?subject=[...]

and is erroenous.

example found :

<a href="mailto:contact@site.com?subject=Contact">

Bye !

Archived Comments, replied by docwhat

docwhat — Wed, 25 Jun 2008 13:28:30 +0000

esquifit:

I didn't realize that GM had a storage mechanism. I was caching in-page, but not across pages. Nifty! Thanks for telling me.

I'm not sure storing images is worth it. :-/ I'll think about.

This was actually written as a proof of concept for an "add gravatars" Bugzilla extension. I realized this could work pretty much anywhere and so I made a few tiny changes and submitted it here.

Ciao!

Archived Comments, replied by esquifit

esquifit — Tue, 24 Jun 2008 21:38:58 +0000

Nice idea. I have a couple of suggestions:
1) Cache the mail addresses in order to avoid calculating the md5 multiple times(and making repeated requests to gravavtar.com, although Firefox should handle this already)
2) Cache the images themselves as base64-encoded strings via GM_set/getValue. The current date can also be cached so you can force a new request to gravatars.com in case the cached image is older than, say, one month.

Incidentally this would be highly reusable code. Consider making a library (for caching serialized objects up to a given amount of time) now that GM supports it natively.

Archived Comments, replied by docwhat

docwhat — Tue, 24 Jun 2008 20:59:27 +0000

I didn't add any include sites, since you will probably want to decide when you want it turned on.

Works great for Bugzilla.

Archived Comments, replied by Jesse Andrews

Jesse Andrews — Wed, 17 Nov 2004 01:05:21 +0000

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)