Discussion on Wakaba Extension | Userscripts.org

An Issue, replied by netiaz

netiaz — Sat, 26 Sep 2009 17:50:41 +0000

I know I'm asking too much, but deltaxxiv.org only has 'Subject', 'Comment', and 'File' post fields.

Doesn't work with certain site, replied by netiaz

netiaz — Sat, 26 Sep 2009 04:38:48 +0000

Seems to work now. You're the best.

Quick reply doesn't work., replied by Artrit

Artrit — Wed, 02 Sep 2009 09:07:06 +0000

Hello, at first I have to thank you for a nice work.
I have some problems with 2-ch.ru. Everything works ok, but if I do quick reply, than I become error:The message is empty. Is there something that I can change in script do do this option to work?
Sorry for my poor english.

Code Monkey?, replied by lol_wut

lol_wut — Tue, 23 Jun 2009 22:24:53 +0000

> I hate you!
>> I hate you, too.~
Nothing personal. I wrote it because I wanted to edit this code to add "tips". And I saw THAT.
I've added them, but I won't send it here cuz using crutches in code and source used for tips is aviable here too.

Code Monkey?, replied by O_Lawd

O_Lawd — Tue, 23 Jun 2009 15:28:07 +0000

You are indeed correct. The code sucks, and for my update, I'm completely rewriting it at this very moment, even though I'm concerned about the current length.

> 1) This code contents a lot of repeated code. This is baaad-bad-bad.

Laziness and a lack of function ideas. This is the main issue I'm fixing.

> 2) REALLY long variable names...

They made sense at the time. Don't ask.

> 3) Indent > 10 tabs, Indent > 80 chars on display => hard to edit!

I'm restricting my rewrite to 80 characters total width. Tabbing should be less extreme, I hope.

> 4) Using a lots of variables, that could be even not declared.

I was using more than needed in several sections, for sure. On the other hand, conciseness is not a big goal.

> 5) Using what kind of selectors? Why not jsquery, sizzle or something?..

I've been using document.evaluate and the plain DOM methods. Is it common for userscripts to use external libraries?

> This is code...

Indeed, it is!

This project started with me messing with Javascript to expand images and went all over the place from there. Unfortunately, it has not scaled well and espouses the main issues I have had in programming. I am still learning, and lots of this code was written months back.

The rewrite is going to be more object-oriented.

I hate you, too.~ Thanks for the code review.

Code Monkey?, replied by lol_wut

lol_wut — Mon, 22 Jun 2009 21:25:47 +0000

1) This code contents a lot of repeated code. This is baaad-bad-bad.
2) REALLY long variable names ex: replyBoxContentPostAreaTableSubjectRowRightColumnSubmitTask, replyBoxContentPostAreaTableCommentRowRightColumnTextField.
WTF???
3) Indent > 10 tabs, Indent > 80 chars on display => hard to edit!
4) Using a lots of variables, that could be even not declared.
5) Using what kind of selectors? Why not jsquery, sizzle or something?..
This is code is a big piece of shit.
Author, I hate you!

Doesnt work!, replied by CleaneR_null

CleaneR_null — Sat, 20 Jun 2009 21:16:10 +0000

No, I think on other it's ok!

Thanks for reply and oh, I also forgot :).

Doesnt work!, replied by O_Lawd

O_Lawd — Sat, 20 Jun 2009 01:24:37 +0000

Woops, I forgot to reply to you. Those errors you showed me were, believe it or not, from the site's wakaba3.js, not my script. That page uses a different format from other Wakaba boards, so Wakaba Extension will not work with it at this time. I'll see what I can do, though. :)

Does it work on other sites?

Doesnt work!, replied by CleaneR_null

CleaneR_null — Fri, 12 Jun 2009 15:29:02 +0000

Hello it's me, I forget pass and created new acc.

I send you all logs to PM

Doesn't work with certain site, replied by O_Lawd

O_Lawd — Mon, 08 Jun 2009 19:55:48 +0000

This issue happens with other sites, as well. It is due to an inconsistency in the Content-Type defined in the <meta /> tag versus that in the server header.

I will update the script with the temporary fix I've been using.

Doesn't work with certain site, replied by O_Lawd

O_Lawd — Mon, 08 Jun 2009 19:32:51 +0000

The issue is related to Thread Hiding. Disable it, and I'll look into it. I may even release a small patch in a bit.

Doesnt work!, replied by O_Lawd

O_Lawd — Mon, 08 Jun 2009 19:23:39 +0000

Do control-shift-J on the keyboard and tell me what the Error Console says.

Also try re-downloading the script.

Thread expansion won't work, replied by O_Lawd

O_Lawd — Mon, 08 Jun 2009 19:22:22 +0000

Hi, I remember one site acting up with it due to XHTML/HTML inconsistency. I'll look into it.

Doesnt work!, replied by CleaneR

CleaneR — Mon, 01 Jun 2009 23:21:49 +0000

Hello!

I have installed this script and tryed to work with *.iichan.net, but anything is showing up. Script is laoded and i dont see that something changed.

Please help in adv.

I ma using FF3

Doesn't work with certain site, replied by netiaz

netiaz — Tue, 26 May 2009 12:08:32 +0000

I thought it was neat that deltaxxiv was in the list. Sadly, the site does not work with this script.

Thread expansion won't work, replied by dirtypants

dirtypants — Sun, 24 May 2009 02:32:11 +0000

I've used all of the versions of this script with my own Wakaba board and they've been great. The added features have always been so reliable. But somehow in this version it broke the thread expansion aspect of the site -- expand and collapse both act like they are doing something, yet they don't.

I don't really want to put the url for the forum up here. But have you heard of this before? If not, can I get earlier versions?

Thanks!

Sage and form data, replied by O_Lawd

O_Lawd — Sat, 04 Apr 2009 21:23:14 +0000

Hi, Username.

Your solution sounds nice and sound. I avoid potential name conflicts whenever I make or manipulate forms, but it is a better alternative to losing form data. I'll fix it sometime in the next release.

Sage and form data, replied by Username

Username — Fri, 20 Mar 2009 01:16:55 +0000

Hi, I've made a massive board extension script once, and quicksage didn't break builtin form data storing. If this is still an issue in your script (can't be bothered to check), here's the solution: checkbox must have name identical to email name field, value should be "sage", and you don't have to do any extra processing for its events. If it's checked, postdata will contain "&mail=sage" and won't otherwise, which has an effect of empty mail parameter. Actually, the whole sage thing took 2 lines in my code and worked flawlessly:

if (config[0] && (url_[1] == 'res') && (elt = $n(host_strings.email[location.host])))
	elt.parentNode.innerHTML = '<label><input type="checkbox" name="' + host_strings.email[location.host] + '" value="sage" style="margin-left:0pt;padding-left:0pt"/> sage</label>';

Archived Comments, replied by alala

alala — Fri, 14 Nov 2008 11:54:44 +0000

Any chance you can write a version of this for Kusaba boards?

Archived Comments, replied by 3d0xp0xy

3d0xp0xy — Mon, 03 Nov 2008 19:36:35 +0000

The script loks better than ever now.
I was just wondering if you were planning on doing a script for Kareha boards?

Archived Comments, replied by O_Lawd

O_Lawd — Fri, 19 Sep 2008 23:59:05 +0000

Hello all,

It's been a while since I've been working on this due to university commitments and a broken laptop, so I have just seen this reported issue.

It sounds like there was a change in Opera's handling of userscripts. Greasemonkey (and Opera, at least the last version I tested), always loaded the script after the page load regardless of any event listeners, but it seems that this behavior is no longer in effect. (Incidentally, a load listener similar to operauser's was implemented quite a while back during development but was later ditched because it was deemed unnecessary due to this behavior.)

Thank you, operauser, for the report and fix! I'll get the newest Opera here and run some tests, and then I shall update this script with a similar fix.

3d0xp0xy, yes I'm probably going to add those in.

UPDATE: Strange, it actually works fine for me in the latest Opera. Still, I'll go ahead and add in the event listener.

Archived Comments, replied by operauser

operauser — Wed, 03 Sep 2008 14:53:34 +0000

For Opera Users
I just got the script to work, basically the problem was that the code wasn't being started by a listener, that means, it wasn't starting after the loading of the website but apparently on the middle of it. And thus, some objects that were required in fact weren't even created.
The solution? Add an even listener like this:
addEvent(window, 'load', init);
Then, copy all the code in o_lawd's script that IS NOT INSIDE OF A FUNCTION, and paste it inside of that INIT function. LEAVE ALL THE DEFAULT OPTIONS OUTSIDE ANY FUNCTION.

If you feel lazy, here's the code:
http://userscripts.org/scripts/show/33088

Thanks again to o_lawd for this extremely useful script.

Archived Comments, replied by 3d0xp0xy

3d0xp0xy — Tue, 02 Sep 2008 18:17:33 +0000

That options menu is awesome!

Also, simple feature request:
▲ and ▼ links to jump to the previous or next thread, respectively.

Archived Comments, replied by operauser

operauser — Tue, 26 Aug 2008 18:34:12 +0000

Hi, I just tested this on Opera 9.52 and it doesn't seems to work. The script loads fine, because I tested it with an alert(0) on the beginning, but none of the options are loading. For instance, if you add an alert() on line 1699, just after
if (document.getElementById('delform') && window.location.href.indexOf('task=') == -1)
, you won't get an alert. So it's not working, basically.

Archived Comments, replied by O_Lawd

O_Lawd — Tue, 12 Aug 2008 23:37:57 +0000

scientus: I have went ahead and implemented your suggestion. Right now, I have it set to limit image size by width. A maximum height makes sense, too, so I will add a maximum height limit tomorrow.

discret: Bookmarking threads is becoming a possibility as I have already spoken to one individual about it. I will need to think about a good way to implement post quoting previews, though.