Discussion on Haaretz Enhancer | Userscripts.org

Replacing the white background, replied by LL25255252

LL25255252 — Mon, 25 May 2009 10:35:59 +0000

Here's my script to add some color to the white background of the Haaretz sites.

http://userstyles.org/styles/18191 (install it to stylish for a better result).

BTW - these 2 scripts don't conflict (you can install them both).

Archived Comments, replied by pagis

pagis — Sun, 02 Nov 2008 07:20:22 +0000

Great script Lior,
I've been using it for a couple of years and it makes a huge difference. Thanks so much!
Now, with the new Haaretz website (god knows why they changed it) I have to surf TheMarker to read financial news.
Any chance you can make this work on TheMarker?

And thanks again for writing this script :)

Archived Comments, replied by dirkhaim

dirkhaim — Mon, 27 Oct 2008 17:44:01 +0000

Wonderful. I can scroll again! Thanks

I think Haaretz's website is a very good example of very bad programming. Nothing to be done about it.

I hope Lior will put a fix to this issue into the next version of the scripts.

Archived Comments, replied by benleevolk

benleevolk — Mon, 27 Oct 2008 15:06:01 +0000

@dirkhaim - you're right again. The problem is not a frame but a wrapping "div" element around the entire content, which for him the overflow property is set to "scroll", while the overflow property of the <body> and <html> is set to "hidden" (that's an outstanding example for poor programming). I've managed to fix it by re-constructing the DOM tree and altering the script as follows.
Insert the following block immediately after the //#### Improve main page line:

	// fix scrolling 
	contentDiv=$("content");
	for(i=contentDiv.childNodes.length-1;i>=0;i--) {
		insertAfter(contentDiv.childNodes[i], contentDiv);
		removeNode(contentDiv.childNodes[i]);
	}
	removeNode(contentDiv);
	document.body.style.overflow="auto";
	document.body.style.textAlign="-moz-center";
	htmlElement=document.getElementsByTagName("HTML");
	htmlElement[0].style.overflow="auto";

Now that's supposed to solve your problem. It might make the page load slower than usual, but a good side-effect of this fix is that it makes the "Open articles inside this page (Haaretz Enhancer feature)" checkbox visible again.

Not sure whether that's the best solution - perhaps other people will have better ideas.</html></body>

Archived Comments, replied by dirkhaim

dirkhaim — Sat, 25 Oct 2008 17:12:20 +0000

Thanks. That does the trick.

Now I am left with one issue in Haaretz's website. When the website loads and I want to page down with a 'space', it seems like the page is made out of a few frames with the content being in one of them. This causes a pagedown but not in the content. You can try to get to this situation by loading the website and after it loads, just press the space-bar. This one is really annoying.

I would love to see the script fixes this problem, if it's possible.

Archived Comments, replied by benleevolk

benleevolk — Sat, 25 Oct 2008 10:54:50 +0000

@dirkhaim:
The change I made was copying the following block:

//## Stop auto-refresh of the page.
//	Taken and modified from Pirateshark's http://userscripts.org/scripts/show/3587
//	who in turn took it from http://dunck.us/collab/DisableAutoRefresh
allElements = $x("//meta[@http-equiv='Refresh']|//meta[@http-equiv='refresh']|//meta[@http-equiv='REFRESH']");
allElements.forEach (function(e){
	var content = e.getAttribute("content");
	var stopTimer = window.setTimeout("window.stop();",(content-1)*1000); // in case load hasn't finished when the refresh fires
	window.addEventListener("load", function(){ try { window.clearTimeout(stopTimer); } catch(ex) {} window.stop(); }, true);
});

And moving it above the following lines:

//feature is active only inside main page + printed list articles.
if ( (isSectionPage || isMainPage) || (isCaptainMain || isCaptainSection) ){

For me, at least, it works well and doesn't cause any other bugs - but since I'm not familiar with the entire script as well as Lior I won't upload a "fixed" script and wait for him to do it. If anything get mixed up you can always restore changes by re-installing the script from this page.

Archived Comments, replied by dirkhaim

dirkhaim — Sat, 25 Oct 2008 09:26:53 +0000

benleevolk, any chance you can put a link to the modified version or maybe paste the diff here?

Thanks

Archived Comments, replied by benleevolk

benleevolk — Thu, 23 Oct 2008 16:38:31 +0000

Hi Lior,
A small fix: the code segment which removes the auto-refresh is within the scope of the following if statement:
if ( (isSectionPage || isMainPage) || (isCaptainMain || isCaptainSection) ), the therefore only applies for the main page and section pages, and not for article pages.
(Although one can argue there's no need for it on article pages since you can open articles in the main page, I personally like sometimes to open sole articles in seperate tabs.)
I moved the code segment on my machine from outside the scope of the if statement and now it applies for all pages on haaretz - perhaps this fix will help other uses as well.

Thanks for the wonderful script! :)

Archived Comments, replied by Matan

Matan — Tue, 15 Apr 2008 07:07:06 +0000

Thank you Lior, I have converted many people to greaseMonkey by showing them before and after versions of the Haaretz site. Your script makes that site so much better. A real killer app for Hebrew readers.

Archived Comments, replied by Dov

Dov — Fri, 11 Jan 2008 16:59:05 +0000

To eliminate the frame obscuring the first talk-backs, just add www.chart.co.il to adblock as a filter.
enjoy

Archived Comments, replied by Lior Zur

Lior Zur — Sun, 03 Jun 2007 13:38:20 +0000

Zaphod: Excellent, thank you. I coded the script so that quick solutions like yours are easy to create, and I'm glad it works. I'll incorporate your change.

Archived Comments, replied by Zaph0d

Zaph0d — Sun, 03 Jun 2007 08:22:45 +0000

I've added these lines to the main block (let's say, after the end of "if (isPrintArticleList) {" block).
----Code start----
//#### Remove ads_frame
removeElements("//iframe[@id='ads_frame']");
-----Code end-----

This solves the talkback being hidden problem.

As the Blue Raja says: "Cheerio!"

Archived Comments, replied by Lior Zur

Lior Zur — Tue, 27 Mar 2007 17:50:39 +0000

"me": the ad you're complaining about can be eliminated using Adblock. Just set Adblock to block this iframe.

Archived Comments, replied by me

me — Fri, 24 Nov 2006 08:50:18 +0000

this is very nice. can you also do something about the text ads at the bottom of haaretz articles. the ads overwrite the first few talkbacks... this is in firefox 2 on windows. thanks!

Archived Comments, replied by lycralout

lycralout — Thu, 16 Nov 2006 10:31:59 +0000

This is *so* useful. Makes the Ha'aretz site actually readable. Kol hakavod.

Archived Comments, replied by Lior Zur

Lior Zur — Fri, 27 Oct 2006 09:38:26 +0000

Hi Anonymous One, I appreciate your effort, but I can't understand exactly what you fixed. Why don't you e-mail me with precise details? I'm at liorzur -at- yahoo -dot- youknowwhat.

Archived Comments, replied by mar 1

mar 1 — Sun, 22 Oct 2006 19:30:19 +0000

Sorry, I'm logged in through BugMeNot. I hope line breaks will work this time.

Here is an example article that doesn't get patched:
http://www.haaretz.co.il/hasite/spages/776414.html

I haven't noticed if all articles are like this,
or only the article above which I wanted.
I've solved this, and here is the diff:

65c65
< var reListPrintEdition = /^http:\/\/www\.haaretz\.co\.il\/hasite\/spages/;
---
> var reListPrintEdition = /^http:\/\/www\.haaretz\.co\.il\/hasite\/pages\/LiArtPE/;
215c215
< "//td[@width='280']",
---
> "//td[@width='120']",
228c228
< "//td[@width='470']|//td[@width='470']/descendant::*[@width='470']",
---
> "//td[@width='468']|//td[@width='468']/descendant::*[@width='468']",
232c232
< thisElement.setAttribute("width","760");
---
> thisElement.setAttribute("width","588");

Archived Comments, replied by mar 1

mar 1 — Sun, 22 Oct 2006 19:26:08 +0000

Sorry, I'm logged in through BugMeNot

Here is an example article that doesn't get patched:
http://www.haaretz.co.il/hasite/spages/776414.html

I haven't noticed if all articles are like this, or only the article above which I wanted.

I've solved this, and here is the diff:

65c65
< var reListPrintEdition = /^http:\/\/www\.haaretz\.co\.il\/hasite\/spages/;
---
> var reListPrintEdition = /^http:\/\/www\.haaretz\.co\.il\/hasite\/pages\/LiArtPE/;
215c215
< "//td[@width='280']",
---
> "//td[@width='120']",
228c228
< "//td[@width='470']|//td[@width='470']/descendant::*[@width='470']",
---
> "//td[@width='468']|//td[@width='468']/descendant::*[@width='468']",
232c232
< thisElement.setAttribute("width","760");
---
> thisElement.setAttribute("width","588");

Archived Comments, replied by Yuval Hager

Yuval Hager — Thu, 15 Jun 2006 11:02:52 +0000

This is an amazing script. It actually makes this site readable!

Very good work.

I install this on every computer I arrive, and if I get to view haaretz' site using explorer.. baah..

I think that these kind initiatives shows the power of having an extendible, open-source browser.

Yishar Koah!

Archived Comments, replied by Eyal

Eyal — Tue, 13 Jun 2006 08:32:46 +0000

Hi Lior! Thanks for the script. Works fine so far. My only problem is that the pages other than the main page are opened with wrong encoding (Hebrew Visual instead of Hebrew (Windows - 1255)), so numbers and words get a bit mixed up.
Haven't had any problems with Haaretz, by the way, with FF 1.0.7.
Keep up with the good work!

Archived Comments, replied by mishu

mishu — Sun, 22 Jan 2006 11:55:26 +0000

Anak!!! :))
This script makes Haaretz so much nicer and easier to read! I'll spread the word ;)

by the way, the first article had this message: "Sorry, there was a problem loading the article. Please try again, or try another link. If you conclude the script has broken, report to me." All the other articles were ok!
Also, sometimes the site opens as a blank page. But again, the idea is great :)

Archived Comments, replied by Lior Zur

Lior Zur — Sun, 22 Jan 2006 08:10:23 +0000

Hi mishu, thanks for informing me. It seems the script wasn't compatible with the new Firefox 1.5 and its new greasemonkey. I tried to update it, and should work now. It's still in beta, so tell me of any further problems. You should note that Haaretz's site is a bit messy, so some problems in Firefox 1.5 are its own fault.

Archived Comments, replied by mishu

mishu — Sat, 21 Jan 2006 14:39:49 +0000

Hey there, came across your script here that looks really promising- but unfortunately apart of expanding the columns of the main page, for some reason it doesn't work, and I'd love to see the outcome. the idea of reading articles in the body of the main page is great!!!
Any ideas what may be the problem? I have tried saving the script on my comp. and then opened it in the monkey (in edit) and replaced with the one I saved- still it doesn't work... :(

Archived Comments, replied by Jesse Andrews

Jesse Andrews — Wed, 17 Nov 2004 01:05:53 +0000

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)