Discussion on Indicate off-site Links | Userscripts.org

Archived Comments, replied by Schlick

Schlick — Fri, 10 Nov 2006 11:48:32 +0000

The script works except for domains of type .com.au or .co.uk.

Archived Comments, replied by Shay Nahum

Shay Nahum — Thu, 04 May 2006 20:54:56 +0000

Bug: Doesn't work with RTL languages \ pages.

check out this page:
http://t2.technion.ac.il/~shynahum/links.html
The link to BugMeNot is partially covered by the off-site icon.

Other than that, this script great and useful. Thanks!

Archived Comments, replied by Gopalarathnam Venkatesan

Gopalarathnam Venkatesan — Sun, 08 Jan 2006 11:43:04 +0000

The updated script (v1.2) distinguishes between links that open in the same window vs the ones that open a new/different window.

Also, due to a lot of requests from the users and friends, finally I added support for sub-domains too :)

Thanks everyone for all your feedback!
Special thanks to you Kevin :)

Archived Comments, replied by Kevin Richards

Kevin Richards — Sat, 10 Dec 2005 07:07:14 +0000

You know what would be cool. If the script checked to see if the link was to open in a new window or in the same window, providing a slightly different image for each case. Like for links that go off-site but open in the same window it could be the image you have now, and then for off-site links that open in a new window you could possibly use a green version of the same image. This way we could easily tell the difference between the two different types of links.

That's just an idea I had recently, so I figured I'd throw it your way. By the way, I still think that subdomains shouldn't be labeled as off-site. I know I'm nagging on the issue, but it would really cut down on the amount of false positives your script gives out (which for me is usually 100+ a day).

Archived Comments, replied by Kevin Richards

Kevin Richards — Fri, 02 Dec 2005 12:47:05 +0000

Ah, I found another bug, although it's only a minor one. If you go to a website and don't precede the address with www., any links that go to pages on the site that use the www. will be marked as off site. So let's say you go to http://somesite.com and there is a link on the website that leads to http://www.somesite.com/page1.html, it will be marked as an off site link. I assume this would also occur if the opposite were to happen (go to the site with the www. typed in and encounter a link without it).

Archived Comments, replied by Kevin Richards

Kevin Richards — Fri, 02 Dec 2005 12:20:46 +0000

Well, the problem with subdomains is that they are sometimes used on free webhosting sites to differentiate between the different sites that are hosted there. In my opinion though, it's far more common for a subdomain to be a part of the site rather than being for a completely separate site. I could be wrong though, but it might be something you could look into or ask about somewhere.

I can use the script on most sites now, although on sites such as http://www.gamestop.com it marks a few links incorrectly as being a different site (because they are a subdomain). That's only a minor nuisance though.

Archived Comments, replied by Gopalarathnam Venkatesan

Gopalarathnam Venkatesan — Sun, 20 Nov 2005 08:22:32 +0000

Thanks a lot, Kevin.

Yes, unfortunately for the first version I missed couple of the things.

1. Handle only HTTP links
2. Do not mark image links with the indicator

The above two things have been added now.

Regarding the sub-domain links, I thought about it, but not sure if I should leave it or mark it as off-site. I deliberately didn't handle that case this time.

Archived Comments, replied by Kevin Richards

Kevin Richards — Sat, 19 Nov 2005 16:59:20 +0000

Hmm... I found another problem with it. If a link points to a subdomain it also labels it as off site, which would be completely incorrect in most cases. It makes sites such as http://deviantart.com look really weird. Since a lot of the sites I visit use subdomains, I'll have to (sadly) disable this script until the problems mentioned here and in my other post are fixed. Good luck on them, and I look forward to when I can use this script again!

Archived Comments, replied by Kevin Richards

Kevin Richards — Sat, 19 Nov 2005 16:53:06 +0000

Pretty good script, and something that I have been wanting for awhile. The only flaw with this script is it labels ALL javascript links as being off site links, when usually this will prove to be incorrect. Just try it out on this site and you'll see what I mean. If you could fix that problem then this script would be flawless (at least as far as I can see right now.) Thanks :D

Archived Comments, replied by Jesse Andrews

Jesse Andrews — Wed, 17 Nov 2004 01:04:59 +0000

The following is an archive of comments made before threaded discussions was implemented (November 16th, 2008)