Discussion on Super Linkifier | Userscripts.org

ircs links, replied by auscompgeek

auscompgeek — Thu, 23 Jul 2009 08:46:24 +0000

currently, the script doesn't work on ircs:// links. could this be changed?
PS irc is in the first regex for some reason. don't know why...

False positive, replied by Crend King

Crend King — Mon, 27 Apr 2009 20:51:10 +0000

I like the style thing this script added, but there are usually frustrating false positive cases such as Linux path "~/.ssh/known_hosts". This is not a linkable path. The problem comes from the long and mysterious regexp replacement

"(\\s[^\\w]?)([\\w-.+$!*\\/(),~%?@&=\\\\]+\\.[A-Za-z]{2,4}\\/|[\\w-.+$!*\\/(),~%?@&=\\\\]*www\\.|(?:(?:[^(mailto)][.\\w-]+:)?[.\\w-]+@)?(?:(?:[0-1]?[\\d]{1,2}|2[0-4][\\d]|25[0-5])(?:\\.(?:[0-1]?[\\d]{1,2}|2[0-4][\\d]|25[0-5])){3})\\/|[^(mailto)][.\\w-]+:[.\\w-]+@)": "$1http://$2"

maybe the author should explain a little in comment what does this expression matches, and update from higher compatibility.

slows down browsing drastically, replied by virus_found

virus_found — Fri, 13 Mar 2009 20:16:26 +0000

I have to switch it off, it renders my loading/reloading times unbearable
is it due to some of Greasemonkey's flaws (if any)? or what?

missed links, replied by anonymous_user

anonymous_user — Mon, 16 Feb 2009 12:10:41 +0000

The links on this page are not linkified: https://addons.mozilla.org/en-US/firefox/addon/...

Seems this script is in need of an update.

typo, replied by Crend King

Crend King — Tue, 25 Nov 2008 08:32:29 +0000

There is a typo in line 141: "imporant", which will produce a warning in the error console. Please fix it ;)

Archived Comments, replied by anonymous_user

anonymous_user — Sat, 28 Jun 2008 16:48:46 +0000

Two examples I would like linkified:

example.com
subdomain.example.com

Archived Comments, replied by AbVag

AbVag — Thu, 19 Jun 2008 21:10:33 +0000

I had the Linkification extension for a long while and it served me well. Upon the download and installation of Firefox 3, I lost that extension. I thank you for being there on the rebound. :-)

Oh and to Some Girl: A better way to make the distinction between regular links and the Super Linkifier links is to:
1) At var customizeLinks = false;, change false to true.
2) Play the heck out of the stuff below. For me, I added in a font-family to the linkExtras section so that all the SL links will have a unique font to them.

Archived Comments, replied by Some Girl

Some Girl — Wed, 11 Jun 2008 06:03:54 +0000

Great script!

I made one change -- directly below linky.className = "superLinkifier";, I added:

linky.title = "plain text linked with superLinkifier";

So I'd have some way to tell if a link had been linkified vs. having been an actual link in the first place. (For those who aren't sure what this does: when I hover over a link, that text will appear if the script linkified it. If it was already linked to begin with, that text will not appear.)

Archived Comments, replied by jab416171

jab416171 — Wed, 21 May 2008 01:17:54 +0000

A lot of those links on the testcases.txt page don't work.
One ftp (ends in a period)
and 5-10 of every category after that, with the exception of the last category (images)

Firefox automatically splits long text files into multiple text nodes,
and a couple of the splits happen to be right in the middle of some links on this page.
This is why a couple text links are not fully linkified.

Is there any way to disable that?

Archived Comments, replied by Daniel Philpott

Daniel Philpott — Thu, 28 Feb 2008 18:41:11 +0000

User 'sweeeetah' has posted the SuperLinkifier script with FinalDoom's name replaced with someone else's name. That's the only change. But he posted it more recently it looks like an update on the search page (already has 227 installs).

Archived Comments, replied by Diezi

Diezi — Wed, 26 Dec 2007 19:57:10 +0000

h2oz7v, this script works wonderful with Opera. I've tested it with Opera 9.2x on WinXP.
Thank you very much!

Note: you have to use the name xxxx.users.js if you want it work in Opera.

Archived Comments, replied by h2oz7v

h2oz7v — Tue, 11 Dec 2007 14:42:42 +0000

Is there a way of making this script work for Opera?

Archived Comments, replied by azulmarino

azulmarino — Fri, 02 Nov 2007 23:26:32 +0000

Does not work for this example source code:

<font>
http://refer.ccbill.com/cgi<wbr>-bin/clic...</wbr></font>

Archived Comments, replied by FinalDoom

FinalDoom — Wed, 26 Sep 2007 22:45:49 +0000

I like your ideas. Thanks for the comments. I don't have much time in college right now, but at some point I may do a complete rewrite, and be able to do some of the things you and others have suggested.

Archived Comments, replied by Daniel Dawson

Daniel Dawson — Mon, 10 Sep 2007 19:02:40 +0000

Oops, I guess HTML comments don't work here. Let me try that a different way:

"w w w . e x a m p l e . c o m" should not appear as "http://www.example.com/".

Archived Comments, replied by Daniel Dawson

Daniel Dawson — Mon, 10 Sep 2007 19:00:44 +0000

Hi. First of all, this is an excellent linkifier. I'm using it now. A few comments on the comments:

Everyone is wondering why certain patterns work here but not elsewhere. The answer is simple. Read the notes that appear when you enter a comment here: "We help break your paragraphs and link your links." (Emphasis added.) It's us.o that is creating those links, not the userscript. (If you want proof, just View Source: changes to the DOM, which userscripts make, don't reflect in the source view.)

As for the issue of split text nodes, I don't agree there's nothing you can do about it. It would require modifying your code structure a bit, but when parsing a URL, you could check for a sibling text node. The only trouble is, you would no longer be able to get an XPathResult with UNORDERED_NODE_SNAPSHOT_TYPE. But I think you could use ORDER_NODE_SNAPSHOT_TYPE, and for each node, check if there are more items in the snapshot, and if so, whether the current item's nextSibling is the same as the next item in the snapshot. But as you said, it's a rare occurrence, so you decide whether it's worth the trouble and CPU.

One more thing: I don't like having the text content altered. So e.g. "www.example.com" should not appear as "http://www.example.com/". It would be nice to have an option to keep all the text as is, and only have the alterations in the hrefs. OTOH, looking at the code, it's clear that trying to implement such a thing would probably be an awful hack, due to the preprocessing done in fixLinks. I guess starting over is the best way to do it.

But again, this is an excellent linkifier, much better than its predecessors. Thanks.

Archived Comments, replied by FinalDoom

FinalDoom — Fri, 31 Aug 2007 21:23:16 +0000

Sorry it's been a long time. I have been very very busy, moving, out of town, etc.

I searched Omerta, and it seems to work on the one with a link. It might have just been the same thing on the testcases.txt page, where firefox divides the text node right in the middle of the link.

I uploaded my copy of the script just in case.

Archived Comments, replied by Webb

Webb — Mon, 13 Aug 2007 00:08:21 +0000

The pic is a screenshot of the userstyles.org main page immediately after installing the script.

The current link is http://userscripts.org/?page=2

Archived Comments, replied by FinalDoom

FinalDoom — Sun, 12 Aug 2007 22:06:53 +0000

Webb, please link to that page. I can't do anything with an image. For all I know, it's not linkifying right because the person who wrote the thing put a half link or some formatting that the script won't handle.

Archived Comments, replied by pojo

pojo — Sun, 12 Aug 2007 17:40:58 +0000

i like it :)

Archived Comments, replied by Webb

Webb — Sun, 12 Aug 2007 03:42:25 +0000

I have never found one of these scripts that works.

Archived Comments, replied by FinalDoom

FinalDoom — Sun, 12 Aug 2007 02:03:13 +0000

I had it linkifying subdomain.example.com and 192.168.0.1 before but that raised issues with the things in mikeon and treymon's comments.

A few of the lines on testcases.txt don't likify right because the entire page is one huge textnode, so firefox splits it into 5 or so, sometimes in the middle of a link. Nothing I can do about that-it's a rare occurance.

Good idea with the [link] thing. I'll see about adding that in.

Archived Comments, replied by Lucanos

Lucanos — Thu, 09 Aug 2007 22:19:55 +0000

ADDITIONAL - And yet somehow, the script linkified those strings properly here, but not on the Testcases page...

Strange.

Archived Comments, replied by Lucanos

Lucanos — Thu, 09 Aug 2007 22:18:00 +0000

Excellent adaptation of an excellent adaptation of an excellent script...

When reviewing the test cases at http://yellow5.us/firefox/testcases.txt I found only one or two possible issues/failures/opportunities for improvement.

ftp://user:password@192.168.0.1/test/.
Linkified to ftp://user:password@192.168.0

irc://www.example.com/test/.
Linkified to irc://www.example.com

http://user@www.example.com/test/.
Linkified to http://user@www.example.com

As a possibly suggestion for some of the more common patterns (which do not seem to be Linkified by most of this branch of Userscripts, such as:

192.168.0.1
192.168.0.1.
subdomain.example.com
subdomain.example.com.

Possibly allowing for a link to be inserted after them like "[link]" could prove handy (again, if able to be toggled on and off within the script itself, even if defaulting to off.

Archived Comments, replied by FinalDoom

FinalDoom — Tue, 07 Aug 2007 01:55:08 +0000

Now, with 1.1, it shouldn't linkify anything mistaken for a URL that was presented in the comments. Ought to fix similar things in general as well.