Voting on comments

Posted by Jesse Andrews on Sep 28, 2008

To help highlight good comments and remove the bad ones, I've pushed a new version of the comment system.

Sorry to those of you whose userscripts break!

When you post a comment it automatically get "1 point". Any logged in user can vote thumbs up/down for that comment. When it falls below 0 points it the content of the comment will be hidden by default. (there is a show more link).

Also I've switched to using identicons as the default avatar if you don't have a gravatar.

Thanks to avg for styling suggestions of comments and JoeSimmons for helping with the front end for the new comment voting system.

You could comment on this post if you were logged in.

7 points
login to vote
naoki User
Posted Sep 28, 2008

Woot! great work!

2 points
login to vote
Posted Sep 28, 2008

Lovin' it.

2 points
login to vote
Posted Sep 29, 2008

I'm liking the new change.
But I don't understand why the comment isn't fully width and stuck on 460px.

1 point
login to vote
Posted Sep 29, 2008

@jerone: Jesse commented on the width issue in this post.

@Jesse, avg & JoeSimmons: This is all looking pretty good, thanks again for the time you're spending on this. Also, just to clarify -- "When it falls below 0 points it the content of the comment will be hidden by default." - this means for comments with negative points, right? ie. Comments with zero points will still be shown. Although in saying this I've realised I could create a test comment, vote it down to see and then delete it.

EDIT: I just did create a test comment and vote it down, and I can see there is no zero points. I guess that makes sense actually.

1 point
login to vote
Jesse Andrews article's author
Posted Sep 29, 2008

There is 0 points.

When you create a comment it gets an automatic vote up from you. Voting it down first deletes the initial vote (since you can only vote once), then creates a new vote down.

You can see this by downvoting someone else's comments.

1 point
login to vote
Posted Sep 29, 2008

Oh, ok then. That makes sense then, thanks.

Also, this maximum width issue didn't affect me hugely earlier when I was at work (19" screen), but now I'm at home (22" widescreen) the comments are only taking up half of the space available to them. It's simple enough to sort out with Stylish for now, but a fix for this would be good.

1 point
login to vote
Jesse Andrews article's author
Posted Sep 29, 2008

I'm using http://userscripts.org/scripts/show/34698 and will probably integrate that with the site CSS when I'm off work

2 points
login to vote
Posted Sep 29, 2008

Jesse, I say you use a percent for max-width so it will adjust to everyone's screen relatively equally.

1 point
login to vote
Posted Sep 30, 2008

Well... now, i overwrite the max-width with "none"... :p

1 point
login to vote
Posted Sep 30, 2008

Great idea, very much like youtube, where I think it works well.

1 point
login to vote
Posted Oct 1, 2008

Just a small point here - I've noticed my two comments above both show "-1 points" (nb. points plural) (also, thanks to whoever voted me down :P), and when I further vote either of these comments down it goes to "-3 points", which makes sense. However voting back up takes me to "-1 point" (nb. point singular). If I were to click vote up though (which will have no effect as I've already got a vote up from myself), it changes from "-1 points" to "-1 point".

As I said, it's not a huge issue, but this should be consistent for negative one points.

1 point
login to vote
Jesse Andrews article's author
Posted Oct 1, 2008

znerp,

regarding the issue of you being downvoted, we've been talking in to the forum ( http://userscripts.org/forums/3/topics/9264 ) about how to make voting more transparent and making it so new users don't have the same voting privileges as existing members).

also showing your current status (have you voted for this one) would help with the UI

2 points
login to vote
Posted Oct 2, 2008

I don't mind being downvoted -- people are entitled to opinions -- that wasn't really the point of my post. I was simply pointing out a discrepancy with "-1 point(s)".

Yeah, I've been following that forum topic but I don't have a lot to contribute to that discussion as I don't have much experience with sites with voting.

1 point
login to vote
Jesse Andrews article's author
Posted Oct 2, 2008

znerp,

Unfortunately nor do I - so yell loudly if things suck!

Your issue about -1 is due to:

1) you had -1 votes considering your automatic vote up (eg you vote +1, 2 others voted -1)

2) if you click up it is still -1 (since you already had voted +1)

3) if you click down it removes the +1 you voted and adds a -1 (so there are 3 votes -1 so it totals -3)

1 point
login to vote
Posted Oct 2, 2008

Jesse, I understand all of that. Let me try again -- half of the time negative one points shows up as "-1 point" and the other half it shows up as "-1 points". This was what I was trying to get at.

1 point
login to vote
Jesse Andrews article's author
Posted Oct 2, 2008

ahhh - sorry! I am too tired to be working on this I guess!

I am not really sure if it should be -1 points or -1 point. I'm going to use what rails uses (-1 points) for now unless you guys yell at me! It will be fixed in the next deploy

1 point
login to vote
Posted Oct 2, 2008

it's "-1 points"

There no "s" when...
In English : number == 1
In French : -2 < number < 2

1 point
login to vote
Posted Oct 3, 2008

@ AVG and Joe
you both rock !

1 point
login to vote
aatkco User
Posted Oct 3, 2008

Rating System Is Great Change But New Layout Isn't Good Please Restore Last Layout ( Tow Clomuns : One For User Details And One For Comment ) With Keeping Rating System

1 point
login to vote
Posted Oct 4, 2008
1 point
login to vote
Posted Oct 5, 2008

I've just noticed today (due to a spam commenter, and yes - apparently I am just that slow) that the 'Flag as Spam' option has been removed from comments. Does this mean that spam comments can only be hidden rather than actually removed now? This is fine with spam levels as low as they are currently, but if you picture half a dozen hidden spam comments in a row, that would still take up a fair chunk of screen space.

1 point
login to vote
Jesse Andrews article's author
Posted Oct 5, 2008

znerp,

you are correct. The old functionality still exists (but isn't shown), but I'm experimenting with just having voting. On the admin side I go in and check out people who might be spammers (based on votes) and delete them. Also I want to tweak the voted down comments even more so they only take 20px instead of the current ~80px

2 points
login to vote
Posted Oct 7, 2008

It would be good to see the points system implemented on users comment pages (eg. http://userscripts.org/users/22480/comments). When a user spams on one of my scripts, the first thing I do is look at their other comments before flagging the post/posting it in the spam forum topic. If this was implemented on user comment pages, it would make it easier to flag all spam comments by that user at once rather than leaving their comments on other people's scripts (which tend to be the exact same spam comment as on mine) for other users to deal with.

1 point
login to vote
Jesse Andrews article's author
Posted Oct 8, 2008

znerp, check out http://userscripts.org/home/comments - I've been working on just that feature for a few days now (along with other stuff as you can see)

2 points
login to vote
Posted Oct 8, 2008

Yeah, I've just gotten into work and I can see all of these new features, it's looking really good. I like the new homepage too, and also hopefully now I won't need to click my template "To install scripts you need to be using the Firefox browser with the Greasemonkey add-on installed. Once you have these..." response in the forums as much due to the new help thing.

2 points
login to vote
Posted Oct 8, 2008

A lot of changes, a big step in the good direction.
I think some of them needs to be getting used to.
And a lot of scripts probably needs updates. :p

1 point
login to vote
Posted Oct 17, 2008

Comments hidden by low points don't flow right:

@Jesse: You can fix that with div.comment { clear:both; } in the site's stylesheet.

Update 10/27: Given how good Jesse (et al?) are at removing spammers, it's hard to determine if this has been fixed. I've got my above proposed CSS line in my Userscripts.org - CSS tweaks script.

1 point
login to vote
Posted Oct 17, 2008

And with a 'show' option, also add a 'hide' option.